ZEODE

Firstly, your initial post was just this: Which I think most people would agree is neither helpful or informative in any way. To just write a comment like that with no explanation or context was not helpful. What response would you expect after a comment like that? Secondly, hook time and "performance monitoring" is relative and dependant on many factors, not quite what you make it out to be. You say my plugins are and have But that plugin isn't saying the hook time is excessive, its just showing you the hook times in descending order. To simply assume then that my plugins have "huge issues with exessive time calling hooks" etc shows you don't really understand what is going on. Now to put it into context, there are many other plugins out there, particularly any with anything AI related or stat collecting that also have higher hook times. But just because hook times are longer for a plugin doesn't necessarily mean there is an issue, it just means they are doing more stuff. Unless you are seeing lots of "GARBAGE COLLECT" warnings in the console, which I know you aren't for my plugins, then it is not really indicative of a problem. To make a more informed assessment, I would need more information, which you didn't provide. For example, server hardware spec, how long was the server and/or those plugins running to accumulate that hook time. Around 40 seconds actually isn't that much, depending on circumstances. Now, back to my initial reply of people not reporting such hook times, they aren't. Many people use these without issues. We also use both these plugins on our servers, each server is restarted daily and after 24 hours of running on a fairly busy PVE server with many people who love taking helis, the hook times are rarely above 30 seconds over 24 hours for Heli Signals and Bradley Drops (this is on a highly modified, 170+ plugins PvE server. Much, much higher hook times are on Raidable Bases, SkillTree, and a host of other event plugins that we run. My initial reply may have been a bit abrupt and thoughtless, but then so was your initial comment, and it is sometimes frustrating to read comments like yours from people who don't have a clue of what's gone into the writing of the plugin, how it works, or how it performs and why. But I can assure you my plugins and my code in general is written to be as efficient as I can make it. But for some reason a couple of people get longer hook times than others using the same plugin, in the same way. Now this could be due to a number of reasons, one might be another plugin making calls to my plugin. For example AlphaLoot calling to my plugin to see if it can populate heli_crates, bradley_crates, etc. Or any other plugin checking to see if a supply drop belongs to their plugin or mine, etc etc. Excessive calls to my plugin will add hook time. I can see why a lack of understanding might lead you to draw conclusions that my plugins are "the culprit" when trying to troubleshoot performance, but without understanding all the various factors you should be cautious of pointing fingers, instead maybe approach it in a different way and we could have troubleshooted the issue to see if we could find any reasons why you are having these issues where others are not. However, as I mentioned before, those hook times aren't horrendous, but then, I don't know how long the plugins had been running to get those amounts. Lastly, a couple of updates ago I had already given the plugin a overhaul and code clean up, which I do frequently as my coding improves. The only other person who has reported an issue with hook times reports hook times to have halved (after troubleshooting together on Discord). But again, these hook times are not the norm, so could indicate another issue with your server or some sort of conflict. Edit: After reading your past comments on other devs plugins, I can see your attitude is no different to what it was here. Speaks volumes.

Thanks for the detailed report. This is the wrong place for support issues, please open a support thread in the proper place and I will gladly help you. Then I can keep proper track of progress and keep the discussion pages clear of support, thanks.

The issue is not with my plugin. According to the rules of writing code on Oxide, the hook CanCombineDroppedItem should return either null or true, because this hook returns values object. Hooks which return bool values can return either null, true or false. So the author of the other plugin is incorrect in this case.

Both issues fixed. Update to latest version

Please open a support thread

Thanks for the report, will definitely look into this. I will have to write a check that makes sure they can’t call at monuments.