ZEODE

Changed Status from Pending to Work in Progress Changed Fixed In to Next Version

Changed Status from Pending to Closed

As I've said, it's not something that interests me in adding to the plugin. As a server owner, I would advise you to be cautious of adding too much automation and features which make playing too easy. It makes players lazy and they get bored and leave. I have seen it first hand and on many servers.

Not sure about that, since Brits video where a server has written their own plugin that teleports the crates of the helis to the player, loads of people have since asked for it. XP and ST for Bradley’s is coming in the next update.

First thing to do would be to test the plugin with TruePVE unloaded and confirm you can damage the helis without it loaded. If you can, then you need to edit your TruePVE rulesets to allow players to damage the helicopter.

There is no option for this and it is unlikely to be something I want to add in future. Part of the skill of taking Heli is not to make it crash over deep water etc. This is an important part of the skill and challenge of taking helis. Options like this just make players lazy and they get bored quicker, IMO.

Its impossible to work out what this issue could be caused by without any context or information about what the circumstances are while this error is happening.

Any update?

Changed Status from Pending to Fixed Changed Fixed In to Next Version

Changed Status from Work in Progress to Fixed Changed Fixed In to Next Version

OK I have checked this over, the changes did not affect the plugin. It is working perfectly on my test and live servers. Have you also given the players/groups the correct permissions to have their fish traps enabled with the changes? They need to have at least the "fishtraps" permission.

Changed Status from Pending to Closed

I checked out that plugin, I don't actually have it as it turns out but on their page they say its compatible with Heli Signals. The issue is the dev of that plugin is returning from "ShouldFancyDrop" as if it were a Boolean hook, so they are returning false, which some argue is more logical because we don't want Fancy Drop to act on those signals. However, the hook isn't Boolean and it is much more widely accepted that when returning a hook that requires a non null return value to stop normal behaviour, you should return true (which I do). This was discussed at length in the Oxide/Umod discord a long time ago and this was what was decided. In this case it doesn't hurt anything or break any actions, it just causes the console info spam you are seeing and will continue to do so unless one of us changes the returned hook value. As I'm using the most widely accepted way of returning this type of hook, so I won't change, as this will then cause conflict with many more plugins. This is the same as the console spam that so many servers see with Stack Modifier plugin, as he refuses to return from "CanCombineDroppedItem" hook in the already accepted way as 99.9% of every other dev out there as I described above! Anyway, it's up to you, you could find that hook in his code and change the return value to true instead of false, or just ignore it (or ask him to change it for the reasons explained ) Z

I will have to check out the other plugin code to see why, I imagine that plugin has no checks to make sure it only acts on vanilla signals. Therefore it is trying to act on Heli Signal items and causing a conflict. I have that plugin, so I will take a look tomorrow and see what is causing it and submit a patch to the dev if needed.

Hmm, if heli is blowing up before doing death spiral something is up. Yes, it probably is related to this. Please upload or DM me your config to check out. This shouldn't be possible as I have checks in to prevent this, but there are ways this could happen and it will 100% cause issues.

There were some changes to fishing and fish trap hooks in the last update. I will try and look at this tomorrow on my day off work.

Changed Status from Pending to Closed

It happens sometimes but is rare. I am yet to narrow down what is causing it, as I already have a lot of null checking in the code. It is not doing any harm and is just console spam for info and can be ignored.

This error appears to originate from Carbon, perhaps request support from the Carbon team to understand what this relates to? I will have a look at this error tomorrow when I am home and at the PC. Does this happen every time a heli is killed? Is it a vanilla heli or heli signal heli?

It would appear your loot tables are wrong. You have items with the chance of having 0 amounts. Correct your loot tables and I see if you still see such errors.

Changed Status from Pending to Not a Bug

I have tested and get the same issue4. Looking at ways to get around this now, Will update later.

I have had a brief look and I will maybe make a couple changes, but honestly we are splitting hairs here, the plugin is performant as it is. As I said, the only heavier load is when the plugin loads and unloads. But I had already mitigated this by running those parts of code asynchronously. This means that part of code runs independently, on another thread if you like, while the main thread continues and doesn't "lag" or hold up the server. 2.1 seconds hook time over 10 hours is really insignificant and nothing to worry about. I understand you want the best performance, but I think you are getting too hung up on hook times without understanding it fully, which there is nothing wrong with. Plenty other server owners make this mistake, myself too when I started out. Are there any issues with your server that is making you look to find solutions that I might be able to help with? Because if those hook times are your highest, this is not an issue.