IIIaKa

Hello, Adding the 'CanEntityTakeDamage' hook will indeed solve this issue for your plugin, but it's a workaround rather than a proper solution. You seem to be forgetting that a server can have over 100,000 entities(depending on map size and other factors). Every entity takes damage, and multiple entities can take damage per second. Each instance of damage is already processed by the RealPVE plugin, and if we add additional calls to your hook, that will at minimum double the number of calls. Then other plugins will start requesting their own hooks as well, just to avoid handling support requestsб further increasing the number of operations per damage event. Additionally, your arena is not active 24/7, meaning that in most cases, calls to your hook would be wasted. When they are relevant, they still create unnecessary server load. That’s why RealPVE is designed to work with general-purpose hooks(listed in the Developer API section) that allow marking or unmarking entities and players as PvP. This avoids the need for extra hook calls every time something takes damage. These are universal hooks, meaning your plugin doesn’t need to know about RealPVE, nor does RealPVE need to be referenced in your plugin. You simply call these hooks when a player enters the arena(PvP mode) and when they leave(there’s no need to call the hook on death). This makes the hooks not only efficient but also universal, any future PvE plugin, not just RealPVE, can utilize them. Your plugin doesn’t need to care about PvE plugins, and PvE plugins don’t need to care about your plugin. Nobody needs to worry about future plugins breaking compatibility. I’ve thoroughly documented these integrations in the Developer API section, probably more extensively than most other developers do for their plugins. You just need to read the documentation and copy-paste a few lines into the appropriate places, replacing them with your identifiers. Before adding these hooks(in November 2024), I even discussed this with you in private messages, explained their purpose, and asked you to add them. I even pointed out exactly where to insert the three necessary lines. I personally tested everything at that time, and it worked perfectly with those changes. However, you stopped responding. So I don’t quite understand why you are now asking me to add this hook when there is a proper solution that you already know about, one that will save server owners valuable performance.