Stack Modifier 2.6.7

yup, stacks are busted.  Really hope we can get an update today

Reporting broken as well. Vanilla stacks...

Vanilla stacks for me as well.

Can attest to stack sizing not working

Stack sizes are all vanilla and broken after July Update

yes its broken
------------------------
[Stack Modifier] Default Item's are missing! Notify DEV! Create Support Ticket!:
Motorbike_-1417478274_motorbike_1
Motorbike With Sidecar_1869224826_motorbike_sidecar_1
Bicycle_821588319_bicycle_1
Trike_1991794121_trike_1
Prisoner Hood_-892718768_prisonerhood_1
Handcuffs_-839576748_handcuffs_1

Any ETA on update on this paid plugin?

Khan, where are you? Need update!

On 6/20/2024 at 2:50 AM, Khan said:

@ToxicRust
Heli-signals needs to un-sub from all stack hooks when stack modifier is loaded/installed.

I've messaged the dev in dms, just awaiting a response.

 

Why are you still blaming this conflict on me/my plugins? As I’ve pointed out, you are incorrectly returning false from that hook, which is incorrect. You should only return either null or true from that hook, but you repeatedly ignore this fact and do not correct your error. Please check the assembly and/or Umods Oxide API pages for that hook to see the correct usage, then there wouldn’t be a hook conflict with my plugins or anyone else’s who use that hook correctly.

As I explained in DM to Khan, you can simply turn off the basic stack handling in Heli Signals within the config under General Options:

"Use This Plugin to Control Stacking/Combining Heli Signal Items": false,"

Using that config option will unsubscribe from those hooks on plugin load, but that doesn’t alter the fact that this plugin is not returning from those hooks correctly, which is causing the conflict.

thank you for the UPdate for the Stack.

11 hours ago, ZEODE said:

Why are you still blaming this conflict on me/my plugins? As I’ve pointed out, you are incorrectly returning false from that hook, which is incorrect. You should only return either null or true from that hook, but you repeatedly ignore this fact and do not correct your error. Please check the assembly and/or Umods Oxide API pages for that hook to see the correct usage, then there wouldn’t be a hook conflict with my plugins or anyone else’s who use that hook correctly.

As I explained in DM to Khan, you can simply turn off the basic stack handling in Heli Signals within the config under General Options:

"Use This Plugin to Control Stacking/Combining Heli Signal Items": false,"

Using that config option will unsubscribe from those hooks on plugin load, but that doesn’t alter the fact that this plugin is not returning from those hooks correctly, which is causing the conflict.

Hiya Zeode, I dont use heli signals myself but wanted to thank you for adding that. I wont use plugins that forcefully control the stacks without a option like that. I did a post recently about stack sizes and id like yo know more if you have insight on it. 

the posts in forms under Stack Logic - General - Codefling

Also wanted to give a shoutout to @Khan for coming through on a holiday for this update!

Since in our last conversation you said you would add this update, so it would auto handle it inside your plugin hence why.
People do not read the docs. & its a few lines of code for devs to add.

Unfortunately every server owner will need to find out by trial and error its just the way of life. but once they find they can just turn the plugin controling stacks off its all good

1 hour ago, Khan said:

Since in our last conversation you said you would add this update, so it would auto handle it inside your plugin hence why.
People do not read the docs. & its a few lines of code for devs to add.

Well, since then I decided not to and you didn't reply to me so I am doing my way. Because there is no reason to change since my config option is already there to handle it. I will update my documentation to reflect that and highlight it for people who don't see it. I will instead add a check to only act on HeliSignal items (supply signals) but this will still conflict until you fix your return value from that hook.

On another note, you STILL have not addressed your incorrect usage of the concerned hooks, which is after all the reason for the conflict in the first place. Yet you continually do not respond to this issue. Will you fix the error in your return code for CanCombineDroppedItem ??

You have not messaged me since we last spoke in discord or in dms on codefling so not sure what your talking about.

Also, if you are un-subbing from the hooks like you claim their wouldn't be any conflicts anyway, returning true or false does not matter for the CanCombineDroppedItem hook since it only checks if its not null instead of a bool.

Wulf, cal and a few others had debates about how devs should return the value to over-ride the logic for !=null checked hooks & ultimately it didn't matter since typically only 1 plugin should be controlling stack logic anyways.

I've always returned false to deny something because that is the logical sense.

Theirs nothing wrong with it.

1 minute ago, Khan said:

You have not messaged me since we last spoke in discord or in dms on codefling so not sure what your talking about.

Also, if you are un-subbing from the hooks like you claim their wouldn't be any conflicts anyway, returning true or false does not matter for the CanCombineDroppedItem hook since it only checks if its not null instead of a bool.

Wulf, cal and a few others had debates about how devs should return the value to over-ride the logic for !=null checked hooks & ultimately it didn't matter since typically only 1 plugin should be controlling stack logic anyways.

I've always returned false to deny something because that is the logical sense.

Theirs nothing wrong with it.

You are incorrect, which is causing hook conflicts with all the other plugins out there which use that hook correctly, so it does matter. The maintainer of your abandoned free version has already corrected this. Yes, returning false will override default behaviour, but with the conflict issues. we see.

Ultimately I don't care if you correct it or not, your customers are the ones who will have to deal with the conflicts you cause. I am just raising it to let people know it's not an issue with my plugin, so they can take it up with you. I'm out.

Yikes, okie whatever, at the end of the day mine should control stack logic not any other plugin which is the whole point of it.

So maybe I return false to catch plugins trying to override logic when they shouldnt need to with mine installed.

We don't care about who is right or who is wrong, buyers of this plugin just want it to work with their other plugins and if there is a solution use it if not we need another stack plugin.

Error occurs when trying to 3rd row categories 

08/01 16:40:58 | [Stack Modifier] foreach threw Exception: Apple, 1548091822, apple 100, False

08/01 16:40:58 | Failed to call hook 'ConsoleEditorShow' on plugin 'StackModifier v2.5.9' (KeyNotFoundException: The given key 'apple' was not present in the dictionary.)
at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <467a840a914a47078e4ae9b0b1e8779e>:0
at Oxide.Plugins.StackModifier.CreateEditorItemEntry (Oxide.Plugins.StackModifier+_Items dataItem, System.Single ymax, System.Single ymin, System.String catName, System.String text) [0x0023f] in <a08205b67e5a4c7093ec215fa07ddc4e>:0
at Oxide.Plugins.StackModifier.ShowEditor (BasePlayer player, System.String catid, System.Int32 from, System.Boolean fullPaint, System.Boolean refreshMultipler, System.Boolean filter, System.String input) [0x00637] in <a08205b67e5a4c7093ec215fa07ddc4e>:0
at Oxide.Plugins.StackModifier.ConsoleEditorShow (ConsoleSystem+Arg arg) [0x00089] in <a08205b67e5a4c7093ec215fa07ddc4e>:0
at Oxide.Plugins.StackModifier.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x0059d] in <a08205b67e5a4c7093ec215fa07ddc4e>:0
at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <795304323ac74a298b8ed190a1dfa739>:0
at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000de] in <beb2b64691c64e2b95b99491bd85442c>:0
at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <beb2b64691c64e2b95b99491bd85442c>:0

Yall need to update, it was pushed 2 hours ago. 

Hey I just purchased this plugin and I have it installed and it's not being recoginzed for some reason. Any suggestions?

EDIT: Had to "o.reload StackModifier" in console this now works

Anyone else getting an RPC Error disconnect when moving the craft able chair item within your inventory?

26 minutes ago, SlayersRust said:

Anyone else getting an RPC Error disconnect when moving the craft able chair item within your inventory?

I got that once with another stack plugin. Might be FPs side idk

Move item kick can happen from any plugin ( kits, sorting plugins etc ) any plugin that is messing with items can cause that, considering it's not actively happening for anyone else or myself in my testing I'd be willing to bet it's another plugin causing it, although it would help to see the server console error of that which would have said what it was from, please make a support ticket & I can help you sort out what plugin that is.
( assuming you have the console error ) ?

12 hours ago, Khan said:

Move item kick can happen from any plugin ( kits, sorting plugins etc ) any plugin that is messing with items can cause that, considering it's not actively happening for anyone else or myself in my testing I'd be willing to bet it's another plugin causing it, although it would help to see the server console error of that which would have said what it was from, please make a support ticket & I can help you sort out what plugin that is.
( assuming you have the console error ) ?

This is the entire console error I get

AssertionException: split_Amount <= 0
Assertion failure. Value was False
Expected: True