Shop 2.5.3

7 minutes ago, MeventSupport said:

Hi! Which version of the Shop plugin did you update to?

 version 2.4.24

2 minutes ago, Devil-Steph said:

 version 2.4.24

 

2 minutes ago, Devil-Steph said:

 version 2.4.24

 

I mean which version are you updating from, and which version are you updating to?

2 minutes ago, MeventSupport said:

 

Je veux dire, quelle version effectuez-vous à partir de laquelle vous effectuez la mise à jour, et vers quelle version effectuez-vous la mise à jour ?

The initial version, I believe I started with 2.4.20, then 2.4.22, then 2.4.23, and now I've installed the latest one, 2.4.24

3 hours ago, Devil-Steph said:

The initial version, I believe I started with 2.4.20, then 2.4.22, then 2.4.23, and now I've installed the latest one, 2.4.24

Yo, this is a template thing from updating across multiple versions. Fix is quick. In server console run shop.reset template, then /shop.install in game. Heads up, youll need to reconfigure a couple visual bits after (some labels in the interface), but the shop will open normally again. The military item and vip permission warnings are separate and harmless, you can clean those in the config whenever.

30 minutes ago, Mevent said:

Salut, il s'agit d'un problème de modèle suite à une mise à jour entre plusieurs versions. La solution est simple : dans la console du serveur, exécutez `shop.reset template`, puis `/shop.install` en jeu. Attention, vous devrez reconfigurer quelques éléments visuels (notamment les étiquettes de l'interface), mais la boutique s'ouvrira de nouveau normalement. Les avertissements concernant les objets militaires et les permissions VIP sont sans conséquence ; vous pouvez les supprimer dans la configuration à tout moment.

Great, thank you! Everything works, thank you very much.

It has been taken care of

Hello, is it possible to support the server panel template 5?

15 hours ago, BenDer said:

Hello, is it possible to support the server panel template 5?

Yes, we’ll add that

Hi! Thanks for the v2.5.1 update, the new in-game permission editor for cooldowns/discounts/limits is a great addition

Just wanted to flag a small bug I ran into while testing it — clicking "Add" on Discount / Buy Limits / Sell Limits / Daily Buy or Sell Limits (when the list is still empty) throws an error and doesn't add the entry:

Failed to call hook 'CmdConsoleShop' on plugin 'Shop v2.5.1' (ArgumentException: The value "0" is not of type "System.Int32" and cannot be used in this generic collection.
Parameter name: value)
  at System.Collections.Generic.Dictionary`2[TKey,TValue].System.Collections.IDictionary.Add
  at Oxide.Plugins.Shop.DictionaryAddEntry
  at Oxide.Plugins.Shop.CmdConsoleShop

Looked into it a bit — seems to be in DictionaryAddEntry:

dict.Add(key, field.FieldType.GenericTypeArguments[1] == typeof(float) ? 0f : 0);

Because one side of the ?: is a float literal, C# treats the whole expression as float at compile time — so it ends up always passing 0f even for the int-typed dictionaries (Discount/Limits/DailyLimits), and Dictionary<string,int>.Add() rejects it. Only the cooldown fields (which really are float) work fine as-is.

A tiny fix that worked for us locally:

if (field.FieldType.GenericTypeArguments[1] == typeof(float))
    dict.Add(key, 0f);
else
    dict.Add(key, 0);

Hope that saves you some time tracking it down! Really enjoying the plugin otherwise, thanks for all the work on it

15 hours ago, athlonclub said:

Hi! Thanks for the v2.5.1 update, the new in-game permission editor for cooldowns/discounts/limits is a great addition

Just wanted to flag a small bug I ran into while testing it — clicking "Add" on Discount / Buy Limits / Sell Limits / Daily Buy or Sell Limits (when the list is still empty) throws an error and doesn't add the entry:

Failed to call hook 'CmdConsoleShop' on plugin 'Shop v2.5.1' (ArgumentException: The value "0" is not of type "System.Int32" and cannot be used in this generic collection.
Parameter name: value)
  at System.Collections.Generic.Dictionary`2[TKey,TValue].System.Collections.IDictionary.Add
  at Oxide.Plugins.Shop.DictionaryAddEntry
  at Oxide.Plugins.Shop.CmdConsoleShop

Looked into it a bit — seems to be in DictionaryAddEntry:

dict.Add(key, field.FieldType.GenericTypeArguments[1] == typeof(float) ? 0f : 0);

Because one side of the ?: is a float literal, C# treats the whole expression as float at compile time — so it ends up always passing 0f even for the int-typed dictionaries (Discount/Limits/DailyLimits), and Dictionary<string,int>.Add() rejects it. Only the cooldown fields (which really are float) work fine as-is.

A tiny fix that worked for us locally:

if (field.FieldType.GenericTypeArguments[1] == typeof(float))
    dict.Add(key, 0f);
else
    dict.Add(key, 0);

Hope that saves you some time tracking it down! Really enjoying the plugin otherwise, thanks for all the work on it

Thanks a lot, we’ll check this fix.

I would love to see an option for dynamic pricing on individual shop items instead of only globally.

For example, being able to enable dynamic pricing for resources such as Metal Fragments, Low Grade Fuel, Sulfur, etc., while keeping weapons, clothing, custom items and other shop entries at fixed prices.

Something like an individual item option:

"Use Dynamic Pricing?": true/false

This would make it much easier to balance the economy and prevent bulk-selling or recycler exploits without making the entire shop fluctuate.

An option like this would be really nice :)))