Industrial Custom Skins Fix 1.1.2

This bug is critical and can cause a lot of damage on our servers if players start to dupe the custom items we have. I was about to say THANK YOU for your fix plugin but it's not compiling and gives an error. Please take a look as soon as possible. We're using Carbon, maybe that's the issue. Also it broke our whole server instantly. No plugins are working (/commands) as everyone complains now. We'll try a restart... Oooof

Using this plugin has some bad side effects, all our harmony mods wont load on server boot, with RustServerMetrics loaded players get Rejecting connection - You are already connected as a player!, and in general it has caused some other weird issues and before using this all was smooth

7 hours ago, Flammable said:

This bug is critical and can cause a lot of damage on our servers if players start to dupe the custom items we have. I was about to say THANK YOU for your fix plugin but it's not compiling and gives an error. Please take a look as soon as possible. We're using Carbon, maybe that's the issue. Also it broke our whole server instantly. No plugins are working (/commands) as everyone complains now. We'll try a restart... Oooof

5 hours ago, Ghosty said:

Using this plugin has some bad side effects, all our harmony mods wont load on server boot, with RustServerMetrics loaded players get Rejecting connection - You are already connected as a player!, and in general it has caused some other weird issues and before using this all was smooth

I'm sorry to hear that, seems harmony work in a bit weird way, I already made an update for that!

Thanks for the plugin. Seems items using the same skin but different custom items/names still have the same issue. Specifically the kits from ItemPerks plugin. Any chance for a check to make sure the item has the same custom name? Seems clone genes are also still broke. Thanks.

1 hour ago, Mario said:

Thanks for the plugin. Seems items using the same skin but different custom items/names still have the same issue. Specifically the kits from ItemPerks plugin. Any chance for a check to make sure the item has the same custom name? Seems clone genes are also still broke. Thanks.

Okay, will add checks for that.

2 hours ago, Mario said:

Thanks for the plugin. Seems items using the same skin but different custom items/names still have the same issue. Specifically the kits from ItemPerks plugin. Any chance for a check to make sure the item has the same custom name? Seems clone genes are also still broke. Thanks.

Made an update.

1 hour ago, Tangerine said:

Made an update.

Yea it works now. It also fixed skulls. Only bug I noticed is when pulling an item from a stack it won't update the number it shows on the stack until you close the box UI and re open. But I am just happy the custom item duping is fixed. Thanks again.

Edit: The stack numbers not updating is only happening on the custom item kit that share the same skin, not on default rust items that share the same skin.

Hey mate, are you able to add the item.text field to your checks as well?

3 hours ago, imthenewguy said:

Hey mate, are you able to add the item.text field to your checks as well?

Done, checkout the update.

Attachments disappear from guns when moved via conveyor. Not sure if vanilla behavior or due to this

10 hours ago, Bad Cop said:

Attachments disappear from guns when moved via conveyor. Not sure if vanilla behavior or due to this

I'll check that

12 hours ago, Bad Cop said:

Attachments disappear from guns when moved via conveyor. Not sure if vanilla behavior or due to this

I've checked attachments and it seems to be working fine. Can you contact me in discord to show what happens: metangerine?

13 hours ago, Tangerine said:

I've checked attachments and it seems to be working fine. Can you contact me in discord to show what happens: metangerine?

I'll have to confirm this , something reported to me but haven't had a chance to test out fully

ive an issue with that plugin. it wont start  after server reboot

IndustrialCustomSkinsFix - Patching exception in method null

 [Error] Failed to initialize plugin 'IndustrialCustomSkinsFix v1.1.2' (ArgumentException: Undefined target method for patch method static System.Boolean Oxide.Plugins.Item_CanStack_Patch::Prefix(Item __instance, Item item, System.Boolean& __result))
  at HarmonyLib.PatchClassProcessor.PatchWithAttributes (System.Reflection.MethodBase& lastOriginal) [0x00047] in <6c906b4f1de440f3a86cb0ebb3f48ea6>:0
  at HarmonyLib.PatchClassProcessor.Patch () [0x0006e] in <6c906b4f1de440f3a86cb0ebb3f48ea6>:0

2 hours ago, m3dus4 said:

ive an issue with that plugin. it wont start  after server reboot

IndustrialCustomSkinsFix - Patching exception in method null

 [Error] Failed to initialize plugin 'IndustrialCustomSkinsFix v1.1.2' (ArgumentException: Undefined target method for patch method static System.Boolean Oxide.Plugins.Item_CanStack_Patch::Prefix(Item __instance, Item item, System.Boolean& __result))
  at HarmonyLib.PatchClassProcessor.PatchWithAttributes (System.Reflection.MethodBase& lastOriginal) [0x00047] in <6c906b4f1de440f3a86cb0ebb3f48ea6>:0
  at HarmonyLib.PatchClassProcessor.Patch () [0x0006e] in <6c906b4f1de440f3a86cb0ebb3f48ea6>:0

Could you please provide the specifications of your server, i'm interested in mod(oxide,carbon) and its version.

sure im using trhe latest fp update + oxide version v2.0.6204

ive fixxed the issue and changed line 16

from:
   void Init()

to:
  private void OnServerInitialized()

18 minutes ago, m3dus4 said:

sure im using trhe latest fp update + oxide version v2.0.6204

 

ive fixxed the issue and changed line 16

from:
   void Init()

to:
  private void OnServerInitialized()

Looks like you have another plugin that tries to patch same method at the same time.

3 hours ago, Tangerine said:

Looks like you have another plugin that tries to patch same method at the same time.

oh yes ive the same issues with 2 other plugins damn it ^^

I use Epic Loot among a few other things. They've shown me that if you have an enhanced item, lets use a satchel as an example, along with a regular satchel but with the same skin, it will dupe.

Does anyone know if there's a way I can fix this?

EDIT: The player has just let me know that the name of the item changed to the Epic Loot naming scheme, but you cannot get the Epic Loot bonuses from it. 

A player on my server has discovered that he can dupe skinned "radiationresisttea.pure" items. I use VIP tokens, and even with this installed, he was able to dupe a boat load of those tokens

EDIT: I should add that he was able to consume these, and get the bonuses from the token.

EDIT2: I've made a slight change to the code and it's fixed. The issue was that "item._condition" and "toTransfer.maxCondition" seemed to be mismatched. I changed that check and it's working as intended  I'm not very good with code, so I may have messed something else up, but it's working for me haha!

Basically from this:

if (item.skin != toTransfer.skin ||
    item.name != toTransfer.name ||
    item.text != toTransfer.text ||
    (item.hasCondition && ((int)item?._condition != (int)toTransfer.maxCondition || (int)toTransfer?._condition != (int)item.maxCondition)) ||
    item.contents?.itemList.Count > 0 ||
    item.instanceData?.dataInt != toTransfer.instanceData?.dataInt ||
    (item.contents?.capacity ?? 0) != (toTransfer.contents?.capacity ?? 0))
    continue;

To this:

if (item.skin != toTransfer.skin ||
    item.name != toTransfer.name ||
    item.text != toTransfer.text ||
    (item.hasCondition && ((int)item._condition != (int)toTransfer._condition || (int)toTransfer._condition != (int)item._condition)) ||
    (item.contents?.itemList.Count > 0) ||
    item.instanceData?.dataInt != toTransfer.instanceData?.dataInt ||
    (item.contents?.capacity ?? 0) != (toTransfer.contents?.capacity ?? 0))
    continue;

Industrial Crafter also has issues with copying skin items, can you add a fix for that?