Heli Signals 1.2.23

17 hours ago, SuperKitten said:

Is there a console command we can use to add to ShopUI mod so players can buy them in the shop?

Yes there is. Just like how the store description page says, right under the command section there are many commands you can use. 

hsgive <Profile ShortName> <Steam64ID> <Amount>

2 hours ago, ChristopherS said:

Yes there is. Just like how the store description page says, right under the command section there are many commands you can use. 

hsgive <Profile ShortName> <Steam64ID> <Amount>

I have put that information in and after 6 hours of trying to get it to work, I reached out.  It shows the items and the skins, but it doesn't actually give the supply signal.

11 minutes ago, SuperKitten said:

I have put that information in and after 6 hours of trying to get it to work, I reached out.  It shows the items and the skins, but it doesn't actually give the supply signal.

Curious. I have a plugin that runs the give command fine gives people the item.

This is the config for a different plugin (so you won't be able to use it, it's just an example), but just to show that you can also give a player a skinned supply signal fine too.

 

        {
          "Display Name (for display in the interface)": "Heli Signal (Medium)",
          "ID": 57901706,
          "Chance": 50,
          "Item type": "Item",
          "Image (if empty - the icon is taken by shortname) ": "",
          "Display name (for the item) (if empty - standard)": "Heli Signal (Medium)",
          "Shortname": "supply.signal",
          "Skin": 2920175997,
          "Amount (for item)": 1,
          "Command": "",
          "Plugin": {
            "Hook to call": "Withdraw",
            "Plugin name": "Economics",
            "Amount": 0
          }
        },

Maybe look to see if your plugin can give an item rather than running the command.

EDIT: Just to confirm, can you use that /hsgive command okay from your chat bar? 

3 minutes ago, ChristopherS said:

Curious. I have a plugin that runs the give command fine gives people the item.

This is the config for a different plugin (so you won't be able to use it, it's just an example), but just to show that you can also give a player a skinned supply signal fine too.

 

        {
          "Display Name (for display in the interface)": "Heli Signal (Medium)",
          "ID": 57901706,
          "Chance": 50,
          "Item type": "Item",
          "Image (if empty - the icon is taken by shortname) ": "",
          "Display name (for the item) (if empty - standard)": "Heli Signal (Medium)",
          "Shortname": "supply.signal",
          "Skin": 2920175997,
          "Amount (for item)": 1,
          "Command": "",
          "Plugin": {
            "Hook to call": "Withdraw",
            "Plugin name": "Economics",
            "Amount": 0
          }
        },

Maybe look to see if your plugin can give an item rather than running the command.

EDIT: Just to confirm, can you use that /hsgive command okay from your chat bar? 

Tried the give item and it would only give regular supply signal.  Yes, I can use the chat command fine.

1 minute ago, SuperKitten said:

Tried the give item and it would only give regular supply signal.  Yes, I can use the chat command fine.

Does the plugin you're trying to use allow you to add a skin to it? Would you be able to share the supply signal section of config of the plugin you're trying to get to work?

13 minutes ago, ChristopherS said:

Does the plugin you're trying to use allow you to add a skin to it? Would you be able to share the supply signal section of config of the plugin you're trying to get to work?

This is the item config - 

},
  "supply.signal": {
    "DisplayName": "Heli Signal (Easy)",
    "Skin": 2920175997,
    "Image": "https://codefling.com/uploads/monthly_2023_05/easyHeli.png.0b477b1e73caed8ea6d9b77c024889bc.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 500,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Medium)",
    "Skin": 2920176079,
    "Image": "https://codefling.com/uploads/monthly_2023_05/medHeli.png.7a5c819ae391a4689ef5ad5f468b4773.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 1000,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Hard)",
    "Skin": 2920176050,
    "Image": "https://codefling.com/uploads/monthly_2023_05/hardHeli.png.d6e09ef0a63b1b41ff21903c8999a0d5.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 2000,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Elite)",
    "Skin": 2920176024,
    "Image": "https://codefling.com/uploads/monthly_2023_05/eliteHeli.png.e9c472c85b57e4201f723b125487ad6e.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 4000,
    "SellPrice": 0,
    "Currency": "rp"
  },

I have had it some many different ways.  This way shows all regular supply signals.  Won't skin them.  If I change the supply.signal to Heli Signa (Easy) etc, it will show them correctly but when you click to buy it doesn't give anything.

15 minutes ago, SuperKitten said:

This is the item config - 

},
  "supply.signal": {
    "DisplayName": "Heli Signal (Easy)",
    "Skin": 2920175997,
    "Image": "https://codefling.com/uploads/monthly_2023_05/easyHeli.png.0b477b1e73caed8ea6d9b77c024889bc.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 500,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Medium)",
    "Skin": 2920176079,
    "Image": "https://codefling.com/uploads/monthly_2023_05/medHeli.png.7a5c819ae391a4689ef5ad5f468b4773.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 1000,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Hard)",
    "Skin": 2920176050,
    "Image": "https://codefling.com/uploads/monthly_2023_05/hardHeli.png.d6e09ef0a63b1b41ff21903c8999a0d5.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 2000,
    "SellPrice": 0,
    "Currency": "rp"
  },
  "supply.signal": {
    "DisplayName": "Heli Signal (Elite)",
    "Skin": 2920176024,
    "Image": "https://codefling.com/uploads/monthly_2023_05/eliteHeli.png.e9c472c85b57e4201f723b125487ad6e.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 4000,
    "SellPrice": 0,
    "Currency": "rp"
  },

 

I have had it some many different ways.  This way shows all regular supply signals.  Won't skin them.  If I change the supply.signal to Heli Signa (Easy) etc, it will show them correctly but when you click to buy it doesn't give anything.

This is so strange. When you have it like this, are you and your players getting a Heli Signal when they buy it but the images are just of a regular supply signal? 

Then when you change it to Heli Signal (Easy) it shows as the correct item but they get nothing?

I do know that because there isn't such an item as a Heli Signal (Easy), is why they get nothing.

My thoughts would be that if you are getting the signals with this config, then the issue with the images lie with the fact that codefling is not an image hosting site perhaps? When I go to that codefling image link it's a big white box with the signal in the middle. It may be better to direct that link to the steam workshop item like https://steamcommunity.com/sharedfiles/filedetails/?id=2920175997 etc.

10 minutes ago, ChristopherS said:

This is so strange. When you have it like this, are you and your players getting a Heli Signal when they buy it but the images are just of a regular supply signal? 

Then when you change it to Heli Signal (Easy) it shows as the correct item but they get nothing?

I do know that because there isn't such an item as a Heli Signal (Easy), is why they get nothing.

My thoughts would be that if you are getting the signals with this config, then the issue with the images lie with the fact that codefling is not an image hosting site perhaps? When I go to that codefling image link it's a big white box with the signal in the middle. It may be better to direct that link to the steam workshop item like https://steamcommunity.com/sharedfiles/filedetails/?id=2920175997 etc.

No, reverse of what you said.  When I have it in the item config under supply.signal it shows only regular signals, no display name, all the same reg supply signal image, gives only reg supply signals.

When I have it under Heli Signal Easy, Med, Hard, Elite, it shows the skinned images, proper price, items accordingly but doesn't give any items at all.

21 minutes ago, SuperKitten said:

No, reverse of what you said.  When I have it in the item config under supply.signal it shows only regular signals, no display name, all the same reg supply signal image, gives only reg supply signals.

When I have it under Heli Signal Easy, Med, Hard, Elite, it shows the skinned images, proper price, items accordingly but doesn't give any items at all.

 

Is there a data file that comes with your shop plugin? I have a plugin by someone called David "craft anything". You can craft things in-game but if the data file isn't completed too then it doesn't work in-game.

EDIT: You said in an earlier comment that you're trying to get this to work on your Shop UI plugin. Is the name of that plugin actually Shop UI by David?

It's the chat commands.  The description says they can be used in chat and console.  They work in chat, they do not work in console, so my configs don't recognize the command.  I need a working console command for the buy.

19 minutes ago, SuperKitten said:

It's the chat commands.  The description says they can be used in chat and console.  They work in chat, they do not work in console, so my configs don't recognize the command.  I need a working console command for the buy.

I've just ran this command from my console and it works fine for me.



EDIT:
I don't know your plugin or how it is supposed to work but maybe something like this could work for you:
 

"Heli Supply (Easy)": {
	"DisplayName": "Heli Supply (Easy)"
	"Image": "https://steamcommunity.com/sharedfiles/filedetails/?id=2920175997"
	"Message": "Here's an Easy Heli Signal"
	"Command": "hsgive Easy {steamid}"
	"BuyPrice": 500
	"Currency": "rp"
}

13 minutes ago, ChristopherS said:

"Command": "hsgive Easy {steamid}"

{steamid} is what I needed all along!  Dude, you're a life-saver.  Thanks for spending your time working thru it with me.  It's all gravy now.

1 minute ago, SuperKitten said:

{steamid} is what I needed all along!  Dude, you're a life-saver.  Thanks for spending your time working thru it with me.  It's all gravy now.

You're welcome! Sorry it took so long, but I'm happy to hear you've managed to get it working!

23 hours ago, SuperKitten said:

{steamid} is what I needed all along!  Dude, you're a life-saver.  Thanks for spending your time working thru it with me.  It's all gravy now.

Did you make it work in the end? I have been offline for a few days so haven't been able to reply. You aren't following the instructions on the Shop UI documentation to add the items correctly We use the Shop UI plugin, and I see you were confused on how to set it up in the config and data file for the Shop plugin.

You said you wanted to use the command, but the config/data part you posted was for giving the item, not issuing the command.

For selling items in a shop, I always recommend specifying the item, NOT using the console command.

To set up items in Shop UI, you have to first specify the items in the items.json file in the data directory. It should look something like this for the default Heli profiles:

  "supply.signal{1}": {
    "DisplayName": "Heli Signal (Regular)",
    "Skin": 2920175997,
    "Image": "https://path-to-image/easyHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 2000,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{2}": {
    "DisplayName": "Heli Signal (Medium)",
    "Skin": 2920176079,
    "Image": "https://path-to-image/medHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3000,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{3}": {
    "DisplayName": "Heli Signal (Hard)",
    "Skin": 2920176050,
    "Image": "https://path-to-image/hardHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3500,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{4}": {
    "DisplayName": "Heli Signal (Elite)",
    "Skin": 2920176024,
    "Image": "https://path-to-image/eliteHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3500,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },

Notice how each item has to have a unique name. So because you kept using the same item shortname ("supply.signal") it was breaking the shop plugin and only giving vanilla supply signals. You have to number them in curly brackets as above, like supply.signal{1}, supply.signal{2} etc.

Then in the categories.json file you need to add the Heli Signals, here is an example of the heli signals items to be sold in their own category:

  "Heli_Signals": {
    "Image": "https://i.imgur.com/w2cI90o.png",
    "Permission": null,
    "Sale": 0,
    "Items": [
      "supply.signal{1}",
      "supply.signal{2}",
      "supply.signal{3}",
      "supply.signal{4}"
    ]
  },

Again, I recommend using the above method, issuing the items, rather than using the console command.

4 minutes ago, ZEODE said:

Did you make it work in the end? I have been offline for a few days so haven't been able to reply. You aren't following the instructions on the Shop UI documentation to add the items correctly We use the Shop UI plugin, and I see you were confused on how to set it up in the config and data file for the Shop plugin.

You said you wanted to use the command, but the config/data part you posted was for giving the item, not issuing the command.

 

For selling items in a shop, I always recommend specifying the item, NOT using the console command.

To set up items in Shop UI, you have to first specify the items in the items.json file in the data directory. It should look something like this for the default Heli profiles:

  "supply.signal{1}": {
    "DisplayName": "Heli Signal (Regular)",
    "Skin": 2920175997,
    "Image": "https://path-to-image/easyHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 2000,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{2}": {
    "DisplayName": "Heli Signal (Medium)",
    "Skin": 2920176079,
    "Image": "https://path-to-image/medHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3000,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{3}": {
    "DisplayName": "Heli Signal (Hard)",
    "Skin": 2920176050,
    "Image": "https://path-to-image/hardHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3500,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },
  "supply.signal{4}": {
    "DisplayName": "Heli Signal (Elite)",
    "Skin": 2920176024,
    "Image": "https://path-to-image/eliteHeli.png",
    "DefaultAmount": 1,
    "BlockAmountChange": false,
    "BuyPrice": 3500,
    "SellPrice": 0,
    "Currency": "rp",
    "ShowDisplayName": true
  },

Notice how each item has to have a unique name. So because you kept using the same item shortname ("supply.signal") it was breaking the shop plugin and only giving vanilla supply signals. You have to number them in curly brackets as above, like supply.signal{1}, supply.signal{2} etc.

Then in the categories.json file you need to add the Heli Signals, here is an example of the heli signals items to be sold in their own category:

  "Heli_Signals": {
    "Image": "https://i.imgur.com/w2cI90o.png",
    "Permission": null,
    "Sale": 0,
    "Items": [
      "supply.signal{1}",
      "supply.signal{2}",
      "supply.signal{3}",
      "supply.signal{4}"
    ]
  },

Again, I recommend using the above method, issuing the items, rather than using the console command.

I got it working.  I did follow your description page instructions, but my issue from the start was your instructions say to use hsgive <Profile ShortName> <Steam64ID> <Amount>.  This is not the correct command.  It should be hsgive <Profile ShortName> {steamid}.  The "Steam64ID" is not valid any longer.

27 minutes ago, SuperKitten said:

I got it working.  I did follow your description page instructions, but my issue from the start was your instructions say to use hsgive <Profile ShortName> <Steam64ID> <Amount>.  This is not the correct command.  It should be hsgive <Profile ShortName> {steamid}.  The "Steam64ID" is not valid any longer.

My instructions are correct for the command (I wrote the plugin, I know this ). It tells people the format to use in their command, i.e: hsgive "profile name" "Steam64ID" "amount"

That is correct, but when using in a plugin then yes, you will need to follow the Shop plugins instructions for issuing commands, {steamid} is just a placeholder used by your shop plugin for the Steam64ID of the player using the shop and making a purchase.

Anyhow, I still recommend you add the items to the shop instead of using the command.

i can change the icon

6 hours ago, maskovaney said:

i can change the icon

Huh?

Where do I change the default plugin icon?

6 hours ago, maskovaney said:

Where do I change the default plugin icon?

Oh, you don’t. I could maybe add it on a future update though.

How do we change the Heli Minimum height? Sometimes it gets stuck on the water and just stays there and anyone can kill it easy because its flying so low so often.

2 hours ago, SlayersRust said:

How do we change the Heli Minimum height? Sometimes it gets stuck on the water and just stays there and anyone can kill it easy because its flying so low so often.

Hi, the heli has been acting weird and going under water since a couple of Rust updates ago. It has been doing it even on Vanilla official servers. This is not controlled by my plugin so I cannot do anything about it. There was also a bug which made it hover stationary just above the water, but that is supposed to be patched by Facepunch now.

But to begin with you can set the height at which the helicopter will arrive at the target, but after that it uses default Rust behaviour.

"Height of heli when it arrives at called location": 20.0,

This and Bradley Drops are causing a ton of lag on my server  had to remove them

10 hours ago, RickJamesBitch said:

This and Bradley Drops are causing a ton of lag on my server  had to remove them

Many users of both plugins without any lag issues. Why automatically assume it’s these plugins causing the issue? If there is an issue you could open a support thread and we can investigate any potential for a conflict which might be causing your issue.

I can assure you if these plugins were the cause of lag there would be many people reporting it, but it’s just you.

19 hours ago, ZEODE said:

Many users of both plugins without any lag issues. Why automatically assume it’s these plugins causing the issue? If there is an issue you could open a support thread and we can investigate any potential for a conflict which might be causing your issue.

I can assure you if these plugins were the cause of lag there would be many people reporting it, but it’s just you.

I spent 12 hours going piece by piece addon by addon to figure it out @ZEODE and I can assure you that both of these plugins have huge issues with  excessive time calling hooks - I've done all the proper performance monitoring and having both of these active, cause massing lag spikes - I took videos and everything to share but then seeing your comment saying its just me, ok then, don't worry about me, I'll figure it out but I would really love if you spent some time optimizing your plugins to reduce the time it takes them to call the hooks in the future... But I doubt you will now seeing your response.

Performance Monitoring Results (if you are familiar with the plugin..):

You'll see two of your plugins are the the top offenders for excessive on call hook time on my server. I correlated the issues myself, but I guess you can figure it out for the next person who buys your plugin and complains about lag.  I thought you would want to know but your response tells me everything I need to know!

Thanks for your time. Have a good day!