Bag of Holding 1.10.6

1 hour ago, BlackLightning said:

I could potentially implement it, but it adds some complexity because a backpack can change hands, so the rules for a given backpack need to change as the backpack moves around. It creates some nuanced situations for users, like if the backpack is on the ground and has a lot of bags in it, one player (with permission) can pick it up, but another player (without permission) cannot, and the plugin needs to explain to the user what the issue is.

There's a similar problem with limiting bags inside of other bags (because the parent bag can change hands), which is why there aren't permissions for those limits. It is probably easier to address for backpacks as they can only hold items while equipped or on the ground, so I can look more into it if it's important to you.

It's all good. I was wondering why it wasn't like that. Thats a good reason. 

Hey ... Plugin is not compiling ...
Error while compiling BagOfHolding: 'BagOfHolding.BaseItemModUnwrapReplacer.ModInit()': no suitable method found to override | Line: 8330, Pos: 34

23 minutes ago, copcopekcro said:

Hey ... Plugin is not compiling ...
Error while compiling BagOfHolding: 'BagOfHolding.BaseItemModUnwrapReplacer.ModInit()': no suitable method found to override | Line: 8330, Pos: 34

Thanks for reporting this. Unfortunately, I was not able to anticipate the Rust hot fix that caused this and I am not able to get home for probably 6-8 hours so you will have to wait. This means bags will revert to standard halloween loot bags, leading to the contents being lost when players attempts to open them. For now, warn your players to stash their bags somewhere safe and do not attempt to open them.

7 minutes ago, BlackLightning said:

Thanks for reporting this. Unfortunately, I was not able to anticipate the Rust hot fix that caused this and I am not able to get home for probably 6-8 hours so you will have to wait. This means bags will revert to standard halloween loot bags, leading to the contents being lost when players attempts to open them. For now, warn your players to stash their bags somewhere safe and do not attempt to open them.

well yea i found that on hard way ... now all have m2  
No problem ... I removed plugin until fix  

@BlackLightning Is todays update safe to install prior to wipe?

The bags in the crates are not able to be looted.  Also, a player died and when he went to retrieve his loot, he couldn't retrieve his bag.  I went into Silo and can confirm.  I cleared the loot and reloaded it and it still did the same thing.  Still testing this issue.  

U P D A T E : 
Found the problem.  Monument Lock (Codefling Plugin) was preventing anyone from looting this bag from anywhere on the server, even their own corpse.  After unloading the plugin and reloading BoH, all is good.

@Blacklighting, I did a Support Ticket but it won't allow me to close it.

F I N A L   U P D A T E : 

Since update 1.10.6, my Monument Lock Plugin is now working as intended.  Thank you for the update
@BlackLightning

Does anyone know how to limit non-empty bags in Main to 5, but when those 5 are in a Bag of Holding, all other bags are locked?  I could have sworn this is how it was prior to Wipe & the last update. 

It used to be that the non-empty bags within the bag of holding (my limit is 5) would count towards the total count of bags.  But, now after the Bag of holding has 5 bags that are non-empty in the Main Inventory Compartment, you add loot to more category bags that are outside the BoH, but are still in the Main Inventory Compartment.  I don't remember this being "a thing" before.

 

 "Player bag limits": {

    "Default limits": {

      "Max total bags": 5,

      "Max bags by category name": {}

Any suggestions would help, 

Thanks

1 hour ago, Papa Bear said:

Does anyone know how to limit non-empty bags in Main to 5, but when those 5 are in a Bag of Holding, all other bags are locked?  I could have sworn this is how it was prior to Wipe & the last update. 

It used to be that the non-empty bags within the bag of holding (my limit is 5) would count towards the total count of bags.  But, now after the Bag of holding has 5 bags that are non-empty in the Main Inventory Compartment, you add loot to more category bags that are outside the BoH, but are still in the Main Inventory Compartment.  I don't remember this being "a thing" before.

Bag limits have always applied just to the bag's parent container. They never factored in bags inside of other bags.

The only exceptions are:

1. Player inventory containers (main, belt, wear) which share a limit despite being technically three separate containers

2. Backpacks plugin on uMod which shares limits across pages despite each page technically being a separate container

The main reason it has always worked this way is for simplicity, as some tricky situations can occur otherwise. For example, you might normally be able to pick up a Bag of Holding bag with contents in it, but because it has additional non-empty bags inside it, you are not allowed to pick it up as doing so would exceed your overall limit. The plugin would have to clearly communicate to players what the problem is so that the player can rearrange bags or contents to overcome it. For similar reasons, bag limits inside of bags are also not configurable according to permissions.

I understand this isn't ideal because it means you either end up giving players excess capacity (they can have bags both inside and outside the Bag of Holding bag) or less choice (they can only have one bag in the inventory, and they finally break through the limitation when they get a Bag of Holding bag). One way you could try to ease players through the transition would be to have different tiers of Bag of Holding bags, which allows progressively more bags inside of them, allowing players to progress from 1 outer bag to 1 outer bag with 1 inner bag, then 2 inner bags, and so on. However, that is still an opinionated progression as you wouldn't allow multiple bags directly inside the main inventory ever.

To mitigate the above concern of allowing too much capacity once a player acquires a Bag of Holding bag, I could potentially make an update that allows you to configure how many bags a specific bag profile counts as, so you could make a Bag of Holding bag count as 5 bags for example.