Heli Signals 1.2.23

4 hours ago, ChristopherS said:

I'm getting some errors using the latest version of this plugin (from today).

I'm not sure what this means, but it's in my console over and over.
 

Failed to call hook 'OnEntityKill' on plugin 'HeliSignals v1.1.11' (NullReferenceException: Object reference not set to an instance of an object.)
  at Oxide.Plugins.HeliSignals.OnEntityKill (PatrolHelicopter heli) [0x00016] in <7da78b90dbde4e6b8e88ca5592185371>:0 
  at Oxide.Plugins.HeliSignals.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x005c2] in <7da78b90dbde4e6b8e88ca5592185371>:0 
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <4a59899debc1481c9a833bf029c30d16>:0 
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <2de770dd80a948ff8a36f27ac5d3d58e>:0 
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <2de770dd80a948ff8a36f27ac5d3d58e>:0 

EDIT: I don't know how accurate this is because I wasn't personally online (I trust them though). A player told me that they died to an invisible and silent helicopter. I was able to verify that they did in-fact die to the patrol helicopter, I have no logs of anyone throwing a signal and he told me he didn't. In the console at the moment of his death, this above error showed over and over.

I've attached an image of my console, but if this is 1 page, there are 2 more pages of this error above & below his death.

Thanks for the detailed report. This is the wrong place for support issues, please open a support thread in the proper place and I will gladly help you. Then I can keep proper track of progress and keep the discussion pages clear of support, thanks.

On 8/28/2023 at 4:18 AM, RickJamesBitch said:

I spent 12 hours going piece by piece addon by addon to figure it out @ZEODE and I can assure you that both of these plugins have huge issues with  excessive time calling hooks - I've done all the proper performance monitoring and having both of these active, cause massing lag spikes - I took videos and everything to share but then seeing your comment saying its just me, ok then, don't worry about me, I'll figure it out but I would really love if you spent some time optimizing your plugins to reduce the time it takes them to call the hooks in the future... But I doubt you will now seeing your response.

Performance Monitoring Results (if you are familiar with the plugin..):

You'll see two of your plugins are the the top offenders for excessive on call hook time on my server. I correlated the issues myself, but I guess you can figure it out for the next person who buys your plugin and complains about lag.  I thought you would want to know but your response tells me everything I need to know!

Thanks for your time. Have a good day!

Firstly, your initial post was just this: 

Quote

This and Bradley Drops are causing a ton of lag on my server  had to remove them

Which I think most people would agree is neither helpful or informative in any way. To just write a comment like that with no explanation or context was not helpful. What response would you expect after a comment like that?

Secondly, hook time and "performance monitoring" is relative and dependant on many factors, not quite what you make it out to be. You say my plugins are

Quote

the top offenders for excessive on call hook time on my server.

and have

Quote

huge issues with  excessive time calling hooks

But that plugin isn't saying the hook time is excessive, its just showing you the hook times in descending order. To simply assume then that my plugins have "huge issues with exessive time calling hooks" etc shows you don't really understand what is going on. Now to put it into context, there are many other plugins out there, particularly any with anything AI related or stat collecting that also have higher hook times. But just because hook times are longer for a plugin doesn't necessarily mean there is an issue, it just means they are doing more stuff. Unless you are seeing lots of "GARBAGE COLLECT" warnings in the console, which I know you aren't for my plugins, then it is not really indicative of a problem.

To make a more informed assessment, I would need more information, which you didn't provide. For example, server hardware spec, how long was the server and/or those plugins running to accumulate that hook time. Around 40 seconds actually isn't that much, depending on circumstances. Now, back to my initial reply of people not reporting such hook times, they aren't. Many people use these without issues. We also use both these plugins on our servers, each server is restarted daily and after 24 hours of running on a fairly busy PVE server with many people who love taking helis, the hook times are rarely above 30 seconds over 24 hours for Heli Signals and Bradley Drops (this is on a highly modified, 170+ plugins PvE server. Much, much higher hook times are on Raidable Bases, SkillTree, and a host of other event plugins that we run.

My initial reply may have been a bit abrupt and thoughtless, but then so was your initial comment, and it is sometimes frustrating to read comments like yours from people who don't have a clue of what's gone into the writing of the plugin, how it works, or how it performs and why. But I can assure you my plugins and my code in general is written to be as efficient as I can make it. But for some reason a couple of people get longer hook times than others using the same plugin, in the same way. Now this could be due to a number of reasons, one might be another plugin making calls to my plugin. For example AlphaLoot calling to my plugin to see if it can populate heli_crates, bradley_crates, etc. Or any other plugin checking to see if a supply drop belongs to their plugin or mine, etc etc. Excessive calls to my plugin will add hook time.

I can see why a lack of understanding might lead you to draw conclusions that my plugins are "the culprit" when trying to troubleshoot performance, but without understanding all the various factors you should be cautious of pointing fingers, instead maybe approach it in a different way and we could have troubleshooted the issue to see if we could find any reasons why you are having these issues where others are not. However, as I mentioned before, those hook times aren't horrendous, but then, I don't know how long the plugins had been running to get those amounts.

Lastly, a couple of updates ago I had already given the plugin a overhaul and code clean up, which I do frequently as my coding improves. The only other person who has reported an issue with hook times reports hook times to have halved (after troubleshooting together on Discord). But again, these hook times are not the norm, so could indicate another issue with your server or some sort of conflict.

Edit: After reading your past comments on other devs plugins, I can see your attitude is no different to what it was here. Speaks volumes.

Everything was fine before the update! After the update, many errors occur as soon as the helicopter flies into water (I have the helicopter speed set to high)

I don’t even have time to look with my eyes, and the video quality is poor

1 hour ago, ReSmit said:

Everything was fine before the update! After the update, many errors occur as soon as the helicopter flies into water (I have the helicopter speed set to high)

I don’t even have time to look with my eyes, and the video quality is poor

 

 

Please open a support thread with the error messages and more information, thanks.

hello all. Can someone help me to fix this¿
09/13 19:40:13 | Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: StackModifier - False (Boolean), HeliSignals (True (Boolean))

6 hours ago, BadLandPVE said:

hello all. Can someone help me to fix this¿
09/13 19:40:13 | Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: StackModifier - False (Boolean), HeliSignals (True (Boolean))

According to the Oxide coding rules, hooks of type Object should return either null or true. Hooks of type Bool can return either true, false or null. Therefore StackModifier is incorrect and the dev should fix that. Or you can change the return value within the "CanCombineDroppedItem " hook in StackModifier so that anytime it returns false, you change it to return true.

hi just a quesrtion cant find it in cfg.

would it be possible to change the lock percentage?

would it be possible to lock at maybe 51%?

12 hours ago, m3dus4 said:

hi just a quesrtion cant find it in cfg.

would it be possible to change the lock percentage?

would it be possible to lock at maybe 51%?

I don't know what you mean. Lock what?

lock heli and crates.

if some call a heli he can loose it if dmg is under 50 % maybe.

in config i can choose a timer how long crates can be locked. but maybe its interesstingto loosethe own called heli if dmg is under 50% maybe ^^

4 hours ago, m3dus4 said:

lock heli and crates.

if some call a heli he can loose it if dmg is under 50 % maybe.

in config i can choose a timer how long crates can be locked. but maybe its interesstingto loosethe own called heli if dmg is under 50% maybe ^^

The plugin Loot Defender does that, but currently Loot Defender will ignore all Heli Signals helis. I will add a config option to allow Loot Defender to lock called helis, this will achieve what you want by using Loot Defender. This will be on the next update.

thx also for bradley drops? ^^

54 minutes ago, m3dus4 said:

thx also for bradley drops? ^^

Yes, but on second look, I think a patch will be needed by nivex to Loot Defender. I'm looking into it now.

how do I add this to ServerRewards shop ? as an item or command, what do I need to do this ?

On 11/3/2023 at 8:04 AM, boofhead187 said:

how do I add this to ServerRewards shop ? as an item or command, what do I need to do this ?

Please refer to the instructions on the ServerRewards documentation on adding items to the SR shop. All you need in addition for Heli Signals is the custom Skin ID which is available on the documentation page for this plugin. I always recommend adding the item to reward shops, not the command. Keep the command for using in chat only.

How do I buy Wave Profiles?

When I tried to buy a Wave Profile, I got a message that "Signal type "wave_normal" not recognised".

Of course I had Wave permissions.

hello. i been testing last update. looks awsome. THANKS.
1 thing, when u buy a normal and hard wave, both signals uses the same name in the inventory,  its a plugin or personal problem?

and this is wrong on plugin description 
 

Multi Heli (Elite) : 3083234647

Multi Heli (Expert) : 3083234647     3099124338

Multi Heli (Nightmare) : 3083234647      3099124426

On 11/28/2023 at 12:09 PM, Roine said:

How do I buy Wave Profiles?

When I tried to buy a Wave Profile, I got a message that "Signal type "wave_normal" not recognised".

Of course I had Wave permissions.

This is bugged, I will fix when I am not working and release a update. This does not affect signals sold in shops.

13 hours ago, BadLandPVE said:

hello. i been testing last update. looks awsome. THANKS.
1 thing, when u buy a normal and hard wave, both signals uses the same name in the inventory,  its a plugin or personal problem?

and this is wrong on plugin description 
 

Multi Heli (Elite) : 3083234647

Multi Heli (Expert) : 3083234647     3099124338

Multi Heli (Nightmare) : 3083234647      3099124426

Glad you like it. What name are the wave signals getting for you? I will test this when I can get to a PC, but this shouldn't happen. The name for the signal is taken from the config.

The skin IDs have been updated on the plugin page to fix the typo, thanks.

8 hours ago, ZEODE said:

This is bugged, I will fix when I am not working and release a update. This does not affect signals sold in shops.

Glad you like it. What name are the wave signals getting for you? I will test this when I can get to a PC, but this shouldn't happen. The name for the signal is taken from the config.

The skin IDs have been updated on the plugin page to fix the typo, thanks.

i fixed wave problem. was a mistake on my cfg. sorry for that.

Hello DEV ! For some reason i only get to /hs buy easy-elite and /hsbuy multi easy-elite. What do i need to do to get the wave working? I ve se the command to true:

Profile shortname (for use in permission and give command)": "wave_normal",
        "Enable purchasing using custom currency via the buy command": true,

Do i need tro manualy create those? and i can create any profiles i want ? Orcan you explain what limitations and what i can do with this plugin since i find it very usefull but i need to know how versatile it is. What other commands i m missing?

3 hours ago, Mr.Wild said:

Hello DEV ! For some reason i only get to /hs buy easy-elite and /hsbuy multi easy-elite. What do i need to do to get the wave working? I ve se the command to true:

Profile shortname (for use in permission and give command)": "wave_normal",
        "Enable purchasing using custom currency via the buy command": true,

Do i need tro manualy create those? and i can create any profiles i want ? Orcan you explain what limitations and what i can do with this plugin since i find it very usefull but i need to know how versatile it is. What other commands i m missing?

Check a couple posts above you.

1 hour ago, ReSmit said:

Read above

there is no information on how to start a wave. An error occurs, I think all players do the same, I even created a default cfg

19 hours ago, ReSmit said:

there is no information on how to start a wave. An error occurs, I think all players do the same, I even created a default cfg

You sell/give a Wave Signal the same way you do the normal signals. Either with the command, or if giving in shops/loot by using the Wave signal skinID instead for the supply signal.

11 hours ago, ReSmit said:

there is no information on how to start a wave. An error occurs, I think all players do the same, I even created a default cfg

try this

/hsgive wave_normal ReSmit 1