Quality Crafting 3.0.3

I like it very much. Can he set up damage reduction for clothes in the server with truepve

very unusual to see a plugin like this for FREE - let me just say thanks.

getting a lot of these when im crafting 

This happens when it has special stats added to the item and i click on it in my Inv 

It does not display the stats like in your screenshots

4 hours ago, TomHud said:

getting a lot of these when im crafting 

This happens when it has special stats added to the item and i click on it in my Inv 

It does not display the stats like in your screenshots

That is very strange I have not seen this... Do you have any other plugins that may be related to items or the player inventory?

Hi, I hate to be a bother.  I keep getting this error code when items are crafted.  Not sure how to fix it as I'm terrible with this stuff.

Thank you in advance.


I was also curious how to change this icon, the workbench one I put in, to it's normal look, if possible.

Thanks again.

Hi, sorry you're receiving that console spam. Unfortunately I'm not sure why that is happening for you, I have not seen this problem in any plugins I've written. I'm no server admin, so I'm not super familiar with what might be going on. But from my experience those do not look like error messages, those look more like info logs that are printing to your console for some reason. I assume everything else is working besides that console spam?

As for the icon, I do have a solution for you! However, you will have to edit two small sections of the code - don't worry I can walk you through it. First of all, make a backup of the plugin incase you make a mistake! Next open up the QualityCrafting.cs file in any text editor, then search the file for the phrase "qc.button.skills" (without the quotes) you should get three results. One of them (probably the first one) you should ignore, the other two will look like this:

Line 1255 (subject to change)

            container.Add(new CuiElement
            {
                Parent = $"{HELP_MENU}.return",
                Components = {
                    new CuiImageComponent
                    {
                        Png = ImageLibrary?.Call<string>("GetImage", $"qc.button.skills"),
                        Color = config.Colors.Text
                    },
                    new CuiRectTransformComponent
                    {
                        AnchorMin = "0 0",
                        AnchorMax = "1 1",
                        OffsetMin = $"{3} {3}",
                        OffsetMax = $"{-3} {-3}"
                    }
                }
            });

Line 3594 (subject to change)
 

            container.Add(new CuiElement
            {
                Name = SKILLS_MENU_BUTTON,
                Parent = "Overlay",
                Components =
                {
                    new CuiImageComponent
                    {
                        Png = ImageLibrary?.Call<string>("GetImage", "qc.button.skills"),
                        Color = config.Colors.HUDButtonUntoggled
                    },
                    new CuiRectTransformComponent
                    {
                        AnchorMin = "0 0",
                        AnchorMax = "0 0",
                        OffsetMin = $"{startX} {startY}",
                        OffsetMax = $"{startX+size} {startY+size}"
                    }
                }
            });

Now in both sections of the code, see where it says "CuiImageComponent"? What you need to do, in both places, is update that from "CuiImageComponent" to "CuiRawImageComponent". Then remember to save the plugin and see if it loads. If your server was already running you may need to reload your ui (can log out and back in should do it). It should make it so it uses the colors of the original image instead of being overlayed with white. Hope it works! Let me know if you have any questions. Also remember this post so you can refer back to it when I update the plugin!

  Beautiful THANK YOU!!!
Not really sure what would be causing the spam.  But seems to be causing no issue other than the console spam.
Really appreciate the quick response. 
Great work.

3 minutes ago, Balloonicron said:

  Beautiful THANK YOU!!!
Not really sure what would be causing the spam.  But seems to be causing no issue other than the console spam.
Really appreciate the quick response. 
Great work.

Looks great, glad it worked!

kk i wiped server (fresh wipe) only plugins i have installed are what are listed below

Im finding this plugin does not work

1 - it does not show green stats when i go into inventory page when i have a tool or weapon with stats added 

Yours has green stats in your plugin pictures

2 - I have a icepick which gives me 110% gathering but when i farm say a sulphur node i still get 300 sulphur from it which is Default for vanilla server

3 - i gave myself xp in the toolcrafting category and it says i have 500% craft speed but stuff are still crafting at the normal speed.

Getting this console spammed.

Failed to call hook 'CmdMenuShow' on plugin 'QualityCrafting v2.0.1' (NullReferenceException: Object reference not set to an instance of an object)

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetXP (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetLevel (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CreateContentFooter (Oxide.Game.Rust.Cui.CuiElementContainer container, BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, Oxide.Plugins.QualityCrafting+PlayerSkillSheet skills, System.Int32 padding, System.Int32 page, System.Boolean maxed) [0x0001b] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowCategoryPage (BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, System.Int32 page) [0x002e0] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowSkillsMenu (BasePlayer basePlayer, System.Boolean autoHide) [0x0067c] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CmdMenuShow (Oxide.Core.Libraries.Covalence.IPlayer player, System.String command, System.String[] args) [0x00030] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x01ee9] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <09575a60985045248bcb43b20faeeb99>:0

at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <bae5f1223fce49c493b01571c99dce02>:0

at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <bae5f1223fce49c493b01571c99dce02>:0

3 hours ago, TomHud said:

kk i wiped server (fresh wipe) only plugins i have installed are what are listed below

Im finding this plugin does not work

 

1 - it does not show green stats when i go into inventory page when i have a tool or weapon with stats added 

Yours has green stats in your plugin pictures

 

2 - I have a icepick which gives me 110% gathering but when i farm say a sulphur node i still get 300 sulphur from it which is Default for vanilla server

 

3 - i gave myself xp in the toolcrafting category and it says i have 500% craft speed but stuff are still crafting at the normal speed.

 

I'm sorry you're experiencing these issues. I'm going to look into this, but first I want to clarify a few things, just to make sure its not a misunderstanding.

The green stats shown in the picture do not appear automatically when you open the inventory. In order for those to show you must click the "Quality" toggle button, which by default looks like a star, the green stat modifiers also only appear if you are wearing higher quality clothing, they will not appear at all if you are not.

I notice in your screenshots the images appear to be bugged, is this because you configured them to use different images? Or is this an issue as well? 

As for the other issues, are you seeing any errors in the console? Others have apparently reported some issues, it might be related to those. If so, I'm going to look into why this is occurring, any information on how to reproduce it (what you crafted, how many players on sever, ect.) would be very helpful.

43 minutes ago, CDNCasanova said:

Getting this console spammed.

Failed to call hook 'CmdMenuShow' on plugin 'QualityCrafting v2.0.1' (NullReferenceException: Object reference not set to an instance of an object)

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetXP (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetLevel (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CreateContentFooter (Oxide.Game.Rust.Cui.CuiElementContainer container, BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, Oxide.Plugins.QualityCrafting+PlayerSkillSheet skills, System.Int32 padding, System.Int32 page, System.Boolean maxed) [0x0001b] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowCategoryPage (BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, System.Int32 page) [0x002e0] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowSkillsMenu (BasePlayer basePlayer, System.Boolean autoHide) [0x0067c] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CmdMenuShow (Oxide.Core.Libraries.Covalence.IPlayer player, System.String command, System.String[] args) [0x00030] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x01ee9] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <09575a60985045248bcb43b20faeeb99>:0

at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <bae5f1223fce49c493b01571c99dce02>:0

at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <bae5f1223fce49c493b01571c99dce02>:0

Would you be able to provide any information on when this was happening? It seems there was a problem that occurred when someone attempted to open the skills menu. If so, is this a recurring issue? Can you provide what level they were when they got this error, and does the menu still show? Thank you for reporting this!

1 hour ago, Mr01sam said:

I'm sorry you're experiencing these issues. I'm going to look into this, but first I want to clarify a few things, just to make sure its not a misunderstanding.

The green stats shown in the picture do not appear automatically when you open the inventory. In order for those to show you must click the "Quality" toggle button, which by default looks like a star, the green stat modifiers also only appear if you are wearing higher quality clothing, they will not appear at all if you are not.

I notice in your screenshots the images appear to be bugged, is this because you configured them to use different images? Or is this an issue as well? 

As for the other issues, are you seeing any errors in the console? Others have apparently reported some issues, it might be related to those. If so, I'm going to look into why this is occurring, any information on how to reproduce it (what you crafted, how many players on sever, ect.) would be very helpful.

i have only tried it on a ak47 and 2 tools not used it on clothing

Regardless though i have my tools with 110% gather rate (server is vanilla) yet im still getting 300 sulphur from a node which cant be correct if im supposed to get 10% more

As for the pics its just image library playing up - they were fine the first time i installed it so so its all good on this 

Thanks

41 minutes ago, TomHud said:

i have only tried it on a ak47 and 2 tools not used it on clothing

Regardless though i have my tools with 110% gather rate (server is vanilla) yet im still getting 300 sulphur from a node which cant be correct if im supposed to get 10% more

As for the pics its just image library playing up - they were fine the first time i installed it so so its all good on this 

 

Thanks

I think there is a misunderstanding about the tools, currently, a higher level tool does NOT give you extra materials in total. It simply, makes the amount you get per hit greater, but the total amount a node contains is still determined by the server. For example a level 0 hatchet may give you 10 wood per hit and take 30 hits to take down a tree (just an example), however a level 5 hatchet will yield 15 a hit and only take roughly 20 hits to finish a node. However, either way you will still only get 300 wood in total, just a higher level tool will get it quicker, last longer, and do more melee damage. Hope that clears it up, sorry for the confusion.

As for the crafting speed, I'm not sure what is going on there, I have just tested the plugin on a fresh server and it is correctly affecting the speed at level 100 for toolcrafting.

3 hours ago, CDNCasanova said:

Getting this console spammed.

Failed to call hook 'CmdMenuShow' on plugin 'QualityCrafting v2.0.1' (NullReferenceException: Object reference not set to an instance of an object)

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetXP (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting+PlayerSkillSheet.GetLevel (Oxide.Plugins.QualityCrafting+SkillCategory category) [0x00000] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CreateContentFooter (Oxide.Game.Rust.Cui.CuiElementContainer container, BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, Oxide.Plugins.QualityCrafting+PlayerSkillSheet skills, System.Int32 padding, System.Int32 page, System.Boolean maxed) [0x0001b] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowCategoryPage (BasePlayer basePlayer, Oxide.Plugins.QualityCrafting+SkillCategory category, System.Int32 page) [0x002e0] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.ShowSkillsMenu (BasePlayer basePlayer, System.Boolean autoHide) [0x0067c] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.CmdMenuShow (Oxide.Core.Libraries.Covalence.IPlayer player, System.String command, System.String[] args) [0x00030] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.QualityCrafting.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x01ee9] in <618827e4cf744ed7a06207d09ecba57b>:0

at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <09575a60985045248bcb43b20faeeb99>:0

at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <bae5f1223fce49c493b01571c99dce02>:0

at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <bae5f1223fce49c493b01571c99dce02>:0

Do you happen to have any of the skill categories disabled? In either case, would you be able to share what your config looks like? Feel free to PM me if you would prefer.

On 11/20/2022 at 2:36 AM, CM1234 said:

I like it very much. Can he set up damage reduction for clothes in the server with truepve

I'd love for this to work well with truepve - I have tested it with that plugin and it seems to work with the clothing resistances... is it not working for you? If not, would you care to share your truepve config with me? Feel free to PM it to me!

9 hours ago, Mr01sam said:

Would you be able to provide any information on when this was happening? It seems there was a problem that occurred when someone attempted to open the skills menu. If so, is this a recurring issue? Can you provide what level they were when they got this error, and does the menu still show? Thank you for reporting this!

Last night, shortly after I downloaded your plugin. They would have been between Lv. 1 and 28 at the time, crafting combat knives, and I believe the GUI was showing and still working.

Hi, I just had a quick question on whether or not you are able to manually set items to have a certain star level for custom loot spawns or something.  It'd be neat to put a 4 star gun in a box somewhere on the map.  Thanks as always.

3 hours ago, Balloonicron said:

Hi, I just had a quick question on whether or not you are able to manually set items to have a certain star level for custom loot spawns or something.  It'd be neat to put a 4 star gun in a box somewhere on the map.  Thanks as always.

It's not a built in feature of the plugin currently, however, there is a command to manually set the quality level of an item. The problem is that it requires you give it a player name so that it knows which inventory to look for the item.

So no theres no way to do that for loot right now, but I could add something like that in the future!

Edit: As an alternative you could use that command I mentioned to offer some kind of "upgrade" system for your players. Give them the opportunity to spend server rewards or something to upgrade an item. Just tossing out ideas, good luck!

1 minute ago, Mr01sam said:

It's not a built in feature of the plugin currently, however, there is a command to manually set the quality level of an item. The problem is that it requires you give it a player name so that it knows which inventory to look for the item.

So no theres no way to do that for loot right now, but I could add something like that in the future!

Sounds good, appreciate the response.  I look forward to the future.

love this plugin, however things reset to default when skinning using skinbox and repair benches. not sure if this is avoidable but would love to see this change in the near future. works great when crafting with skin, although quite often i find it crafting unskinned versions of the items.

also, if i could suggest adding ammo capacity for guns as a possible "side effect" of upgrading

51 minutes ago, tacman1981 said:

love this plugin, however things reset to default when skinning using skinbox and repair benches. not sure if this is avoidable but would love to see this change in the near future. works great when crafting with skin, although quite often i find it crafting unskinned versions of the items.

also, if i could suggest adding ammo capacity for guns as a possible "side effect" of upgrading

Thanks for the feedback!  I'll look into skinbox compatibility and see if I can fix it. Thanks for the suggestions, feel free to leave a review, the feedback helps a ton!

Seems like my players report losing stars on death, is this intentional? Could it be possible to make this not happen when using RestoreUponDeath? Even if its a configurable option.

35 minutes ago, tacman1981 said:

Seems like my players report losing stars on death, is this intentional? Could it be possible to make this not happen when using RestoreUponDeath? Even if its a configurable option.

I'm not sure what you mean by "stars". When they die they should be able to recover their quality items from their corpse just like any other item. They should still have their quality even when the owner dies. Are you not experiencing this, that would definitely not be intentional.

1 hour ago, Mr01sam said:

I'm not sure what you mean by "stars". When they die they should be able to recover their quality items from their corpse just like any other item. They should still have their quality even when the owner dies. Are you not experiencing this, that would definitely not be intentional.

The stars are what shows when its successfully crafts an upgraded item. With RestoreUponDeath it doesnt seem to give those stars back when restoring inventory.