Bag of Holding 1.9.4

1 hour ago, Wolf said:

Hey, I'm fascinated by this plugin and just started to figure it out!!! There is one question, is it possible to limit the influence of the InstancedContainers plugin on the bags otherwise the players create additional space in the bags.

I have purchased the Instanced Containers plugin and reached out to the author to suggest multiple compatibility options. It will require an update to their plugin.

15 hours ago, Wolf said:

Hey, I'm fascinated by this plugin and just started to figure it out!!! There is one question, is it possible to limit the influence of the InstancedContainers plugin on the bags otherwise the players create additional space in the bags.

I haven't heard back from the author of that plugin yet, so for now, here is a simple update you can make to the InstancedContainers.cs plugin file. Look for code like "OnGlobalStorageOpened" and "OnRunePouchOpened", then insert the following code after them. The pattern will become clear when you find those examples.

void OnBagOpened(Item item, BasePlayer player)
{
    CuiHelper.DestroyUi(player, "InstancedStoragePanel");
}

I have a random question for you. I currently use the plugin Rust Rewards and one aspect of this plugin is that players gain reward points which can be used in shops and such on the server. The action of opening and closing the Bag of Holding allows players to gain reward points associated with the Rust Rewards plugin. I asked the plugin designer Steenamaroo about removing the Bag of Holding from gaining reward points and he responded with the following...

"I don't see any info about identifying containers from Bag of Holding, but if the author can provide that info I'd be happy to update for it."

Would you be able to provide this to either myself or Steenamaroo so that this could be accomplished?

Thanks,

Tim

2 hours ago, MNfreakTim said:

I have a random question for you. I currently use the plugin Rust Rewards and one aspect of this plugin is that players gain reward points which can be used in shops and such on the server. The action of opening and closing the Bag of Holding allows players to gain reward points associated with the Rust Rewards plugin. I asked the plugin designer Steenamaroo about removing the Bag of Holding from gaining reward points and he responded with the following...

"I don't see any info about identifying containers from Bag of Holding, but if the author can provide that info I'd be happy to update for it."

Would you be able to provide this to either myself or Steenamaroo so that this could be accomplished?

Bag of Holding has many API methods and hooks, but the documentation I originally wrote for them becomes stripped of all formatting when I try to paste it into this website's editor, and I haven't had the time to manually reformat it all (it's a lot). Steenamaroo has my permission to download the plugin from this website to browse the API/hooks in code, as well as my permission to test the integration on a test server.

There are multiple ways to identify whether a player is looting a bag. The best way depends on the context and which information is available to the other plugin. I'm guessing the issue is happening in the OnEntityLootEnd hook which I see in the Rust Rewards code, but I'm surprised this is an issue in the first place. I imagine that plugins which rewards players for looting should only do so for containers which are clearly loot containers (as identified by the LootContainer class or by prefab). Bag of Holding does not use loot containers, so I'm not sure why this would be an issue in the first place, unless you are also seeing this issue for player deployed containers. I wonder if the Rust Rewards plugin has been incorrectly configured on your server, or if there is a broader issue with that plugin which has gone unreported.

Rather than making other plugins specifically detect bags from this plugin, I suggest they instead detect when the player is looting an item (a container that resides inside an item). This approach can be done only while the player's loot container list (basePlayer.inventory.loot.containers) is populated (i.e., one frame after OnLootEntity is called, and before the player stops looting). If that container list has only one container, and that container has a parentItem, then that means the player is looting an item's container. This approach allows other plugins to be sufficiently generic so as to not rely on specific plugin APIs. Any time plugins can rely on generic approaches rather than plugin APIs, it generally increases compatibility and allows plugins to be swapped out (e.g., you could replace Bag of Holding with another plugin that works similar, or install multiple plugins that work like Bag of Holding).

7 hours ago, MNfreakTim said:

The action of opening and closing the Bag of Holding allows players to gain reward points associated with the Rust Rewards plugin.

Honestly it should just be as easy as setting the reward value for halloween.lootbag.large to 0 in the Rust Rewards config.

 

15 hours ago, Zoreeno said:

Honestly it should just be as easy as setting the reward value for halloween.lootbag.large to 0 in the Rust Rewards config.

 

Ty m8, I added lootbag.large.item to obtain 0 points in the Rust Rewards plugin and it worked.

1 hour ago, MNfreakTim said:

Ty m8, I added lootbag.large.item to obtain 0 points in the Rust Rewards plugin and it worked.

Ah, I misunderstood what was happening. It was the act of clicking the open button (using the OnItemAction hook) that was triggering the reward, not the act of technically opening/looting the bag container. Thanks @Zoreeno for helping out.

If @Steenamaroo wants to provide better out-of-the-box compatibility in the Rust Rewards plugin, my suggestion is to ignore the loot bag item if it has a skin. This approach will also work for several other plugins that use skinned halloween loot bags and presents for special purposes (such as to run arbitrary commands when opened).

I had an interesting error happen with two players who placed the Bag of Holding into their bank. Listed below is the error that I have seen. I also have the json of their bank as well and I believe I identified the issue within the file. But I just wanted to let you know what I found. Once I delete the bag of holding from the bank json for that player the error goes away.

Failed to call hook 'cmdBank' on plugin 'Bank v1.0.52' (NullReferenceException: Object reference not set to an instance of an object) at Item.CanMoveTo (ItemContainer newcontainer, System.Int32 iTargetPos) [0x0000b] in :0 at Item.MoveToContainer (ItemContainer newcontainer, System.Int32 iTargetPos, System.Boolean allowStack, System.Boolean ignoreStackLimit, BasePlayer sourcePlayer) [0x0018a] in :0 at Oxide.Plugins.Bank+BankProfile.PopulateContainer (BasePlayer player, ItemContainer container, System.Collections.Generic.List`1[T] items) [0x00156] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank+BankProfile.PopulateContainer (BasePlayer player, ItemContainer container, System.Collections.Generic.List`1[T] items) [0x000f2] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank+BankProfile.GetContainer (BasePlayer player, System.Int32 slots) [0x00062] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank.OpenBank (BasePlayer player, BaseEntity targArg) [0x0014a] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank.ShowBank (BasePlayer player, BaseEntity target) [0x00269] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank.cmdBank (BasePlayer player, System.String command, System.String[] args) [0x0000c] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.Bank.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00ee6] in <5d3ba011bb624d76937e3ed0a8c3fdb3>:0 at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <09575a60985045248bcb43b20faeeb99>:0 at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in :0 at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in :0

Thanks,

Tim

1 hour ago, MNfreakTim said:

I had an interesting error happen with two players who placed the Bag of Holding into their bank. Listed below is the error that I have seen. I also have the json of their bank as well and I believe I identified the issue within the file. But I just wanted to let you know what I found. Once I delete the bag of holding from the bank json for that player the error goes away.

That appears to happen because Bank is attempting to add items to the bag's inventory, before the bag's inventory has been created. If Bank is updated to create the bag with its skin, rather than set the skin after creating the bag item, this issue will probably resolve.

There are bound to be other issues with Bank. I suggest using Backpacks instead, since it has both keep-on-death and keep-on-wipe functionality that should be more than sufficient for whatever use case for which you are using Bank.

Thank you for such a speedy response. I have added your explanation to my server and told players to stop placing them into their bank and instead use the backpack plugin. I have used both the bank and backpack plugin for ages and can see how with your plugin it might be wise to trim it down to just the backpack plugin as the bags of holding offer the players plenty extra space to make up for it.

Quick follow up question, would the only way for me to fix the bank plugin for them would be to remove the offending bag of holding from their bank json manually? So far that is what I have been doing for the players.

Thanks again,

Tim

4 hours ago, MNfreakTim said:

Quick follow up question, would the only way for me to fix the bank plugin for them would be to remove the offending bag of holding from their bank json manually? So far that is what I have been doing for the players.

Correct. Bank doesn't have any config options to block adding certain items to the bank, nor does it have hooks that would allow other plugins to block items.

i have run into a somewhat interesting issue which made all the bags i had turn into Items & construction bags when each one was different before that happened, i dont know what caused it and using the latest version.

also would it be possible that when a person has specific type bags and the normal one that when they pick something up and have gathermode on for the bags that the specific items bags take priority over the general bag? and only let the general bag take things when the specific bags no longer have space in them?

1 hour ago, Wajeeh Agbariya said:

i have run into a somewhat interesting issue which made all the bags i had turn into Items & construction bags when each one was different before that happened, i dont know what caused it and using the latest version.

also would it be possible that when a person has specific type bags and the normal one that when they pick something up and have gathermode on for the bags that the specific items bags take priority over the general bag? and only let the general bag take things when the specific bags no longer have space in them?

That's the first I've heard of bags unexpectedly changing category. I'm not aware of any reason that could happen. My guess is that another plugin caused it somehow. If that issue repeats, I can take a look at your config and plugin list to see if I have any ideas.

When multiple bags are in gather mode, the priority order is the same as the bag order itself. This allows players full control of the priority by simply rearranging the bags. I could make the plugin designate a different order, but given that the bags are so configurable, as the developer I can't easily decide for you which bags should take priority over others (I can only provide a default order according to the default configuration), so if that were implemented, the order would have to be made configurable by the server owner. I caution against this because using an explicit priority order at the server level would mean individual players no longer have the ability to determine the priority order by rearranging the bags.

Does anyone know offhand if updating the cs file and reloading the plugin wipes the current contents of my player's bags? 

Thanks!

-AQ

1 hour ago, Aqueos said:

Does anyone know offhand if updating the cs file and reloading the plugin wipes the current contents of my player's bags

It doesn't

No it would not and in the extremely rare instance it would it would be noted in the update logs. 

Hello,

I'd like to offer a Kit for new comers on my server. I'd like it to have one of each of the xsmall bags. However, when I use my inventory as the template the bags blow up with stars and drop a gun or something like that. I think this has to do with the default behavior of the halloween bag. Is there a way to achieve a single welcome kit using the free kit mod on Umod where I can have a single kit with 5 (1 of each type bag) for a new user? By type bag I mean "Armor & Clothing" or "Food & Medical" etc.

Thank you

5 hours ago, DeepBlue said:

Hello,

I'd like to offer a Kit for new comers on my server. I'd like it to have one of each of the xsmall bags. However, when I use my inventory as the template the bags blow up with stars and drop a gun or something like that. I think this has to do with the default behavior of the halloween bag. Is there a way to achieve a single welcome kit using the free kit mod on Umod where I can have a single kit with 5 (1 of each type bag) for a new user? By type bag I mean "Armor & Clothing" or "Food & Medical" etc.

Thank you

I just tested with Kits v4.4.0 from uMod and didn't have any problems. I added 4 distinct category bags to my inventory, created a kit from them, dropped the bags, redeemed the kit, and opened the bags successfully.

If the bags are functioning like halloween loot bags, that means Bag of Holding doesn't recognize them for some reason. For example, if the skins currently configured in the plugin do not match the skins of the bags. Is it possible that you changed the bag skin theme after creating the kit? That could certainly cause this. Similarly, if you are using the tactical or leather bags, then made a syntax error in the config, the plugin will load using the default config which corresponds to the fantasy skins, which could also cause this issue.

Have you verified that the bags work when added to your inventory before creating the kit? If so, do the bags only function like halloween loot bags after redeeming the kit?

I am having a problem with my bag not being returned at the end of the day when I join the arena, and I was told there is a setting in the bag, where do I fix it?

1 minute ago, siguu said:

I am having a problem with my bag not being returned at the end of the day when I join the arena, and I was told there is a setting in the bag, where do I fix it?

increase default limits from 0: Container bag limits , Backpack bag limits, Player bag limits

So I switched to this plugin from backpacks and I'm running into an issue where players assume when they join that there is no bags or backpacks on the server because there is no backpack button I guess.

Does anybody know how to somehow remedy this? Just a question I think the plug-in is really cool but I feel like it's deterring players

2 hours ago, Sirphr said:

So I switched to this plugin from backpacks and I'm running into an issue where players assume when they join that there is no bags or backpacks on the server because there is no backpack button I guess.

Does anybody know how to somehow remedy this? Just a question I think the plug-in is really cool but I feel like it's deterring players

You could try mentioning it in the server description, info panel, info/help commands, recurring chat announcements, etc.

SO ran into a bug, when Ammo is placed into the bag and a player reloads the ammo is not used but the reload animation completes.

45 minutes ago, CupsOhJoe said:

SO ran into a bug, when Ammo is placed into the bag and a player reloads the ammo is not used but the reload animation completes.

Do you have the Item Retriever plugin installed? It is a requirement to be able to pull ammo from bags. Without it, I'm aware of an issue where the game client will indicate to the player that they have the ammo, allowing the reload attempt to start, but the server doesn't know where to find the ammo so nothing happens. That isn't technically caused by the plugin, it's due to a mismatch between vanilla client and server side logic.

Plugin Update Request: 

Is it possible to add a feature that enables players with permissions to keep their bags upon death?