Christmas 1.2.0

A player of mine mentioned that when some of the scientists became backpacks on the oil rig, they have no loot. Also, I found that the oil rig scientists seem to have the first spot in their inventory empty. This only happens to the oil rig scientists and seems to only have started since I added this plugin. Could the plugin be affecting the oil rig scientists like this?

See this screenshot to see what I mean: https://ibb.co/Sv075LM

*EDIT* Junk pile scientists seem to suffer from this as well.

I can confirm without this loaded, the scientist loot at these two locations are working fine now.

14 hours ago, BetterDeadThanZed said:

A player of mine mentioned that when some of the scientists became backpacks on the oil rig, they have no loot. Also, I found that the oil rig scientists seem to have the first spot in their inventory empty. This only happens to the oil rig scientists and seems to only have started since I added this plugin. Could the plugin be affecting the oil rig scientists like this?

See this screenshot to see what I mean: https://ibb.co/Sv075LM

*EDIT* Junk pile scientists seem to suffer from this as well.

I will release a fix for this issue in a few days

7 hours ago, The_Kiiiing said:

I will release a fix for this issue in a few days

Before, Christmas I hope! I bought this just for this wipe (we do 2 week wipes).

1 hour ago, BetterDeadThanZed said:

Before, Christmas I hope! I bought this just for this wipe (we do 2 week wipes).

Fixed it

14 hours ago, Mals said:

Getting a wall of these messages over and over:

Calling kill - but already IsDestroyed!? giftbox_loot[0]

Yes, I see that too. Hopefully it's something @The_Kiiiingcan fix easily, but I don't think it affects the server. It's just annoying to see that message all over the console.

7 hours ago, BetterDeadThanZed said:

Yes, I see that too. Hopefully it's something @The_Kiiiingcan fix easily, but I don't think it affects the server. It's just annoying to see that message all over the console.

I will try to fix this issue asap, but since it does not break the functionality of the plugin or anything else, it has a lower priority for me than other things

Just curious, what happens if you run this and the Halloween plugin at the same time?

This plugin has been reporting errors, I don't know why

Failed to call hook 'OnEntitySnapshot' on plugin 'Christmas v1.0.3' (NullReferenceException: Object reference not set to an instance of an object)
  at Oxide.Plugins.Christmas+TreeScaleManager.TreeNeedsUpdate (ChristmasTree tree, Network.Connection connection) [0x00000] in <a90031c16c7041859de3d7daa3e182dd>:0 
  at Oxide.Plugins.Christmas.OnEntitySnapshot (ChristmasTree entity, Network.Connection connection) [0x00014] in <a90031c16c7041859de3d7daa3e182dd>:0 
  at Oxide.Plugins.Christmas.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x002d0] in <a90031c16c7041859de3d7daa3e182dd>:0 
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <23ba99f131254889867c71f0bd137b1d>:0 
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <157a94ee66ab4a7991faecd1eb84be3b>:0 
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <157a94ee66ab4a7991faecd1eb84be3b>:0

On 12/19/2022 at 7:38 AM, The_Kiiiing said:

I will release a fix for this issue in a few days

This appears to still be an issue. The NPCS on oil rig and junkpiles are not dropping any loot at all. We are running this for an xmas in July event.

Not sure what changed as this worked last year but the Snowman NPC's no longer AGRO and ATTACK the players when they spawn. The road scientist function but not the snowmen.

Any update to this, has it been fixed?

I am having the same issue as the 2 above me - Snowmen won't go aggro or attack.  

NPCSpawn was updated on May 27th and it appears this plugin was not updated to the newer format with regards to the Snowmen. Switching to the new format seems to work and the snowmen come back to life.

how did you fix it? can you help us until he gets to it?  I noticed the plugin isn't for sale when I looked this morning...sucks since I bought it a week ago...

I am currently working on an update, it will be released in the next few days

On 12/2/2023 at 3:08 PM, The_Kiiiing said:

I am currently working on an update, it will be released in the next few days

Don't mean to be pesty, but I am super excited to release this to my server and unfortunately can't until the NPC outfit problem is fixed - any updates? (It is over-riding junkpile and oilrig scientists - even though it is checked false)

@The_Kiiiing
Is it possible to add a check that would disable looting the Christmas tree? I don't want players to be able to get the ornaments, as I have other systems in place to accomplish that via my economy - without that option I really can't use this

I have a lot of these, at least a few dozen, any fix?

4 hours ago, SirApesALot said:

I have a lot of these, at least a few dozen, any fix?

Same here.

1 hour ago, CashDK said:

Same here.

 

have the same, and no loot for oilrig scientists

I'm probably doing something wrong, but I've got both NPC Spawn, and EntityScaleManager in Carbon, and I just bought Christmas too.

The snow patches, and falling snow, presents and such all spawn ok.  But I'm not seeing any actual Christmas trees, there seems to just be normal trees and bushes instead. What have I done wrong please?

The snowmen don't seem to react to me either, but others have reported that above so I assume a fix is coming.

17 hours ago, Ryster said:

I'm probably doing something wrong, but I've got both NPC Spawn, and EntityScaleManager in Carbon, and I just bought Christmas too.

The snow patches, and falling snow, presents and such all spawn ok.  But I'm not seeing any actual Christmas trees, there seems to just be normal trees and bushes instead. What have I done wrong please?

The snowmen don't seem to react to me either, but others have reported that above so I assume a fix is coming.

 

The snowmen coming to life was updated last week, I believe - mine are functioning ok now.  I also get the trees spawning ok as well.  Just my 2 cents.

On 12/7/2023 at 7:07 PM, SirApesALot said:

I have a lot of these, at least a few dozen, any fix?

I have the same issue, it doesn't seem to bother players much, but it is annoying to me.. Any fix yet?