4.1.3 crash on load w/possible fix

Getting a crash on load with the new version (see below for proposed solution):  

(20:24:49) | Loaded plugin UpdateChecker v4.1.3 by tofurahie [138ms]
(20:24:49) | Failed to call internal hook 'OnServerInitialized' on plugin 'UpdateChecker v4.1.3' [1330569572] (The specified path is not of a legal form (empty).)
   at string System.IO.Path.InsecureGetFullPath(string path)
   at string System.IO.Path.GetFullPath(string path)
   at new System.IO.Enumeration.FileSystemEnumerator<string>(string directory, EnumerationOptions options)
   at new System.IO.Enumeration.FileSystemEnumerable<string>+DelegateEnumerator(FileSystemEnumerable<string> enumerable)
   at new System.IO.Enumeration.FileSystemEnumerable<string>(string directory, FindTransform transform, EnumerationOptions options)
   at IEnumerable<string> System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(string directory, string expression, EnumerationOptions options)
   at IEnumerable<string> System.IO.Directory.InternalEnumeratePaths(string path, string searchPattern, SearchTarget searchTarget, EnumerationOptions options)
   at string[] System.IO.Directory.GetFiles(string path, string searchPattern, EnumerationOptions enumerationOptions) x 2
   at List<AboutPlugin> Oxide.Plugins.UpdateChecker.GetAllPlugins() in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 326
   at void Oxide.Plugins.UpdateChecker.ClearPluginList()+(PluginInfo cfgPlugin) => { } in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 361
   at int System.Collections.Generic.List<Oxide.Plugins.UpdateChecker+PluginInfo>.RemoveAll(Predicate<PluginInfo> match)
   at void Oxide.Plugins.UpdateChecker.ClearPluginList() in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 361
   at void Oxide.Plugins.UpdateChecker.UpdatePluginList() in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 341
   at void Oxide.Plugins.UpdateChecker.CheckPlugins() in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 317
   at void Oxide.Plugins.UpdateChecker.OnServerInitialized() in C:/Games/rust/carbon/plugins/UpdateChecker.cs:line 170
   at object Oxide.Plugins.UpdateChecker.InternalCallHook(uint hook, object[] args) in UpdateChecker.cs/Internal:line 134

 

I think the fix might be to modify the `foreach` loop in `GetAllPlugins()` to be as follows:

foreach (var check in Directory.GetFiles(Interface.Oxide.PluginDirectory))

 

I can confirm the problem. I saw an mmap issue during startup just before the server became live. Terminated the server.

can confirm same.  Am running carbon (if it matters).

Changed Status from Pending to Work in Progress

Changed Status from Work in Progress to Closed

Changed Fixed In to 4.1.4