Attachment MotorBike 1.1.4

Hello, great idea. I have an issue with it . Every time i reload the plugin with a new skin id or just reload it , everytime it spawns new crates on motorbikes and at this point players have around 5 boxes in each motorbike and they cannot find loot anymore. That didn t fix even after server restart. Also i'm using your plugin on 2 of my servers. On 1 server bikes are working to mount and on another i can no longer mount bikes. Any ideea what might cause these bugs?
And even after removing the plugin , the crates are not being removed from bikes and that require a server restart to work. I haven't tested but i hope they do get removed after server restart but it's not the most optimal way to remove it.

Thank you.

@Torken

Hello, cool plugin. However, you should add an option to disable console logs as there's too much spam.
And pookie and boxes can be picked up with a hammer.
I also noticed that in the Init method, you're unsubscribing and resubscribing to hooks, which is illogical.
By default, you are subscribed to all the hooks you have. Therefore, in Init, you need to unsubscribe from OnEntitySpawned, OnEntityKill and then subscribe back to them at the end of the OnServerInitialized method.
Also, you should remove the line:

Subscribe(nameof(OnServerInitialized));

I would also recommend using the overloaded OnEntitySpawned(Bike bike) and OnEntityKill(Bike bike) hooks so that only bikes will be processed by your hook.
In OnServerInitialized, add a check in a foreach loop like this:

foreach (var entity in BaseNetworkable.serverEntities)
{
    if (entity is Bike bike)
        OnEntitySpawned(bike);
}

I'm not trying to be picky, just offering friendly advice

I’m having the same issue as another comment posted. After restart, bicycles are no longer mountable. 

On 7/26/2024 at 12:02 PM, Mr. Wilder Wilderness said:

Hello, great idea. I have an issue with it . Every time i reload the plugin with a new skin id or just reload it , everytime it spawns new crates on motorbikes and at this point players have around 5 boxes in each motorbike and they cannot find loot anymore. That didn t fix even after server restart. Also i'm using your plugin on 2 of my servers. On 1 server bikes are working to mount and on another i can no longer mount bikes. Any ideea what might cause these bugs?
And even after removing the plugin , the crates are not being removed from bikes and that require a server restart to work. I haven't tested but i hope they do get removed after server restart but it's not the most optimal way to remove it.

Thank you.

Hello,

Thank you for your feedback. I'm working on resolving the issues you've mentioned:

Crates on Motorbikes: I'll fix the bug causing multiple crates to spawn on motorbikes upon reload.

Mounting Bikes: I'll investigate why bikes are mountable on one server but not on another.

Crates Not Being Removed: I'll ensure crates are removed properly without needing a server restart.

Thank you for your patience.

Best regards, Torken

On 7/26/2024 at 1:30 PM, IIIaKa said:

@Torken

Hello, cool plugin. However, you should add an option to disable console logs as there's too much spam.
And pookie and boxes can be picked up with a hammer.
I also noticed that in the Init method, you're unsubscribing and resubscribing to hooks, which is illogical.
By default, you are subscribed to all the hooks you have. Therefore, in Init, you need to unsubscribe from OnEntitySpawned, OnEntityKill and then subscribe back to them at the end of the OnServerInitialized method.
Also, you should remove the line:

Subscribe(nameof(OnServerInitialized));

On 7/26/2024 at 1:35 PM, IIIaKa said:

I would also recommend using the overloaded OnEntitySpawned(Bike bike) and OnEntityKill(Bike bike) hooks so that only bikes will be processed by your hook.
In OnServerInitialized, add a check in a foreach loop like this:

foreach (var entity in BaseNetworkable.serverEntities)
{
    if (entity is Bike bike)
        OnEntitySpawned(bike);
}

I'm not trying to be picky, just offering friendly advice

Hello,

Thank you for your feedback and suggestions. I appreciate your insights and will take them into consideration. Here are the actions I plan to take:

Console Logs: I'll limit console logs to the strictly necessary to reduce spam.

Pickup with Hammer: I'll address the issue with pookie and boxes being picked up with a hammer.

Hooks Subscription: I'll revise the hook subscription logic as you've suggested to avoid redundant operations and improve efficiency.

Code Improvements: I'll implement your recommendations regarding the OnEntitySpawned and OnEntityKill hooks, and adjust the OnServerInitialized method accordingly.

Thanks again for your constructive advice!

Best regards, Torken.

3 hours ago, laceyblonde said:

I’m having the same issue as another comment posted. After restart, bicycles are no longer mountable. 

Hello,

Thank you for bringing this issue to my attention. I'm aware of the problem with bicycles not being mountable after a restart and am currently working on a fix. I appreciate your patience and will release an update as soon as possible to address this.

Best regards, Torken.

Hello there, i having same issue as many users before me, with bike's ... unable to mount on them. 
But on another side, i not having issue with duplicated boxes on motorbikes .... when i loaded plugin i changed skinid to different one and no issue with boxes.
 

I hope its help you these informations. 

Have a nice day

My men i ve been so busy this week finding what was causing a wierd bug where all the loot from loot isles and crates near roads were droped on ground. It was from your plugin..... please fix that asap

On 8/8/2024 at 1:09 PM, Mr. Wilder Wilderness said:

My men i ve been so busy this week finding what was causing a wierd bug where all the loot from loot isles and crates near roads were droped on ground. It was from your plugin..... please fix that asap

Hi,

Thank you for bringing this to my attention. I sincerely apologize for the delayed response; I've been on vacation. I will review the issue you mentioned with the loot dropping on the ground from loot isles and crates near roads. I'll work on a fix as soon as possible and get it resolved. I appreciate your patience and understanding.

Best regards,
Torken

The item drop was fixed but the plugin still bugs out and even i restarted the server, after it does the follwing things in console some crates on bikes or motorobikes are still doubled. After i delete plugin and reload it they work again but after some time or after server restart the bugs hapens

Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]

On 8/16/2024 at 6:52 AM, Mr. Wilder Wilderness said:

The item drop was fixed but the plugin still bugs out and even i restarted the server, after it does the follwing things in console some crates on bikes or motorobikes are still doubled. After i delete plugin and reload it they work again but after some time or after server restart the bugs hapens

Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]
Calling kill - but already IsDestroyed!? sphere[0]

I was wondering what plugin was causing this!! It's been annoying hearing players ask me why loot is randomly on the ground by the roads

Last updates went well and the plugins runs great but after FP update players cannot mount the normal bikes anymore

On 9/6/2024 at 12:37 PM, Mr. Wilder Wilderness said:

Last updates went well and the plugins runs great but after FP update players cannot mount the normal bikes anymore

This is still a thing where players can t mount bikes