Dealer spawns/markers

Disregard this initial part of the ticket. I've resolved it, but see the below follow ups.

Also, it seems the dealer always spawns facing north when you use the command to spawn them.

Also, since i have this ticket open, got this in my log today:
 

Calling hook OnItemSplit resulted in a conflict between the following plugins: DrugBusiness - Item.applex1.376367045 (Item), Cooking (Item.applex1.376367046 (Item))

Sorry for the multiple support requests in one, but here's another issue... deleted a dealer and this was in the console:

Failed to call hook 'DeleteDealer' on plugin 'DrugBusiness v0.2.0' (NullReferenceException: Object reference not set to an instance of an object)
at Oxide.Plugins.DrugBusiness+<DeleteDealer>c__AnonStorey8.<>m__1 (Oxide.Plugins.DrugBusiness+DealerInfo d) [0x00000] in <1ac433838223432fa635bdbfc5f3cffb>:0
at System.Collections.Generic.List`1[T].FindIndex (System.Int32 startIndex, System.Int32 count, System.Predicate`1[T] match) [0x0003b] in <fb001e01371b4adca20013e0ac763896>:0
at System.Collections.Generic.List`1[T].FindIndex (System.Predicate`1[T] match) [0x00000] in <fb001e01371b4adca20013e0ac763896>:0
at Oxide.Plugins.DrugBusiness.DeleteDealer (BasePlayer player, System.String command, System.String[] args) [0x00045] in <1ac433838223432fa635bdbfc5f3cffb>:0
at Oxide.Plugins.DrugBusiness.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00a76] in <1ac433838223432fa635bdbfc5f3cffb>:0
at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <e23ba2c0f246426296d81c842cbda3af>:0
at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <46ff2b534abb4b35952608167523b7ec>:0
at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <46ff2b534abb4b35952608167523b7ec>:0

The dealer reappeared when I reloaded the plugin.

I stopped the plugin, deleted the data file and started the plugin to resolve this issue.

Looking into these.

Changed Status from Pending to Work in Progress

4 hours ago, BetterDeadThanZed said:

Sorry for the multiple support requests in one, but here's another issue... deleted a dealer and this was in the console:

Failed to call hook 'DeleteDealer' on plugin 'DrugBusiness v0.2.0' (NullReferenceException: Object reference not set to an instance of an object)
at Oxide.Plugins.DrugBusiness+<DeleteDealer>c__AnonStorey8.<>m__1 (Oxide.Plugins.DrugBusiness+DealerInfo d) [0x00000] in <1ac433838223432fa635bdbfc5f3cffb>:0
at System.Collections.Generic.List`1[T].FindIndex (System.Int32 startIndex, System.Int32 count, System.Predicate`1[T] match) [0x0003b] in <fb001e01371b4adca20013e0ac763896>:0
at System.Collections.Generic.List`1[T].FindIndex (System.Predicate`1[T] match) [0x00000] in <fb001e01371b4adca20013e0ac763896>:0
at Oxide.Plugins.DrugBusiness.DeleteDealer (BasePlayer player, System.String command, System.String[] args) [0x00045] in <1ac433838223432fa635bdbfc5f3cffb>:0
at Oxide.Plugins.DrugBusiness.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00a76] in <1ac433838223432fa635bdbfc5f3cffb>:0
at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <e23ba2c0f246426296d81c842cbda3af>:0
at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000d8] in <46ff2b534abb4b35952608167523b7ec>:0
at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <46ff2b534abb4b35952608167523b7ec>:0

The dealer reappeared when I reloaded the plugin.

I stopped the plugin, deleted the data file and started the plugin to resolve this issue.

For this error, we need to move dealer.KillMessage(); on line 601 down to at least line 610 after the conditional. If we don't, we're deleting the actual dealer npc and then trying to use it to find the index afterward. We won't be able to reference that object to find the index because that object was already deleted. Also, we should likely uncomment the SaveData(); on line 617 so that the dealer deletion is saved right away.

Changed Status from Work in Progress to Closed

Changed Fixed In to 0.3