Ownership stuck on players after update

Dears,

despite "MonumentOwner" (1.4.1) being bugged badly I will have to go back to that version as it at least handled locking and relesing ownerships somewhat ok-ish and problems can be worked around. In the new version 1.5.5 I'm missing proper announcements for monument locks in global chat, and in addition ownership is not released from monuments even if the player logs off and the server does it's nightly restart. Although I like some of the new ideas, especially having points to lock a monument rather than doing a series of things, locking and unlocking as a core feature has to work reliably.

8 hours ago, miniMe_rust said:

Dears,

despite "MonumentOwner" (1.4.1) being bugged badly I will have to go back to that version as it at least handled locking and relesing ownerships somewhat ok-ish and problems can be worked around. In the new version 1.5.5 I'm missing proper announcements for monument locks in global chat, and in addition ownership is not released from monuments even if the player logs off and the server does it's nightly restart. Although I like some of the new ideas, especially having points to lock a monument rather than doing a series of things, locking and unlocking as a core feature has to work reliably.

I'm sorry that you're facing this problem, but could you send me some video or maybe errors from the console that will let me know whose name the problem is

3 hours ago, jtedal said:

I'm sorry that you're facing this problem, but could you send me some video or maybe errors from the console that will let me know whose name the problem is

Hey thanks for getting back to me. I had this problem with several players. Already went back to version 1.4.1 which resolved the problem for me. I didn't record any clips. Checking logs from this morning (nightly server restart till I downgraded Monument Owner from 1.5.5 to 1.4.1) I don't see any errors. Hence whatever it is, it happens silently. Monuments locked by a player stay locked. The map markers still said monuments were locked to players with 572 or so seconds left. The player was logged off for hours already. After server restart monuments were still locked to the same players.

I attach the relevant part of the logs.

Before I went back to 1.4.1 I unloaded version 1.5.5 and deleted all the config, language and data files. Then I copied the files back fresh from the ZIP file, and configured the monuments (no domes, cooldown set to 1 second as players should immediately be able to re-gain ownership, and 60 points needed to gain ownership). I also made sure files are owned by the server. No errors in the logs that I could find. That was last night. This morning monument locks were frozen in time, no errors in logs, hence I decided to go back to 1.4.1.

Here is an exemplary monument config (Airfield.json) - I set them all in a similar fashion

{
  "On/Off": true,
  "Local position (regarding the monument)": "(0, 0, -26.673)",
  "Zone shape settings": {
    "Type (0 - Sphere, 1 - Box)": 0,
    "Size": "(100, 100, 100)",
    "Radius": 205.0,
    "Zone dimmer (0 - remove the dimmer)": 0,
    "Use colored spheres to display the status of the monument (Green - free; Red - Busy)": true
  },
  "Display settings": {
    "Enable the display of the radius of the zone on the map": true,
    "Enable the display of the zone marker on the map": true,
    "The position of the marker relative to the position of the monument": "(0, 0, 0)"
  },
  "Monument settings": {
    "Timers": {
      "Cooldown timer after becoming monument owner during which the player cannot claim the title again in seconds": 1.0,
      "Timed duration which the player will retaion ownership of the monument in seconds": 600,
      "The amount of time which the owner can leave the monument area and retain their title in seconds": 300
    },
    "Settings for obtaining monument owner status": {
      "The number of points that the player must receive to become the owner of the monument": 60,
      "Points for time": {
        "On/Off": true,
        "Number of points per 1 sec": 1
      },
      "Points for NPC damage": {
        "On/Off": true,
        "Number of points per 1 damage": 1
      },
      "Points for Boss damage (Settings for the \"BossMonster\" plugin)": {
        "On/Off": true,
        "Number of points per 1 damage": 1
      },
      "Points for Bradley damage": {
        "On/Off": true,
        "Number of points per 1 damage": 1
      },
      "Points for crates": {
        "On/Off": true,
        "Default number of points (if the entity name is not in the list below)": 5,
        "Entities": {
          "assets/bundled/prefabs/radtown/crate_normal_2.prefab": 10,
          "assets/bundled/prefabs/radtown/crate_normal.prefab": 20,
          "assets/bundled/prefabs/radtown/crate_elite.prefab": 30
        }
      },
      "Points for open doors": {
        "On/Off": true,
        "Default number of points (if the entity name is not in the list below)": 5,
        "Entities": {
          "Green": 10,
          "Blue": 20,
          "Red": 30
        }
      },
      "Points for collectable items": {
        "On/Off": true,
        "Default number of points (if the entity name is not in the list below)": 5,
        "Entities": {
          "assets/bundled/prefabs/autospawn/collectable/hemp/hemp-collectable.prefab": 10,
          "assets/bundled/prefabs/autospawn/collectable/wood/wood-collectable.prefab": 10,
          "assets/bundled/prefabs/autospawn/collectable/stone/metal-collectable.prefab": 10,
          "assets/bundled/prefabs/autospawn/collectable/stone/sulfur-collectable.prefab": 10,
          "assets/bundled/prefabs/autospawn/collectable/stone/stone-collectable.prefab": 10,
          "assets/content/structures/excavator/prefabs/diesel_collectable.prefab": 10
        }
      },
      "Points for start hacking the crate": {
        "On/Off": true,
        "Number of points per launch": 50
      }
    },
    "Settings for Monument guests": {
      "Can a non owner enter or stay in the zone": true,
      "Can deal damage to NPCs if not an owner": false,
      "Can deal damage to tanks if not an owner": false,
      "Can deal damage to barrel if not an owner": false,
      "Can crates be looted if not an owner": false,
      "Can collectable items (diesel, cards) be pickup if not an owner": false,
      "Can crates be hacked if not an owner": false,
      "Can the doors be opened with a card": true,
      "Can backpacks be looted if not an owner": false,
      "Can recycler be used if not an owner": true,
      "Can NPCs target players if not an owner": true,
      "Can tanks target players if not an owner": true
    }
  }
}

log.txt

On 6/30/2024 at 9:07 PM, miniMe_rust said:

Hey thanks for getting back to me. I had this problem with several players. Already went back to version 1.4.1 which resolved the problem for me. I didn't record any clips. Checking logs from this morning (nightly server restart till I downgraded Monument Owner from 1.5.5 to 1.4.1) I don't see any errors. Hence whatever it is, it happens silently. Monuments locked by a player stay locked. The map markers still said monuments were locked to players with 572 or so seconds left. The player was logged off for hours already. After server restart monuments were still locked to the same players.

I attach the relevant part of the logs.

Before I went back to 1.4.1 I unloaded version 1.5.5 and deleted all the config, language and data files. Then I copied the files back fresh from the ZIP file, and configured the monuments (no domes, cooldown set to 1 second as players should immediately be able to re-gain ownership, and 60 points needed to gain ownership). I also made sure files are owned by the server. No errors in the logs that I could find. That was last night. This morning monument locks were frozen in time, no errors in logs, hence I decided to go back to 1.4.1.

Here is an exemplary monument config (Airfield.json) - I set them all in a similar fashion

{
 "On/Off": true,
 "Local position (regarding the monument)": "(0, 0, -26.673)",
 "Zone shape settings": {
 "Type (0 - Sphere, 1 - Box)": 0,
 "Size": "(100, 100, 100)",
 "Radius": 205.0,
 "Zone dimmer (0 - remove the dimmer)": 0,
 "Use colored spheres to display the status of the monument (Green - free; Red - Busy)": true
 },
 "Display settings": {
 "Enable the display of the radius of the zone on the map": true,
 "Enable the display of the zone marker on the map": true,
 "The position of the marker relative to the position of the monument": "(0, 0, 0)"
 },
 "Monument settings": {
 "Timers": {
 "Cooldown timer after becoming monument owner during which the player cannot claim the title again in seconds": 1.0,
 "Timed duration which the player will retaion ownership of the monument in seconds": 600,
 "The amount of time which the owner can leave the monument area and retain their title in seconds": 300
 },
 "Settings for obtaining monument owner status": {
 "The number of points that the player must receive to become the owner of the monument": 60,
 "Points for time": {
 "On/Off": true,
 "Number of points per 1 sec": 1
 },
 "Points for NPC damage": {
 "On/Off": true,
 "Number of points per 1 damage": 1
 },
 "Points for Boss damage (Settings for the \"BossMonster\" plugin)": {
 "On/Off": true,
 "Number of points per 1 damage": 1
 },
 "Points for Bradley damage": {
 "On/Off": true,
 "Number of points per 1 damage": 1
 },
 "Points for crates": {
 "On/Off": true,
 "Default number of points (if the entity name is not in the list below)": 5,
 "Entities": {
 "assets/bundled/prefabs/radtown/crate_normal_2.prefab": 10,
 "assets/bundled/prefabs/radtown/crate_normal.prefab": 20,
 "assets/bundled/prefabs/radtown/crate_elite.prefab": 30
 }
 },
 "Points for open doors": {
 "On/Off": true,
 "Default number of points (if the entity name is not in the list below)": 5,
 "Entities": {
 "Green": 10,
 "Blue": 20,
 "Red": 30
 }
 },
 "Points for collectable items": {
 "On/Off": true,
 "Default number of points (if the entity name is not in the list below)": 5,
 "Entities": {
 "assets/bundled/prefabs/autospawn/collectable/hemp/hemp-collectable.prefab": 10,
 "assets/bundled/prefabs/autospawn/collectable/wood/wood-collectable.prefab": 10,
 "assets/bundled/prefabs/autospawn/collectable/stone/metal-collectable.prefab": 10,
 "assets/bundled/prefabs/autospawn/collectable/stone/sulfur-collectable.prefab": 10,
 "assets/bundled/prefabs/autospawn/collectable/stone/stone-collectable.prefab": 10,
 "assets/content/structures/excavator/prefabs/diesel_collectable.prefab": 10
 }
 },
 "Points for start hacking the crate": {
 "On/Off": true,
 "Number of points per launch": 50
 }
 },
 "Settings for Monument guests": {
 "Can a non owner enter or stay in the zone": true,
 "Can deal damage to NPCs if not an owner": false,
 "Can deal damage to tanks if not an owner": false,
 "Can deal damage to barrel if not an owner": false,
 "Can crates be looted if not an owner": false,
 "Can collectable items (diesel, cards) be pickup if not an owner": false,
 "Can crates be hacked if not an owner": false,
 "Can the doors be opened with a card": true,
 "Can backpacks be looted if not an owner": false,
 "Can recycler be used if not an owner": true,
 "Can NPCs target players if not an owner": true,
 "Can tanks target players if not an owner": true
 }
 }
}

 

log.txt 22.87 kB · 3 downloads

Thanks for the reply. You are not the first to complain about such a problem, so I will look for a solution. Keep an eye on the changelog of updates. There will be a notification about the solution to this problem

Changed Status from Pending to Work in Progress

Hi @jtedal,

I've just installed your new update 1.5.6 and found that - at first glance - ownership seems to get assigned and removed as expected. I need to test more and also refine configuration of zones, before I can give a more conclusive feedback. Things that caught my eye (positive and negative):

• (+) Ownership gains and losses are now properly announced in global chat again.
• (+) Map markers are updated properly and show owner and time, or "Nobody"
• (-) Now I get additional text on what I can do to get points - ond monument ownership. This is definitely too much output, and easily makes global chat unusable for the respective player..

As of now, I restored most of my initial config (no visible sphere, points needed = 60, cooldown = 1 sec, guests can use recycler). This seems to work so far, but after 30 minutes I clearly need to test more before I can say anything.

On a bottom line I think there should be a distinction between relevant information (points needed: 60, you have: 25) and redundant information (you can get points for this, this and this). The latter is only relevant the first or second time you see it, then it becomes more and more redundant. Such text should be compressed, maybe by giving the server owner an option to have verbose output, compressed output or no output of such information text. Maybe there could even be a chat command the player can enter to see what to do in order to earn the needed points. This way your info text could be 1 line "enter command /mopoints to see points you can earn in this monument" or something along those lines.

Thanks again for a great plugin. I'm looking forwards to spending a few hours on my 2nd server with testing and tweaking the configuration. Hoping that I don't need to downgrade again.

@miniMe_rust
Hi. Thank you for your feedback.I hope you won't run into any problems.

1) The plugin configuration now has a list with allowed messages. You can customize it for yourself, BUT it is impossible to delete some lines about glasses. You can only remove the entire message about this. Just delete "GUI_GetPointsFor"

"List of LangKeys that can be sent to the chat": [
      "NewOwner",
      "CantEnter",
      "MonumentCooldown",
      "BossCooldown",
      "CantEnterAnot",
      "EnteringZone",
      "LeavingZone",
      "LostOwner",
      "CantDoIt",
      "CantShoot",
      "GUI_GetPointsFor",
      "DontHaveCooldowns",
      "Cooldowns",
      "Alert_DeleteOwner",
      "Alert_NewOwner"
    ]

2) Yes, you made a good point. If you noticed, then my key for the text starts with the words GUI. The fact is that this is what I originally planned. Either place a small window on the screen for a while or make a full GUI with a description of all possible ways to get points. But due to the rush, I did not have time to finish this part of the plugin to the ideal, so I was forced to temporarily use the chat for this. So you are completely right, this will appear in future updates.

Hi @jtedal,

1) I didn't need to touch the LangKeys, instead I disabled points for collectables, crates, etc. - for now this seems to work for me. I'm going to test it a few hours and come back with feedback.

Update 2024-07-06 - upgraded the Monument Owner plugin to version 1.5.7 - still looks good so far. No errors in logs, ownership correctly assigned and removed. Testing further.

Hi @jtedal,

I've upgraded several times 1.5.5 > 1.5.6 > 1.5.7 > 1.5.8 and every time restarted my test (ouch). Monument ownership assignment and release appears to work fine overall. However, I believe your default monument zones config is a bit off. Especially at very large monuments like Excavator or Launchsite you have to get really close to the monument center, before the options to gain ownership show up. I believe that has to do with the monument Radius and Size which appear to be conflicting. I understand that the Size is 100 in each direction x,y,z but the Radius is 300.

This is from Launchsite config in version 1.5.8:

  "Zone shape settings": {
    "Type (0 - Sphere, 1 - Box)": 1,
    "Size": "(100, 100, 100)",
    "Radius": 300.0,
    "Zone dimmer (0 - remove the dimmer)": 0,
    "Use colored spheres to display the status of the monument (Green - free; Red - Busy)": false
  },

While the size of the monument circle on the map appears to be just fine, you have to go like 2/3 of the distance towards the map marker / center, before the ownership options show and you can become owner. Shouldn't the Size be considerably larger? Something in between 150-300 (not sure how to interpret Size here - is it really x,y,z?).

@miniMe_rust Apparently I made a mistake when I thought my config would be clear And so:

The monument area can have two different types of collider (spherical and square). If you are using a spherical zone, the plugin only considers the radius parameter in order to set the dimensions for it. If you are using a box, the plugin sets values based only on the size. It completely ignores the radius. It is for this reason that you receive a message only closer to the middle of the monument because the default size is too small. I didn't waste time adjusting the sizes for each cuboid zone because I didn't know how popular this parameter would be. I decided that the customers will be able to customize them themselves.

Now I think you understand how it works and also I would like to remind you that there is a new command in the plugin that will allow the administrator to view the boundaries of each square zone

/modrawedges

P.S. These are ready-made good square area sizes for the Launch Site
 

"Size": "(600, 100, 300)",

2 hours ago, jtedal said:

@miniMe_rust Apparently I made a mistake when I thought my config would be clear And so:

The monument area can have two different types of collider (spherical and square). If you are using a spherical zone, the plugin only considers the radius parameter in order to set the dimensions for it. If you are using a box, the plugin sets values based only on the size. It completely ignores the radius. It is for this reason that you receive a message only closer to the middle of the monument because the default size is too small. I didn't waste time adjusting the sizes for each cuboid zone because I didn't know how popular this parameter would be. I decided that the customers will be able to customize them themselves.

Now I think you understand how it works and also I would like to remind you that there is a new command in the plugin that will allow the administrator to view the boundaries of each square zone

/modrawedges

P.S. These are ready-made good square area sizes for the Launch Site
 

"Size": "(600, 100, 300)",

 

Hi @jtedal,

ouff I wasn't aware that 2 monuments are set to "box" by default - Launchsite and Stone Quarry. I was convinced everything is spherical since I never changed those defaults. Hence it never occurred to me to check /modrawedges to see the actual outer edges of monument zones. The values for "Size" you suggested for Launchsite appear to work fine - thanks for that.

Since the plugin appears to work so far on my 2nd server and I don't see any errors in the console, I will now transfer plugin and config to my main server. This will intensify tests, and for sure my players will tell me if something doesn't look right. I hope they like the changes just like I do. Thanks again for your quick responses and for a great plugin. Please expect a bit more feedback in a couple of days.

-- deleted --

I had some issues with updating the plugin from 1.4.1 to 1.5.8 on my main server - chat announcements were crippled (only showed the language keys but not the respective texts from the language file) and there were errors in the logs. Long story short, all it needed was a server restart. Unloading and reloading plugins did not solve the issue. Now, after a server restart, chat announcements do work fine just like on my 2nd / test server. Maybe this info can help other users.

I found a new issue - probably you will confirm that Discord webhooks are not yet triggered (?)
Setup Discord on both my servers, but nothing coming in from Monument Owner.

Occasionally it seem to happen that players do not receive ownership of a monument, even though they should have enough points. 60 points needed, hacking a crate gives 60 points, timer per second gives 1 point. After several minutes still not owner of that monument. It seems to be related to the appearance of this error in the logs:

FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.

Could this be related to the recent forced update (6-July Facepunch forced update)?

It becomes more and more evident:

• My initial problem is solved - ownership is no longer stuck on players. That's great!
• BUT
• There are more problems I found in testing. If this requires a new bug report I'm fine with this support ticket to be closed and can open a new ticket for the new problems. Let me know.
• Details:
• Cargo: When Cargo reached harbors, per default config the harbor zone is deleted. But it is not restored when Cargo departs, which results in Harbors no longer having monument zones(!)
• Large(r) monuments like Excavator or Water Treatment often fail for players to gain ownership, even though players receive points per second and only need 60 points to become owner.
• Small(er) monuments seem to work fine. I have not seen a single case where gaining or removing ownership didn't work.
• "Hacking the crate" should give 60 points, but doesn't do anything. Players don't become owner.

As already stated in my previous post, players not gaining ownership appears randomly and seems to cause this error message to show in the console:

FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.

Other than that there are no error messages in the log I can find or relate to Monument Owner. As of now, gaining ownership is not working reliably. I'm hoping that @jtedal will be able to fix it in subsequent updates, and I will be happy to test more when updated. For now I will stay on version 1.5.8 even though it is not working reliably. That is, because I don't see any harmful problems, and the plugin is working for the most part at least for mid-size and small monuments.

@miniMe_rust

• I know about the problems with getting the owner status. Players on any monument can get a sufficient number of points, but they never become owners. I am currently communicating with several server owners who are testing new versions at home to solve this problem
• I am also aware that the zone is not created after the cargo sails out of the harbor. I just forgot to do it and postponed it for now so that the first thing to do was to solve the plugin's inactivity. I think you will agree that this is more important
• The error you sent me has nothing to do with the problem you are describing, but I would like to take a look at the complete error to understand in which method it occurs. Please send it to me
• The fact that you don't get points for hacking the box is strange. I'll check it out and fix it.

24 minutes ago, jtedal said:

@miniMe_rust

• I know about the problems with getting the owner status. Players on any monument can get a sufficient number of points, but they never become owners. I am currently communicating with several server owners who are testing new versions at home to solve this problem
• I am also aware that the zone is not created after the cargo sails out of the harbor. I just forgot to do it and postponed it for now so that the first thing to do was to solve the plugin's inactivity. I think you will agree that this is more important
• The error you sent me has nothing to do with the problem you are describing, but I would like to take a look at the complete error to understand in which method it occurs. Please send it to me
• The fact that you don't get points for hacking the box is strange. I'll check it out and fix it.

Hi @jtedal,

I was able to reproduce - started with Excavator, became owner. Continued to Train Yard and hacked a crate, became owner. I headed on to Water Treatment and became owner. Went back to Train Yard, wasn't able to get ownership. Went on to Water Treatment, wasn't able to get ownership. Went on to Excavator, wasn't able to get ownership. That is also what players on my main server told me - monuments eventually fail the player to become owner, regardless of whether they hack a crate or stick around. The blue overlay with the score shows, but points remain 0 - I've attached screenshots from Train Yard and Excavator where you can see that points remain 0.

Nothing overly interesting in the logs - I think the problem comes when you return to a monument where you already have been.

[BoxLooters] Saved Boxlooters data
Saved 65,321 ents, cache(0.09), write(0.03), disk(0.03).
Saving complete
185.136.69.80:58380/76561197972574740/miniMe has auth level 2
185.136.69.80:58380/76561197972574740/miniMe joined [windows/76561197972574740]
miniMe[76561197972574740] has spawned
boneReference is null on Skeleton.Wolf
7461695[7461695] was killed by miniMe[76561197972574740] at (-894.45, 21.09, 724.55)
[BoxLooters] Saved Boxlooters data
Saved 65,270 ents, cache(0.08), write(0.04), disk(0.03).
Saving complete
2394403[2394403] was killed by miniMe[76561197972574740] at (-896.92, 19.17, 724.68)
FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
5383786[5383786] was killed by miniMe[76561197972574740] at (737.97, 29.71, 258.07)
9281350[9281350] was killed by miniMe[76561197972574740] at (735.18, 32.71, 252.77)
[BoxLooters] Saved Boxlooters data
Saved 65,275 ents, cache(0.13), write(0.03), disk(0.03).
Saving complete
FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
Invalid Position: chicken.corpse[5813901] (1011.45, -501.07, 906.59) (destroying)
[BoxLooters] Saved Boxlooters data
Saved 65,336 ents, cache(0.08), write(0.04), disk(0.03).
Saving complete
185.136.69.80:58380/76561197972574740/miniMe disconnecting: disconnect
[event] assets/prefabs/npc/cargo plane/cargo_plane.prefab
Checking for new Steam Item Definitions..

@miniMe_rust
I was create the ticket in our discord. Can you answer there?

Changed Status from Work in Progress to Closed

Changed Fixed In to 1.5.9