Custom Rune Negative Skin ID Support

While configuring for custom enchanting items, such as glue or paper, it appears the plugin does not support negative skin ID values - upon changing Glue or Paper to not include the -, the plugin works correctly again and does not revert to default configuration.

Not a big deal for what I am using for custom components, but for anyone using a custom skin that has a negative front value this would be a problem.

On 5/17/2022 at 5:08 AM, Somescrub said:

While configuring for custom enchanting items, such as glue or paper, it appears the plugin does not support negative skin ID values - upon changing Glue or Paper to not include the -, the plugin works correctly again and does not revert to default configuration.

 

Not a big deal for what I am using for custom components, but for anyone using a custom skin that has a negative front value this would be a problem.

What skins have negative values in them?

Skins use a ulong value, which only allows positive numbers.

Are you talking about item IDs?

On 5/20/2022 at 8:21 PM, imthenewguy said:

What skins have negative values in them?

Skins use a ulong value, which only allows positive numbers.

Are you talking about item IDs?

Yes, the item ID of particular skins does not appear to work properly when they are a negative value

10 hours ago, Somescrub said:

Yes, the item ID of particular skins does not appear to work properly when they are a negative value

I am not following. Skins do not have negative values - they can't.

Item IDs, which is a number that represents the item itself (not the skin), does have negative values. Here is a link to item IDs.

Skins are always a positive value, because skins use a ulong, which can span from 0 to 18,446,744,073,709,551,615 and cannot be negative.

10 hours ago, imthenewguy said:

I am not following. Skins do not have negative values - they can't.

Item IDs, which is a number that represents the item itself (not the skin), does have negative values. Here is a link to item IDs.

Skins are always a positive value, because skins use a ulong, which can span from 0 to 18,446,744,073,709,551,615 and cannot be negative.

Sorry - you are correct... I had to revisit that for a moment as I was getting confused. In this particular instance I believe I was placing the item ID in the "skin" value for an item such as paper. Now that you say that it makes sense that it would not know what that number meant. I am assuming for items such as paper then, which have no skin ID, that the field would be left blank in the config to work properly then?

9 hours ago, Somescrub said:

Sorry - you are correct... I had to revisit that for a moment as I was getting confused. In this particular instance I believe I was placing the item ID in the "skin" value for an item such as paper. Now that you say that it makes sense that it would not know what that number meant. I am assuming for items such as paper then, which have no skin ID, that the field would be left blank in the config to work properly then?

You can apply a skin over the top of paper, so it has a different icon.

That is how the runes work - they use the blood item, but have custom skins thrown over the top, despite still being blood.

11 hours ago, imthenewguy said:

You can apply a skin over the top of paper, so it has a different icon.

That is how the runes work - they use the blood item, but have custom skins thrown over the top, despite still being blood.

 

 

yea I had tried that but for some reason the skins weren't loading in for me - as soon as I switched to horse dung the issue resolved itself, so I am making it work the same way but with dung instead.

1 hour ago, Somescrub said:

yea I had tried that but for some reason the skins weren't loading in for me - as soon as I switched to horse dung the issue resolved itself, so I am making it work the same way but with dung instead.

skins need to be 512x512

Changed Status from Pending to Closed