Broken as of latest FP Update

Clicking on the PortableLocker image ingame does nothing except fill my console with this. 

(23:42:48) | Failed to run command '/locker' on plugin 'PortableLocker'. (NullReferenceException: Object reference not set to an instance of an object)

at Oxide.Plugins.PortableLocker.GetContainer (System.UInt64 steamId) [0x00010] in <019cdcec1c0f4538b7fa15c567ea2183>:0

at Oxide.Plugins.PortableLocker.CreateLocker (System.UInt64 steamId, System.Boolean initial) [0x00052] in <019cdcec1c0f4538b7fa15c567ea2183>:0

at Oxide.Plugins.PortableLocker.OpenLocker (BasePlayer player, System.String[] args) [0x000bb] in <019cdcec1c0f4538b7fa15c567ea2183>:0

at Oxide.Plugins.PortableLocker.<InstallCommands>b__48_0 (BasePlayer player, System.String command, System.String[] args) [0x00000] in <019cdcec1c0f4538b7fa15c567ea2183>:0

at Oxide.Game.Rust.Libraries.Command+ChatCommand.HandleCommand (BasePlayer sender, System.String name, System.String[] args) [0x0001b] in <a619f13012af43f7b969eedf7eb2349b>:0

at Oxide.Game.Rust.Libraries.Command.HandleChatCommand (BasePlayer sender, System.String name, System.String[] args) [0x00015] in <a619f13012af43f7b969eedf7eb2349b>:0

at Oxide.Game.Rust.RustCore.TryRunPlayerCommand (BasePlayer basePlayer, System.String message, System.String commandPrefix) [0x000c2] in <a619f13012af43f7b969eedf7eb2349b>:0

I just unloaded/loaded and it produced the following:

(19:02:58) | [CSharp] Started Oxide.Compiler v1.0.32.0 successfully

(19:03:02) | PortableLocker was compiled successfully in 1627ms

(19:03:02) | Failed to call hook 'OnServerInitialized' on plugin 'PortableLocker v1.5.1' (NullReferenceException: Object reference not set to an instance of an object)

at Oxide.Plugins.PortableLocker.LoadContainer () [0x0006f] in <e8118d91fa8e4d7fa6fe0d9aa667164d>:0

at Oxide.Plugins.PortableLocker.OnServerInitialized () [0x0001e] in <e8118d91fa8e4d7fa6fe0d9aa667164d>:0

at Oxide.Plugins.PortableLocker.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x00142] in <e8118d91fa8e4d7fa6fe0d9aa667164d>:0

at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <42f9bedc659b4f4786eb778d3cd58968>:0

at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000de] in <15f61ddda771464d8246ebdce8ff4811>:0

at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <15f61ddda771464d8246ebdce8ff4811>:0

(19:03:02) | Loaded plugin PortableLocker v1.5.1 by Raul-Sorin Sorban

I backed up the data file, renamed, and started the plugin, looks like it's working, I'll watch it after my reboot.  Thanks for the prompt reply.

Cheers!

Ok, items that I put in my PortableLocker before a server reboot such as pistol ammo, medpens, and other stackables, no longer stack with items that were not in the PortableLocker, so there still appears to be a problem.

Thanks 

Ok, items that I put in my PortableLocker before a server reboot such as pistol ammo, medpens, and other stackables, no longer stack with items that were not in the PortableLocker, so there still appears to be a problem.

Thanks 

Any update on this. The current state change to stackable items left in the locker on a server reboot is a huge PITA for me.

Thanks

Still broken a week later, no update?

Thanks

Another week goes by, no response, plugin still for sale, plugin still broken.

Thanks.

can we get this update or what crazy raul slept on this?

and repair bench lets go baby!

And StaticTrader...

Any update on this?  Completely broken, still for sale.  this is beyond frustrating now, I reported this not working back on February 6th.

Thanks.

Same now..

This worked for me, please delete if not allowed.

 

Two changes:
Line 342-353 — Changed:
csharpvar temp = Pool.GetList<Item>();
temp.AddRange(Data.Container.ItemContainer.itemList);

foreach (var container in temp)
{
    if (ulong.TryParse(container.text, out var value) && !ServerWipePersistent(value))
    {
        Data.Container.ItemContainer.itemList.RemoveAll(x => x.text == container.text);
    }
}

Pool.FreeList(ref temp);
To:
csharpvar temp = new List<Item>(Data.Container.ItemContainer.itemList);

foreach (var container in temp)
{
    if (ulong.TryParse(container.text, out var value) && !ServerWipePersistent(value))
    {
        Data.Container.ItemContainer.itemList.RemoveAll(x => x.text == container.text);
    }
}
Line 672-680 — Changed:
csharpvar items = Pool.GetList<Item>();
items.AddRange(from.itemList);

foreach (var item in items)
{
    item.MoveToContainer(to, item.position, false, true);
}

Pool.FreeList(ref items);
To:
csharpvar items = new List<Item>(from.itemList);

foreach (var item in items)
{
    item.MoveToContainer(to, item.position, false, true);
}
Both just swap pooled lists for regular lists. Slightly more memory allocation but functionally identical.

@Markiii Really appreciate the attempt to help in the absence of support from the developer who should be providing support.

I made the changes, however my log reports : Error while compiling PortableLocker: 'Pool' does not contain a definition for 'FreeList' | Line: 353, Pos: 8

Which appears to refer to "Pool.FreeList(ref temp);" on Line 353, and there is reference to another "Pool.FreeList(ref items);"  on Line 683 that I believe will be a problem.

Thank you.

8 hours ago, Fusion 3.64 said:

@Markiii Really appreciate the attempt to help in the absence of support from the developer who should be providing support.

I made the changes, however my log reports : Error while compiling PortableLocker: 'Pool' does not contain a definition for 'FreeList' | Line: 353, Pos: 8

Which appears to refer to "Pool.FreeList(ref temp);" on Line 353, and there is reference to another "Pool.FreeList(ref items);"  on Line 683 that I believe will be a problem.

 

Thank you.

Find me on discord bro discord.gg/markiiirust i'll try and help x