BUG: after an upgrade the base becomes all in Twig

Hello
there are several of my players who after having done an upgrade via BetterTC, find the base completely in twig.
it happened to several players. Is there a way to fix this problem?
Thanks

Hi! Can you try to replicate and send a clip? Nobody has mentioned this problem before. Maybe you have some other plugin that blocks the improvement grades or something similar?

16 hours ago, ninco90 said:

Hi! Can you try to replicate and send a clip? Nobody has mentioned this problem before. Maybe you have some other plugin that blocks the improvement grades or something similar?

It happens randomly to various players and I don't know how to replicate it at the moment.
If I use the /up command (another plugin) everything updates without problems, with BetterTC it usually happens when upgrading in fragment or  HQ.

On 9/4/2024 at 6:41 PM, ninco90 said:

Hi! Can you try to replicate and send a clip? Nobody has mentioned this problem before. Maybe you have some other plugin that blocks the improvement grades or something similar?

just happened again. When you upgrade to metal, HQ stuff becomes twig

What build-affecting plugins do you have?

1.4.2

With the latest version I haven't had the chance to see if it still gives problems.

On 9/4/2024 at 11:41 AM, ninco90 said:

Hi! Can you try to replicate and send a clip? Nobody has mentioned this problem before. Maybe you have some other plugin that blocks the improvement grades or something similar?

I did report this issue before, but you insisted on a clip from me too: https://codefling.com/files/support/13569-upgrade-problem/

I couldn't easily reproduce it, so I couldn't send in a clip. But it did happen to us again a few weeks later. 

And sending a clip is just your way of saying you don't believe us. If we describe the steps that we took, what does a clip do other than prove it happened? Worry less about getting a clip and more about the report itself please.

4 minutes ago, dustyhansen said:

I did report this issue before, but you insisted on a clip from me too: https://codefling.com/files/support/13569-upgrade-problem/

I couldn't easily reproduce it, so I couldn't send in a clip. But it did happen to us again a few weeks later. 

And sending a clip is just your way of saying you don't believe us. If we describe the steps that we took, what does a clip do other than prove it happened? Worry less about getting a clip and more about the report itself please.

I confirm that this problem still persists...
In fact I will soon remove this plugin, which is only causing me problems and the seller does not care to find the cause!

I told him that it happens randomly, when some bases have metal and HQ pieces, and then you try to upgrade the base to HQ from the TC, the whole base becomes in twig.

I can't have clips since it happens randomly and the players do not make clips!

I will put 1 setella only because I can't put 0 stars as a review!

Hi both! The reason I need clips is to replicate the steps exactly and make it happen for me. If I can't get it to happen on my end I can hardly fix it.

Some things to keep in mind would be to check what other plugins might be interfering with the building system. Maybe it's some incompatibility that arises if another plugin exists and this encourages it to randomly spawn.

I can only say that after all the times I've tried and used this plugin I haven't been able to replicate this problem. At the same time all the builds revert to twig at the same time without slow progress (as happens when upgrading to another level) seems even more suspicious to me because there is no instant way to update the entire base for performance reasons. That's why there is a timer between actions.

I need details like the full list of plugins, to try to find out if there is a plugin that is interfering. Since this happens to both of you, it would be even more interesting to check what plugins you have in common and be able to review it.

Please understand that if I am not given a little more information, I have nothing to be able to replicate and work on.

@hansen polvoriento@Caja de escaldado

Ok so the video isn't going to show you how to replicate it. It is going to show us pushing a button and the base changing.

If we cannot reproduce the issue ourselves, I doubt you can reproduce it easily.

Nobody ever said the the entire base converts to twig at once. Mine converted piece by piece to twig.

I don't share my plugins for competitive reasons, but I do not have any that affect the building except for XBuildingSkinMenu which I was using at the time.

10 hours ago, dustyhansen said:

Ok so the video isn't going to show you how to replicate it. It is going to show us pushing a button and the base changing.

If we cannot reproduce the issue ourselves, I doubt you can reproduce it easily.

Nobody ever said the the entire base converts to twig at once. Mine converted piece by piece to twig.

I don't share my plugins for competitive reasons, but I do not have any that affect the building except for XBuildingSkinMenu which I was using at the time.

If you can share the list with me privately, type: plugins in the RCON console and all the names will appear.

I don't have XBuildingSkinMenu purchased, it's possible that this plugin performs some verification when trying to improve each building block and is the one that collaterally affects it. (It's possible, but I haven't seen its code or tested it)

Other plugins that may be conflicting are:
- EnhancedHammer
- Building Skins
- XPerience

3 hours ago, ninco90 said:

If you can share the list with me privately, type: plugins in the RCON console and all the names will appear.

I don't have XBuildingSkinMenu purchased, it's possible that this plugin performs some verification when trying to improve each building block and is the one that collaterally affects it. (It's possible, but I haven't seen its code or tested it)

Other plugins that may be conflicting are:
- EnhancedHammer
- Building Skins
- XPerience

Among the plugins you say can cause problems, I use BuildingSkin, which is my own version.
I don't see how BuildingSkin can cause conflicts, I checked the code again and it doesn't mofics any hooks related to the update of the grade of a building, but only color and skin.
In any case this problem doesn't always occur, but only when you upgrade from metal to HQ and you already have some pieces in HQ in the base, otherwise the problem doesn't occur, so immediately it's caused by BuildingSkin or one of the plugins listed.

In any case, I will have to remove BetterTC, every time this problem occurs, my players complain and I have to go and fix the base in person.

I will use a tool to do the upgrade, without going through TC

In the case of BuildingSkin, this plugin uses the hook OnStructureUpgrade, so every time a building block is updated, this hook is executed, which can change the grade and the building skin.

Please, I ask you for the complete list of plugins privately, as well as the other person. This will allow me to compare and see the plugins that affect the construction. This way, if another user has the same problem, I will also ask them for the list of plugins and I will be able to determine which are the conflicting plugins that may be causing this problem.

Once I have located the conflicting plugins, I will be able to contact the developers of said plugins to try to achieve a bypass so that they do not affect the changes that BetterTC makes.

I understand that it is frustrating not knowing what is happening and that it means spending time fixing this problem for the players. But the exact reason must be found and I am afraid that something is interfering in the process.

13 minutes ago, ninco90 said:

In the case of BuildingSkin, this plugin uses the hook OnStructureUpgrade, so every time a building block is updated, this hook is executed, which can change the grade and the building skin.

Please, I ask you for the complete list of plugins privately, as well as the other person. This will allow me to compare and see the plugins that affect the construction. This way, if another user has the same problem, I will also ask them for the list of plugins and I will be able to determine which are the conflicting plugins that may be causing this problem.

Once I have located the conflicting plugins, I will be able to contact the developers of said plugins to try to achieve a bypass so that they do not affect the changes that BetterTC makes.

I understand that it is frustrating not knowing what is happening and that it means spending time fixing this problem for the players. But the exact reason must be found and I am afraid that something is interfering in the process.

In my version of BuildingSkin, any changes are made in the next tick, and in any case it does not explain why it should interfere only in one case, if it were BuildingSkin, I would expect the problem at every update of the building grade.
Anyway now I send you the list of plugins

I appreciate the list of plugin names you use. I replied to you privately about it.

dustyhansen if you would be so kind as to do the same and provide me with the list of plugins you use privately I could analyze the plugins that can affect the buildings and compare with the other player's.

I will also be doing compatibility tests with Building Skins.

dm sent

Hi everyone! I just replicated the issue with BuildingSkin. This happens when the player has an upgrade set in Building Skin.

Because every time BetterTC upgrades a building block the OnStructureUpgrade code is executed, just as I imagined.

Here is the example:

Knowing this I will try to find a solution so that it does not happen, perhaps that BetterTC does not call that Hook if it finds any of the incompatible plugins loaded on the server.

11 minutes ago, ninco90 said:

Hi everyone! I just replicated the issue with BuildingSkin. This happens when the player has an upgrade set in Building Skin.

Because every time BetterTC upgrades a building block the OnStructureUpgrade code is executed, just as I imagined.

Here is the example:

 

 

Knowing this I will try to find a solution so that it does not happen, perhaps that BetterTC does not call that Hook if it finds any of the incompatible plugins loaded on the server.

 

Could BetterTC call a custom hook when it does an upgrade?
So other plugins can listen to this hook, and avoid interfering.

In any case it's still strange.
I also use the Building Grades plugin and do /up in all grades and I've never had problems, always with Building Skin enabled and also with BetterTC.

lastly, if you explain to me the procedure to replicate it, I'll try to modify building skin

I hadn't seen the video, I'll try to replicate the problem and see if I can find a solution to not interfere with building Skin with BetterTC.
What do you think about the hook?

I have good news. In the next update it will be fixed. I added an internal list of "incompatible" plugins that if detected will not call that Hook, preventing this problem from happening.

"BuildingSkin"
"BuildingSkins"
"XBuildingSkinMenu"

If in the future another plugin is found that interferes in the same way (using OnStructureUpgrade) it will be enough to add it to the list.

Thanks to both of you for your time and I hope that with this everything works great.

Regarding scalbox question I have checked and I see that BuildingGrades also calls OnStructureUpgrade, only when it is run by someone who does not have the BuildingGrades admin permission, maybe that is why it does not happen to you because I imagine that you have the admin permission. You would have to test if it also happens without admin permission and in that case add it to the list.

Regarding the procedure to replicate it:
Follow the steps I performed in the video. Yes, first clean the BuildingSkin Data folder, then reload the BuildingSkin plugin and don't configure anything. Try improving with betterTc as I did in the video and then once everything is improved and you see that it doesn't turn into sticks then activate BuildingSkin as I did.

9 minutes ago, ninco90 said:

I have good news. In the next update it will be fixed. I added an internal list of "incompatible" plugins that if detected will not call that Hook, preventing this problem from happening.

"BuildingSkin"
"BuildingSkins"
"XBuildingSkinMenu"

If in the future another plugin is found that interferes in the same way (using OnStructureUpgrade) it will be enough to add it to the list.

Thanks to both of you for your time and I hope that with this everything works great.

Regarding scalbox question I have checked and I see that BuildingGrades also calls OnStructureUpgrade, only when it is run by someone who does not have the BuildingGrades admin permission, maybe that is why it does not happen to you because I imagine that you have the admin permission. You would have to test if it also happens without admin permission and in that case add it to the list.

Regarding the procedure to replicate it:
Follow the steps I performed in the video. Yes, first clean the BuildingSkin Data folder, then reload the BuildingSkin plugin and don't configure anything. Try improving with betterTc as I did in the video and then once everything is improved and you see that it doesn't turn into sticks then activate BuildingSkin as I did.

ok I'll do some tests.
So from the next update, BetterTC will no longer upgrade the base if BuildingSkin is present?

5 minutes ago, Scalbox said:

ok I'll do some tests.
So from the next update, BetterTC will no longer upgrade the base if BuildingSkin is present?

Yes it will update it, but it will not send the hook to the rest of the plugins to check if it can update or not.

Changed Status from Pending to Work in Progress

Changed Fixed In to Next Version

1 hour ago, ninco90 said:

 

Yes it will update it, but it will not send the hook to the rest of the plugins to check if it can update or not.

Ok perfect, thanks for the support

Compile error after update

Error while compiling BetterTC: 'CuiRawImageComponent' does not contain a definition for 'SteamId' | Line: 2106, Pos: 69