Jump to content

CustomVendingSetup conflict

Closed 0.1.0 0.1.1

WouayNote2
WouayNote2

Posted (edited)

Hello IIIaKa,

I bought your plug-in two days ago.
Unfortunately, there is an issue when used with CustomVendingSetup plug-in (from uMod).
When an item is bought from a customized vending machine, that item does not move greatly in the vDelivery market place container.

Rust2024_01.28-12_15_43_00.png.0cb8c805802aef99f091dcfc6bde2075.png

After debugging, the issue is due to CustomVendingSetup that also tries to move the item in the container after vVending moved it.
A simple fix could consist in calling the "API_IsCustomized" hook provided by CustomVendingSetup plug-in in order to determine if the item should be moved by vVending or not.

I wonder if you will accept to change your code that way at line 709.

                        if (shopVending == null || CustomVendingSetup == null || !CustomVendingSetup.IsLoaded || !Convert.ToBoolean(CustomVendingSetup.Call("API_IsCustomized", shopVending)))
                        {
                            if (!item.MoveToContainer(targetContainer)) {
                                item.Drop(targetContainer.dropPosition, targetContainer.dropVelocity);
                            }
                            onItemPurchased?.Invoke(buyer, item);
                        }

Regards, WouayNote.

Edited by WouayNote2
  • Like 1
WouayNote2

Posted

There is also a boring warning message in logs :
"Could not find an item with the name scrap for user WouayNote with permission vDelivery.three. Using default fee settings."

I am using the default config file and so, already using the default fee.
Maybe you could remove it or modify the if clause in order to show it only when it is relevant?

IIIaKa

Posted

Hello, thank you for the offer. I've decided to simply disable the custom fee for the vending machines modified by the CustomVendingSetup plugin.

  • Like 1
IIIaKa

Posted

Changed Status from Pending to Closed

Changed Fixed In to 0.1.1

  • Like 1
1.4m

Downloads

Total number of downloads.

6.9k

Customers

Total customers served.

102.2k

Files Sold

Total number of files sold.

2m

Payments Processed

Total payments processed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.