Calling hook CanCombineDroppedItem resulted in a conflict

Hi,

im running in a conflict with bradleydrop plugin.

anmy idea how to fix it?

01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))
01:02 [Warning] Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: BradleyDrops - True (Boolean), Loottable (False (Boolean))

Please ask the developer of bradley drops to unsubscribe from stacking hooks when loottable is detected.

i get this feedback now:

The dev of Loottable plugin is incorrect, as per Oxide rules on writing code, hooks which return values of type object should only return true or null. Hooks which return values of type bool can return true, false or null. Therefore, the dev of Loottable plugin should correct their mistake.

I could unsubscribe from hooks, but if I had to consider this for every plugin just because the other dev coded incorrectly, then that could become an issue, and one which isn't my fault.

hi so any ideas?

Quote

The dev of Loottable plugin is incorrect, as per Oxide rules on writing code, hooks which return values of type object should only return true or null. Hooks which return values of type bool can return true, false or null. Therefore, the dev of Loottable plugin should correct their mistake.

This is not a mistake since the CanCombineDroppedItem hook is a boolean hook. Returning false instead of true will lead to different behavior. 

I contacted the developer of BradleyDrops. Hopefully this issue can be resolved soon.

Changed Status from Pending to Closed

Changed Fixed In to 1.0.34