Cant craft Industrial Recycler

Hello,

A NullReferenceException occurred when a player attempted to purchase an Industrial Recycler.

Plugin version:
IndustrialRecycler v1.8.94

Error:

Failed to call hook 'ConfirmPurchaseIndustrial' on plugin 'IndustrialRecycler v1.8.94' NullReferenceException: Object reference not set to an instance of an object

The stack trace points to the following methods:

IndustrialRecycler.RemoveItems(...) IndustrialRecycler.CheckAndRemoveBuyItems(...) IndustrialRecycler.ConfirmPurchaseIndustrial(...)

The Industrial Recycler purchase cost is currently configured with multiple item types:

Scrap: 1,000

High Quality Metal: 50

Metal Fragments: 1,000

The issue may be occurring while removing multiple required item types from the player's inventory.

In RemoveItems(), it appears that both player.inventory.Take(...) and item.Remove() are being called for the same item stack.

This may leave an invalid reference to an already removed item in the previously collected item list, which could then cause a NullReferenceException when item.info.shortname is accessed during the next iteration.

Could you please check this issue?

Thank you very much for your continued support.

Thank you for the detailed report. You were correct about the cause.

Both player.inventory.Take() and item.Remove() could affect the same stack, leaving an invalid item reference in the collected inventory list. I rewrote the purchase deduction process so it creates a removal plan first and then safely consumes each stack only once.

Purchases containing several different resource types, split stacks, or repeated cost entries are now handled correctly in version 1.9.0.

Changed Status from Pending to Fixed

Changed Fixed In to 1.9.0