Storage Adaptor Placement Bug

Line 8980 does not check if the entity is a miningquarry. Meaning you have to have more than 1 storage adapter to place it on anything. Required change attached.

fix-storage-adaptor-recycler.diff.txt

I don't add code written by others to my plugin!
Tell me the problem and I'll fix it, but your code is useless to me; I don't use other people's code.

So explain the problem in detail and I'll find a solution.

1 hour ago, Scalbox said:

I don't add code written by others to my plugin!
Tell me the problem and I'll fix it, but your code is useless to me; I don't use other people's code.

So explain the problem in detail and I'll find a solution.

 

I explained the problem and even pointed to the line of code you need to fix. If you chose to leave your plugin in a semi-broken state, that's up to you.

4 minutes ago, mecwerks said:

I explained the problem and even pointed to the line of code you need to fix. If you chose to leave your plugin in a semi-broken state, that's up to you.

The problem is that you always have to have 2 storage adapters to be able to place 1?

I'll do some tests and fix the problem, without using other people's code.

Not sure why the need to be rude about it. If you feel like writing a 2 line change a slightly different way to feel better about it then go for it. It's been a problem for 2 months now without a fix.

4 minutes ago, mecwerks said:

Not sure why the need to be rude about it. If you feel like writing a 2 line change a slightly different way to feel better about it then go for it. It's been a problem for 2 months now without a fix.

So
1) I'm not modifying the plugin by changing two lines of code, "but look at the plugin in general to see if I can do this part better," I'm not just making a two-line change...

2) The license doesn't give you any permission to modify the plugin!

3) Has the problem been around for two months? Okay, fine, you just reported it now; no one reported it before, so you could have reported it two months ago. Don't complain if you only reported it now.

I'll do some testing and find the best solution to fix the problem.

8 minutes ago, Scalbox said:

So
1) I'm not modifying the plugin by changing two lines of code, "but look at the plugin in general to see if I can do this part better," I'm not just making a two-line change...

2) The license doesn't give you any permission to modify the plugin!

3) Has the problem been around for two months? Okay, fine, you just reported it now; no one reported it before, so you could have reported it two months ago. Don't complain if you only reported it now.

I'll do some testing and find the best solution to fix the problem.

1) The problem is only in one place, you just need to check if the entity is a quarry or not.
2) If its broken, im going to patch it so its not broken, That's the magic of c# scripts.
3) This issue has been reported by someone else, this was 2 months ago.

https://codefling.com/files/support/28809-cannot-place-storage-adapters/

5 minutes ago, mecwerks said:

So
1) I'm not modifying the plugin by changing two lines of code, "but look at the plugin in general to see if I can do this part better," I'm not just making a two-line change...

2) The license doesn't give you any permission to modify the plugin!

3) Has the problem been around for two months? Okay, fine, you just reported it now; no one reported it before, so you could have reported it two months ago. Don't complain if you only reported it now.

https://codefling.com/files/support/28809-cannot-place-storage-adapters/

You didn't read the ticket carefully. That ticket has been resolved and fixed, it has nothing to do with what you're saying!

I'll run some tests and fix the plugin. I don't need people to fix plugins for me.

Next time, just report the problem you're having and I'll take care of the rest.

The plugin will be fixed by tomorrow

1 minute ago, Scalbox said:

You didn't read the ticket carefully. That ticket has been resolved and fixed, it has nothing to do with what you're saying!

I'll run some tests and fix the plugin. I don't need people to fix plugins for me.

Next time, just report the problem you're having and I'll take care of the rest.

It was fixed from him picking it up and replacing it. I.e. when he picked it up, he then had 2 storage adapters and the placement worked fine. it's the exact same issue here.

Being hostile towards someone trying to help you fix a persistent issue is unnecessary. I've explained the issue. Will not be buying again.

Just now, mecwerks said:

It was fixed from him picking it up and replacing it. I.e. when he picked it up, he then had 2 storage adapters and the placement worked fine. it's the exact same issue here.

Being hostile towards someone trying to help you fix a persistent issue is unnecessary. I've explained the issue. Will not be buying again.

ok
 

The plugin will be fixed by tomorrow