Check performance after last update

Hey,

Could you check performance after latest plugin update and see if something can be optimized?
Previously largest dungeons had like 30-40ms Hook time, now in 3.9.6 - it's like 70-80.

Players can feel more lag and I see lower FPS.

Is that indended? anything can be done about that?

Thanks for flagging this. The increase wasn't intended.

I traced the regression to a couple of paths that scaled badly on the larger dungeons. Dungeon entity checks were walking through the full entity collections from frequently called hooks, and the dungeon cache was being read and rewritten for every spawned entity. With a large dungeon and several active NPCs/turrets, that adds up quickly.

I've reworked the entity lookups to use a Network ID index, changed the runtime collections to faster hash lookups, batched the cache writes, reduced a few overly aggressive AI/turret update rates, and staggered NPC/animal updates so they don't all run on the same frame.

This should take a good amount of pressure off the larger tiers without changing the intended combat behavior. If you get a chance to profile one of the largest dungeons again after the update, I'd be interested in seeing how it compares with the 70-80 ms result you were getting.

Changed Status from Pending to Fixed

Changed Fixed In to 3.10.0

@Martian
Hook times improved signigicantly to around 1-2ms for the largest dungeon spawn.

However there is still noticeable FPS drop during the spawn itself - I believe that could be due to spawning of the building blocks in too large batches or something?

It's similar to what I saw on large RaidBases before tweaking batch size for CopyPaste plugin.

What reduced the spike significantly in case of CopyPaste/RaidableBases bases was the entity count per batch, which was reduced from 10 to 1.  Not sure if something similar applies to your plugin as well...