Player error / Diconnect

Hi,
With the plugin active, when searching for blueprints, the player sometimes disconnects:

1) If I search for something, close and reopen the search bench, I get disconnected.

2) If I remove and re-insert the blueprint from the search bench, I get disconnected.

A video example is below.
 

ERROR

 

Object reference not set to an instance of an object.
  at PlayerBlueprints.%9237be1a4ff964d9bfd38648d4c90626b9268caa (ItemDefinition %b15935095294cb22d4a0694a1d08d91570bfd89f) [0x00000] in <00000000000000000000000000000000>:0 
  at BlueprintInformationPanel.%7d6be0f8e1c2295928b7616625b4599577bc7c8e (ItemDefinition %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4, %f36882d6bc8f1e1e12e7d9bb91afee6aed22f1eb %623575e6a234818eee1ac65b75017f085189900c) [0x00000] in <00000000000000000000000000000000>:0 
  at SelectedItem.%63b99fdb2c5839654a413aa52f701309e16d7b1d (%f36882d6bc8f1e1e12e7d9bb91afee6aed22f1eb %623575e6a234818eee1ac65b75017f085189900c) [0x00000] in <00000000000000000000000000000000>:0 
  at %8d1174ebeefbf913b690bf3b5028ca94382afd3a.%065255ca21df58ee9afa9c615cbc70620c1b57a1 () [0x00000] in <00000000000000000000000000000000>:0 
  at PlayerInventory.%ff58fbfb26ad76520633beff9652ffeba8456b95 (%5ea4cece6a5b973102590f9f5103ce4404b005d4 %8464c6001bf57f267f28d399022c4b6f943ff470) [0x00000] in <00000000000000000000000000000000>:0 
  at BasePlayer.%ff58fbfb26ad76520633beff9652ffeba8456b95 (BaseNetworkable+%ba1443bf1ac854716c0ad9e557cb899150c94b26 %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4) [0x00000] in <00000000000000000000000000000000>:0 
  at BaseNetworkable.%8e59442dbceba2632162bea20d1ecc036fbbd7f7 (%16c5baa88dc5b59514d95cfc226e6eb8c2904c6a %99627a0ce2a955e79d006f95ec3ed8a1b92ddf31) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%4d630c04c19f11d5b6003c69de47ac685d7b56ae (%16c5baa88dc5b59514d95cfc226e6eb8c2904c6a %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4, System.Int64 %7aab190c1c7731cfadd8a19ddf68bd2813ded19f) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%3c7e2439872ee0fe87e8e2bb4c0969e1531ffea9 (%8345e4eb74703cc13a1210c7d9654849cce19bec %f8ed99f0f93a0761349de3a4aab97a9b1351ef85) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%b77a35615632e2187ec8640cc73471a79dd3e8b9 (%8345e4eb74703cc13a1210c7d9654849cce19bec %f8ed99f0f93a0761349de3a4aab97a9b1351ef85) [0x00000] in <00000000000000000000000000000000>:0 
  at %b739cfb95fb91c0fec877a6d255b49c0346f162d.%b61a4a4ded0c51356101f6579ab3899adac2d6b9 (%618e541e20c9d6ef8dbe09bff00ca7756498aa3f %c9413a7f6e99402ef53f1418aa702d3466cc7738) [0x00000] in <00000000000000000000000000000000>:0 
  at %992da90bf8032cecb801115864fca6b01e4d9fc9.%9b59e6a0a07b5131a1e9b7f7f46f9ead625ef814 () [0x00000] in <00000000000000000000000000000000>:0 
  at Client.Update () [0x00000] in <00000000000000000000000000000000>:0 

5 hours ago, Scalbox said:

Hi,
With the plugin active, when searching for blueprints, the player sometimes disconnects:

1) If I search for something, close and reopen the search bench, I get disconnected.

2) If I remove and re-insert the blueprint from the search bench, I get disconnected.

A video example is below.
 

ERROR

 

Object reference not set to an instance of an object.
  at PlayerBlueprints.%9237be1a4ff964d9bfd38648d4c90626b9268caa (ItemDefinition %b15935095294cb22d4a0694a1d08d91570bfd89f) [0x00000] in <00000000000000000000000000000000>:0 
  at BlueprintInformationPanel.%7d6be0f8e1c2295928b7616625b4599577bc7c8e (ItemDefinition %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4, %f36882d6bc8f1e1e12e7d9bb91afee6aed22f1eb %623575e6a234818eee1ac65b75017f085189900c) [0x00000] in <00000000000000000000000000000000>:0 
  at SelectedItem.%63b99fdb2c5839654a413aa52f701309e16d7b1d (%f36882d6bc8f1e1e12e7d9bb91afee6aed22f1eb %623575e6a234818eee1ac65b75017f085189900c) [0x00000] in <00000000000000000000000000000000>:0 
  at %8d1174ebeefbf913b690bf3b5028ca94382afd3a.%065255ca21df58ee9afa9c615cbc70620c1b57a1 () [0x00000] in <00000000000000000000000000000000>:0 
  at PlayerInventory.%ff58fbfb26ad76520633beff9652ffeba8456b95 (%5ea4cece6a5b973102590f9f5103ce4404b005d4 %8464c6001bf57f267f28d399022c4b6f943ff470) [0x00000] in <00000000000000000000000000000000>:0 
  at BasePlayer.%ff58fbfb26ad76520633beff9652ffeba8456b95 (BaseNetworkable+%ba1443bf1ac854716c0ad9e557cb899150c94b26 %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4) [0x00000] in <00000000000000000000000000000000>:0 
  at BaseNetworkable.%8e59442dbceba2632162bea20d1ecc036fbbd7f7 (%16c5baa88dc5b59514d95cfc226e6eb8c2904c6a %99627a0ce2a955e79d006f95ec3ed8a1b92ddf31) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%4d630c04c19f11d5b6003c69de47ac685d7b56ae (%16c5baa88dc5b59514d95cfc226e6eb8c2904c6a %3780bf7afb993c8ab2b6ab182a89217c1ad6b6b4, System.Int64 %7aab190c1c7731cfadd8a19ddf68bd2813ded19f) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%3c7e2439872ee0fe87e8e2bb4c0969e1531ffea9 (%8345e4eb74703cc13a1210c7d9654849cce19bec %f8ed99f0f93a0761349de3a4aab97a9b1351ef85) [0x00000] in <00000000000000000000000000000000>:0 
  at Client.%b77a35615632e2187ec8640cc73471a79dd3e8b9 (%8345e4eb74703cc13a1210c7d9654849cce19bec %f8ed99f0f93a0761349de3a4aab97a9b1351ef85) [0x00000] in <00000000000000000000000000000000>:0 
  at %b739cfb95fb91c0fec877a6d255b49c0346f162d.%b61a4a4ded0c51356101f6579ab3899adac2d6b9 (%618e541e20c9d6ef8dbe09bff00ca7756498aa3f %c9413a7f6e99402ef53f1418aa702d3466cc7738) [0x00000] in <00000000000000000000000000000000>:0 
  at %992da90bf8032cecb801115864fca6b01e4d9fc9.%9b59e6a0a07b5131a1e9b7f7f46f9ead625ef814 () [0x00000] in <00000000000000000000000000000000>:0 
  at Client.Update () [0x00000] in <00000000000000000000000000000000>:0 

 

Gotcha, it's probably best to disable the plugin until I can issue a fix.

Changed Status from Pending to Work in Progress

Changed Fixed In to Next Version

hi

any news?

Thanks

.

.

sorry for this messesage, is error

I should have fixed the problem, and it involves the ItemRetriver plugin.
I made a change that fixes the problem. I'll send you everything soon. I'm finishing the final tests.

Hi,
This is the plugin with my changes to exclude blueprints from the custom network update.
With this change, everything seems to work now. I've also implemented a cache for ItemDefinitions. I'm still testing to make sure everything works properly.

If you'd like to take a look at the changes I made and see if they work, we can ask the ItemRetriever plugin author if he can merge these changes into his plugin.

Thanks

ItemRetriever.cs

Apologies for the late response. I attempted to debug the issue, but wasn't able to finish before I was relocated out of country. I couldn't remote into my machine due to the lack of Google services.

I have informed WhiteThunder (the developer of ItemRetriever) of the issue and linked your fix so he has an easy time looking into the issue.

You can see my post here to WhiteThunder:
https://umod.org/community/item-retriever/57739-player-disconnect?page=1#post-2

Since this fix is contained within ItemRetriever, we should wait for him to update it or respond.

Thank you.

The problem with the fix still occurs in certain cases.
It's much less than before, but it still happens every now and then.

12 hours ago, Scalbox said:

The problem with the fix still occurs in certain cases.
It's much less than before, but it still happens every now and then.

 

Plugin updated, please let me know if you find any further ways to produce the bug.

Due to the nature of this bug, I'm going to leave this thread as "Work In Progress" until we can be confident it is gone.

I'm marking this issue as resolved, as it occurs randomly and under specific circumstances.

The only thing is, the latest SuperCrafter update has caused the issue to recur for every blueprint learned.

9 hours ago, Scalbox said:

I'm marking this issue as resolved, as it occurs randomly and under specific circumstances.

The only thing is, the latest SuperCrafter update has caused the issue to recur for every blueprint learned.

Please provide steps to reproduce this issue. I'm not experiencing any issues with the latest version of ItemRetriever + SuperCrafter.
Video recordings are very nice, but helpful steps are great as well.

Both ItemRetriever + SuperCrafter are ignoring blueprints, but something else may be causing the issue.

As you can see in the video, the latest version of the SuperCraft plugin still causes the problem.

At one point in the video (minute 4:26), I reinstalled the old version of the plugin, and it works fine, except in a few random cases.
 

17 hours ago, Scalbox said:

As you can see in the video, the latest version of the SuperCraft plugin still causes the problem.

At one point in the video (minute 4:26), I reinstalled the old version of the plugin, and it works fine, except in a few random cases.
 

1)
I've repeated the research for a few items you've shown here. I did not encounter a crash or disconnect.
My recorded videos (3 videos) - https://drive.google.com/drive/folders/1fgjpgpLVnVK_OGDF_ZUPJcpSa57Bp311?usp=sharing

2)
I had another customer @beetle follow your video with the following version numbers. He was able to reproduce your bug. You are not alone.
["SuperCrafter" "1.4.3")]
["Item Retriever" "0.7.6")]

3)
Could you run this command: "plugins" in your server console and give me the output in a .txt file?
I am wondering if it is a plugin-conflict issue. I would like to compare your plugin list with @beetle to narrow down the issue.

For instance, here is my plugin list for my test server:

   ComposterMaster       Vergbergler       v1.0.9   32ms       169,016     76.0kb                                  1293ms [96ms]   44m5s
   DropStopper           Vergbergler       v1.2.2   6ms        58          124.0kb                                 146ms [1136ms]  44m5s
   InstantScubaDiver     Vergbergler       v1.1.5   3ms        265         4.0kb                                   75ms [13ms]     44m5s
   Item Retriever        WhiteThunder      v0.7.6   67ms       23,708      132.0kb                                 195ms [35ms]    44m5s
   PermissionsManager    Steenamaroo       v2.0.9   1ms        14          836.0kb                                 274ms [49ms]    44m5s
   SuperCrafter          Vergbergler       v1.4.3   245ms      380         408.0kb                                 173ms [39ms]    44m5s
   Vanish                Whispers88        v2.0.5   1ms        896         264.0kb                                 158ms [37ms]    44m5s

Let's get this fixed ASAP! Would you like to connect on Discord? My Discord username: @Vergbergler

@Scalbox Could I get a list of plugins from your server via Discord?