Performance Risks Detected in RaidProtection Plugin

[15:22:37] > Unloaded plugin RaidProtection v3.4.6 by mr01sam
[15:22:37] >  Warning! 'RaidProtection' uses UnityEngine.GameObject.FindObjectsOfType. That may cause significant performance drops, and/or server stalls. Report to the developer or use at your own discretion!
[15:22:40] > Loaded plugin RaidProtection v3.4.6 by mr01sam [1238ms]


[15:19:59] > [RaidProtection] Timer 1s has failed: (Object reference not set to an instance of an object.)
   at void Oxide.Plugins.RaidProtection+ProtectedEntity.SetBaseEntity(BaseEntity entity) in C:/rustserver2023/carbon/plugins/RaidProtection.cs:line 3560
   at ProtectedEntity Oxide.Plugins.RaidProtection+ProtectedCupboardManager.Transfer(ProtectedEntity oldTc, BaseEntity newEntity) in C:/rustserver2023/carbon/plugins/RaidProtection.cs:line 2785
   at void Oxide.Plugins.RaidProtection.OnEntitySpawned(BuildingPrivlidge priv)+() => { } [1] in C:/rustserver2023/carbon/plugins/RaidProtection.cs:line 3830
   at Timer Oxide.Plugins.Timers.In(float time, Action action)+() => { } in D:/a/Carbon/Carbon/Carbon.Core/Carbon.Components/Carbon.Common/src/Oxide/Libraries/Timer.cs:line 55
[15:20:00] > [RaidProtection] Timer 1s has failed: (Object reference not set to an instance of an object)
   at ProtectedEntity Oxide.Plugins.RaidProtection+ProtectedCupboardManager.Transfer(ProtectedEntity oldTc, BaseEntity newEntity) in C:/rustserver2023/carbon/plugins/RaidProtection.cs:line 2785
   at void Oxide.Plugins.RaidProtection.OnEntitySpawned(BuildingPrivlidge priv)+() => { } [1] in C:/rustserver2023/carbon/plugins/RaidProtection.cs:line 3830
   at Timer Oxide.Plugins.Timers.In(float time, Action action)+() => { } in D:/a/Carbon/Carbon/Carbon.Core/Carbon.Components/Carbon.Common/src/Oxide/Libraries/Timer.cs:line 55
 

That performance warning comes from carbon and it can be ignored because it's being used appropriately here. Raid Protection needs to query all cupboards on the server in order to track them, but it only does this on plugin load, so it's not a concern.

Changed Status from Pending to Closed