mlrs hurts players inside raidable base

I have the pvp turned off in the config, and even the raid being rocketed is pve, a player (me) can shoot mlrs into a raid base that is not owned by me, that is being raided my another player. it damages the base, but also hurts players inside the base. Is this something you can fix?

In my mind the checks would check for pvp enabled, if not, then dont damage players with mlrs, anywhere, even inside a raidable base (with the rb plugin).

This also allows damaging a raid that does not belong to me, which is ok i guess, its helping but not when it also kills the people that are doing the raid, in a pve server

here is the config in case your going to ask

{
  "MLRS Settings": {
    "MLRS Damage Modifier": 1.0,
    "Allow Damage to Player Built Bases": false,
    "Allow Damage to Players": false,
    "Allow Damage to Raidable and Abandoned Bases": true,
    "Allow Damage to NPCs": true,
    "MLRS Cooldown time (in minutes)": 10.0,
    "Total Rockets for MLRS to fire": 12,
    "Rocket Launch Interval (in seconds)": 1.0,
    "Requires Aiming Module": true
  }
}

I'll take a look. I can go through the RaidableBases plugin and work on an update for MLRSDamage that integrates better with it. When I first coded all of it, it was when MLRS was new and RaidableBases hadn't addressed it yet, so there integration wasn't possible at the time.

Inside of MLRSDamage, the line for "Allow Damage to Raidable and Abandoned Bases" just checks to see if the building blocks being damaged have an ownership of "0". This is regardless of who "owns" the raid, for those PVE raids, where you don't want someone else doing damage to the base. This is what I can work on to integrate with RaidableBases.

It does the other checks however. So if Damage to Players is off, then maybe the line in the RaidableBase profile "Allow Players To Use MLRS" is somehow overriding it and allowing player damage.

But first, maybe see if setting "Allow Players To Use MLRS" to false in your RaidableBases profiles fixes the issue? I'll work with the author of RaidableBases to see where conflicts may be coming up, but theoretically, if MLRSDamage has Allow Damage to Players as false, but players are taking damage, then some other plugin must be overriding MLRSDamage.

Changed Status from Pending to Work in Progress

this setting was set to true, ill set it to false, though that seems wrong to change it to false.

Ill change it to false and see what happens.

"Allow Players To Use MLRS": true,

worst case i can see about putting the mlrs into truepve as not to hurt players