Trade Request Issue

Hi,
when typing /trade, the plugin appears to respond in chat. However, when typing /trade PlayerName, it seems the trade request is not being sent. Could you please check this?

Hi, I checked this before releasing the update the other day and it worked fine, nothing I changed should've had any effect either. Are you able to provide screenshots of this behaviour so I can understand the problem better? Thanks.

34 minutes ago, Tom.bat said:

Hi, I checked this before releasing the update the other day and it worked fine, nothing I changed should've had any effect either. Are you able to provide screenshots of this behaviour so I can understand the problem better? Thanks.

Hello, providing a screenshot probably would not help much because when I type /trade playername, nothing appears in the chat. My players reported this to me first, and then I tested it myself. It looks like there is indeed an issue. I even removed version 1.1.17 and reinstalled 1.1.16 on one of our other servers for testing, but the trade request still did not go through. There was also nothing in the RCON logs.

Is there anything else I can help you with, or any additional information you would like me to provide so you can better understand the issue?

Try disabling any integrations you're using and see if that has any effect, I'm still unable to reproduce this so any information you have would be much appreciated.

2 hours ago, Tom.bat said:

Try disabling any integrations you're using and see if that has any effect, I'm still unable to reproduce this so any information you have would be much appreciated.

Hi, while sending a trade request to another player using /trade, I just noticed the following log.
 

(18:44:10) | Failed executing chat command 'trade' in 'WTrading v1.1.17 by Tom.bat' [callback] (Object reference not set to an instance of an object)

at bool Oxide.Plugins.WTrading+Command.CanPlayersTrade(TradePlayer caller, TradePlayer target) in /home/rustserver/serverfiles/carbon/plugins/WTrading.cs:line 2127

at void Oxide.Plugins.WTrading+TradeCommand.Execute(TradePlayer caller, string[] arguments) in /home/rustserver/serverfiles/carbon/plugins/WTrading.cs:line 1966

at void Oxide.Plugins.WTrading.CommandHandler(BasePlayer player, string name, string[] arguments) in /home/rustserver/serverfiles/carbon/plugins/WTrading.cs:line 206

at void Oxide.Game.Rust.Libraries.Command.AddChatCommand(string command, BaseHookable plugin, Action<BasePlayer, string, string[]> callback, string help, object reference, string[] permissions, string[] groups, int authLevel, int cooldown, bool isHidden, bool protected, bool silent, bool doCooldownPenalty)+(Args arg) => { } in /home/runner/work/Carbon/Carbon/src/Carbon.Components/Carbon.Common/src/Oxide/Command.cs:line 103

The issue seems to be resolved after I deleted the config and generated a new default one. It was probably caused by these settings:

"swim_block": false,
"fly_block": false,
"sit_block": false,

The plugin may not have automatically added these settings to the existing config, so that might have been the cause of the problem.
I hope it will be an easy solution for both you and the other servers as well. Thank you for your help.


My config:

{
  "request_repeats": 2,
  "request_timeout": 60.0,
  "accept_delay": 0.5,
  "trade_cooldowns": {
    "default": 320
  },
  "cancel_cooldown": 10,
  "daily_limits": {
    "default": -1
  },
  "daily_limit_creator_only": false,
  "slot_limits": {
    "default": 12
  },
  "chat_prefix": "[Trading]",
  "chat_profile": "",
  "onscreen_notifications": {
    "enabled": false,
    "anchor": {
      "x": 0.5,
      "y": 0.0
    },
    "offset": {
      "x": 0.0,
      "y": 180.0
    }
  },
  "player_list": {
    "enabled": false,
    "anchor": {
      "x": 0.5,
      "y": 0.5
    },
    "offset": {
      "x": 0.0,
      "y": 0.0
    },
    "hidden_players": []
  },
  "sound_notifications": true,
  "sound_effects": {
    "request_sent": "",
    "request_received": "assets/bundled/prefabs/fx/invite_notice.prefab",
    "request_accepted": "assets/prefabs/deployable/locker/effects/locker-deploy.prefab",
    "request_declined": "",
    "trade_opened": "assets/prefabs/building/wall.frame.shopfront/effects/metal_transaction_complete.prefab",
    "trade_cancelled": "",
    "trade_completed": "assets/prefabs/deployable/locker/effects/locker-deploy.prefab"
  },
  "building_block": true,
  "require_building_auth": false,
  "minimum_distance": -1.0,
  "maximum_distance": -1.0,
  "fee": 1.0,
  "fee_per_metre": 0.0,
  "refunds": false,
  "item_blacklist": [],
  "integrations": {
    "temp_ids": false,
    "ui_notify": false,
    "block_users": true,
    "ignore": false,
    "afk_api": false,
    "no_escape": {
      "raid_block": true,
      "combat_block": true
    },
    "server_rewards": false,
    "economics": false,
    "clans": {
      "enabled": false,
      "fee_discount": 0.0,
      "no_limits": true,
      "cooldown_multiplier": 0.8
    }
  },
  "file_logging": false,
  "console_logging": false,
  "discord_webhook": {
    "enabled": false,
    "url": "",
    "username": "WTrading",
    "avatar_url": "",
    "embed_color": 5793266,
    "server_name": "Server 1"
  }
}

That's almost certainly the problem, I'm glad you managed to fix it. WTrading doesn't have any mechanism for auto updating the config as of yet so that's something I'll put on my list of things to add in the future.

Changed Status from Pending to Not a Bug

Changed Status from Not a Bug to Closed