Jump to content

Config path broken if using non-default locations

Work in Progress 1.0.5 Next Version

BB1984

Posted

The new config path code in version 1.0.5 fails if "+oxide.directory" is used to keep the oxide folder anywhere but the server root. I assume the Carbon switches that provide the same functionality would also break it but have not tested that.

Khan

Posted

Why wouldn't the oxide folder be in the rust folder directory? 

That would break more then just mine if you moved it outside of the rust folder.
image.png.b57b8aa38cc7027010828cc312ba697e.png

Khan

Posted (edited)

I'm sorry but your going to have to show me how you have your file directories setup.

Edited by Khan
Khan

Posted

Changed Status from Pending to Not a Bug

BB1984

Posted

From the bit of searching I did, having the oxide folder at server identity level is not particularly uncommon and is exactly the use for that switch. It breaks nothing that was written correctly, although with the Oxide sandbox having been removed relatively recently, I suppose there could be some other code out there now using System.IO and making assumptions about the config file location. Anyway, I thought perhaps it was something you forgot was an option and might want to know was an issue, but if not, perhaps it'd be good if you put a notice somewhere that this plugin only works when Oxide or Carbon is in the default install location.

Khan

Posted (edited)

I don't understand why it wouldn't be. You've provided no context or reason for it to not be where it's provided by default.

All you have done is report a problem that to me simply isn't an issue. 

Moving forward all future plugin updates of mine will be using the same config get/save methods.

 

You haven't even explained why yours isn't in the default location or bothered to show where you've moved it to either.

I have well over 500 users and frankly you are the only one to have an issue with this.

Edited by Khan
BB1984

Posted

My oxide folder is at server identity level, as I said: "root/server/<identity>/oxide/config" for the config files. Perhaps none of your other 500 users use the "+oxide.directory" switch or Carbon's "-carbon.configdir"; if so, lucky you. In any case, your code is making assumptions and you will hear from others eventually. Good day.

Khan

Posted

Christ all you had todo was state your running a multi-server instance under the same root directory or show this > "root/server/<identity>/oxide/config". As I had asked for after your first post.
Easy enough fix.

You made it sound like you had moved the oxide folder out of the root directory.
As long as it's still in the main directory and simply split between instances that should be fix-able.

BB1984

Posted

I apologize. I could have been a little clearer up front but I assumed you knew or could easily see what the +oxide.directory switch did.

Khan

Posted

I'll be updating the plugin to simply grab the directory straight from the DLL source its loaded from Interface.Oxide.ConfigDirectory

This will prevent any future problems ( same with carbon ).

Since that will pull the directory for that specific instance running. ( Should prevent future issues )

image.png.a353d317f00eeb669ddf818bce382d13.png

For now you can just change "oxide" to Interface.Oxide.ConfigDirectory ( without the string quotes " " )

  • Like 1
Khan

Posted

Changed Status from Not a Bug to Work in Progress

Changed Fixed In to Next Version

1.7m

Downloads

Total number of downloads.

8k

Customers

Total customers served.

121.2k

Files Sold

Total number of files sold.

2.5m

Payments Processed

Total payments processed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.