Addressing performance issue

This plugin, on my server running 90+ other plugins, is the 3rd laggiest.

https://prnt.sc/MZVo1CAgWVH-
https://prnt.sc/22H04yFgAnzA

There are 13 of these placed on the map, as they're restricted to VIPs only and only some have deployed this item. I don't understand why the mod is consuming so many resources for what seems like a relatively light plugin.

Would appreciate a look into the coding again, as per your DM, it's been a bit since you reviewed the mod. Performance aside, i'm very happy with everything. But with the performance issue, its causing a lot more drag than I expected and is a bit of a concern of whether to continue to use it or not.

On 2/24/2025 at 2:05 AM, Kreavles said:

This plugin, on my server running 90+ other plugins, is the 3rd laggiest.

https://prnt.sc/MZVo1CAgWVH-
https://prnt.sc/22H04yFgAnzA

There are 13 of these placed on the map, as they're restricted to VIPs only and only some have deployed this item. I don't understand why the mod is consuming so many resources for what seems like a relatively light plugin.

Would appreciate a look into the coding again, as per your DM, it's been a bit since you reviewed the mod. Performance aside, i'm very happy with everything. But with the performance issue, its causing a lot more drag than I expected and is a bit of a concern of whether to continue to use it or not.

Thanks for reporting this here so I can keep track of it. As I mentioned, those hook times are tiny over the whole period the server is up. The only heavy load the plugin does is during the load or unload of the plugin, but I will definitely have a look over it and see if there are any improvements to be had. But honestly, people can get too hung up on hook times or misinterpret them. If I saw hook times like that on our servers I wouldn't bat an eyelid over it, its tiny. I'll update when I have more info though.

On 2/24/2025 at 2:05 AM, Kreavles said:

This plugin, on my server running 90+ other plugins, is the 3rd laggiest.

https://prnt.sc/MZVo1CAgWVH-
https://prnt.sc/22H04yFgAnzA

There are 13 of these placed on the map, as they're restricted to VIPs only and only some have deployed this item. I don't understand why the mod is consuming so many resources for what seems like a relatively light plugin.

Would appreciate a look into the coding again, as per your DM, it's been a bit since you reviewed the mod. Performance aside, i'm very happy with everything. But with the performance issue, its causing a lot more drag than I expected and is a bit of a concern of whether to continue to use it or not.

lmfao - this isn't hitting hard at all! This is GREAT performance, you need to understand hooktimes before he re-writes any code...

13 hours ago, Markiii said:

lmfao - this isn't hitting hard at all! This is GREAT performance, you need to understand hooktimes before he re-writes any code...

I don't pretend to have great knowledge over this, i've only just begun to dive deep into performance and how to squeeze every ounce of fps I can out of my server.

Based on my knowledge, there is a consistent drag throughout the day coming from this plugin. It has more draw that 85+ other plugins im running, and I believe there is room for improvement. Doesn't hurt to reach out and ask.

There is another similar plugin to this one currently running, that allows players to place special deployables on the map. It used to have hook times close to this plugin, and after speaking with the dev and a review of the code, he was able to drop hook times by 98%. If there is a chance that this plugin could see the same performance gain, it would make my day and help a lot towards creating a highly modded, good performant server.

This is 10 hours worth of tracking, starting from the moment the server fired up. There doesn't appear to be any heavy load during startup and is pretty consistent throughout the day https://prnt.sc/xajJAwrYUMNF
 

On 2/28/2025 at 3:28 AM, Kreavles said:

I don't pretend to have great knowledge over this, i've only just begun to dive deep into performance and how to squeeze every ounce of fps I can out of my server.

Based on my knowledge, there is a consistent drag throughout the day coming from this plugin. It has more draw that 85+ other plugins im running, and I believe there is room for improvement. Doesn't hurt to reach out and ask.

There is another similar plugin to this one currently running, that allows players to place special deployables on the map. It used to have hook times close to this plugin, and after speaking with the dev and a review of the code, he was able to drop hook times by 98%. If there is a chance that this plugin could see the same performance gain, it would make my day and help a lot towards creating a highly modded, good performant server.

This is 10 hours worth of tracking, starting from the moment the server fired up. There doesn't appear to be any heavy load during startup and is pretty consistent throughout the day https://prnt.sc/xajJAwrYUMNF
 

I have had a brief look and I will maybe make a couple changes, but honestly we are splitting hairs here, the plugin is performant as it is. As I said, the only heavier load is when the plugin loads and unloads. But I had already mitigated this by running those parts of code asynchronously. This means that part of code runs independently, on another thread if you like, while the main thread continues and doesn't "lag" or hold up the server.

2.1 seconds hook time over 10 hours is really insignificant and nothing to worry about. I understand you want the best performance, but I think you are getting too hung up on hook times without understanding it fully, which there is nothing wrong with. Plenty other server owners make this mistake, myself too when I started out. Are there any issues with your server that is making you look to find solutions that I might be able to help with? Because if those hook times are your highest, this is not an issue.

Changed Status from Pending to Not a Bug