Upgrade bag issue

Hi

I have a problem when players upgrade a bag. 
The smallest bag costs two of the same to upgrade and it works but if you have three of the same bag it takes the third one as well.
This might be a config issue rather than an issue with plugin.

Seems like there is an issue when you use the same item as upgrade cost as the actual item you want to upgrade?

Setup in config:

      "Name": "armor_clothing.xxsmall",
      "Skin IDs": [
        2828558763
      ],
      "Capacity": 6,
      "Display name": "XXSmall Armor & Clothing Bag",
      "Category name": "armor_clothing",
      "Contents ruleset": "armor_clothing",
      "Upgrade": {
        "To": "armor_clothing.xsmall",
        "Cost": {
          "Item short name": "halloween.lootbag.large",
          "Item skin ID": 2828558763,
          "Amount": 2,
          "Use Economics": false,
          "Use Server Rewards": false
        }
      },
      "Recyclable": {
        "Enabled": true,
        "Ingredients": [
          {
            "Item short name": "purpleidtag",
            "Item skin ID": 3228884437,
            "Amount": 1,
            "Item display name": "Mystic Cloth"
          }
        ]
      }
    },

Video upgrade with three bags in inventory:

Video upgrade with only two bags in inventory:

Thanks for reporting this issue. This is an issue with the plugin, not an issue with configuration. This use case is something I documented on the plugin page, but seems I didn't adequately test it before.

I was able to reproduce the first case, where 2 other bags are consumed. That actually makes sense and matches what the UI says, but it's not how it was intended to work.

I couldn't reproduce the second case. Instead, I saw that I was not allowed to perform the upgrade. However, when I loaded the Item Retriever plugin, then I saw an issue where both bags were consumed and the new bag disappeared. This is an incompatibility where the Item Retriever plugin doesn't know how to ignore an item, whereas the internal item searching logic in Bag of Holding does understand that concept.

I will send you an update over DM to test, along with a patched version of Item Retriever (if you are using that). If that works, I'll release the Bag of Holding update, and coordinate with Item Retriever dev for an update to that as well.

Edit: Actually, it works if you set the required amount to 1. Since the plugin would ignore the bag being upgraded, it displays and functions correctly, only counting other bags as valid ingredients. This is probably what I was doing when originally testing this idea during the early plugin development. However, this would have been broken in the Item Retriever case (which came later) if the bag was empty, as the bag would then consume itself.

Changed Status from Pending to Fixed

Changed Fixed In to 1.9.5