buyraid makes players overpay

Hi nivex,

I got reports from players complaining that Raidable Bases "/buyraid" is taking more scrap from players' inventories than what is set up in the config. I have made it so, that players always have to pay for their raids, easy is 1000 scrap, medium 2000, and so on.

Here is where it gets weird: When the player has the scrap in stacks less than 1000 (the default) the correct amount of scrap is taken. But if you happen to have bigger stacks - like you get 2500 scrap from a raidable base in just 1 stack, the entire stack is taken as if it were a normal stack with 1000 scrap.

In both cases (see screenshots) the payment would have been 4000 scrap for an expert base. In both cases all the scrap was taken, and the player overpaid.

How to reproduce:

Configure "/buyraid" to use scrap - in this case an expert base will be 4000 scrap. Give yourself enough scrap in 2 or 3 stacks, the stacks exceed 1000 and in total you have more than the required 4000 scrap in inventory. Perform "/buyraid". See that your scrap is gone, and you overpaid.

I'm not sure whether this is a new problem, or Raidable Bases always has been like this. However, this wipe was the first time ever a player complained, and it was not just one - another player decided to volunteer and reproduced the problem. So you should have no difficulties to reproduce for yourself. I'm using Raidable Bases on Carbon.

Thanks in advance for looking into this.

hi, thanks for reporting and providing steps to reproduce. this will be fixed in the next update.