Jump to content

2 "scrap" currencies

Pending 1.5.0 1.12.2

devnull
Rainey

Posted (edited)

Hello! Sorry about that, the recent update affected how Item Names are set so I imagine it has something to do with that.

If you set the name of the scrap in your config file to the German translated name (or try and remove the Display Name altogether from the config) does it give the correct/normal scrap? I'll try to do some testing in the meantime. 

Edited by Rainey
devnull

Posted (edited)

Hey. So if I would make the German word METALSCHROTT out of the English SCRAP, surely the 95% of other non-German-speaking players would have a problem 😉

I suspect there is something to be said here, but it is correct at first glance. shortname, skinid = 0, I can't figure it out

 

  public string winnerRewardItemDisplayName { get; set; } = "Scrap";
            [JsonProperty(PropertyName = "Item Shortname")]
            public string winnerRewardItem { get; set; } = "scrap";
            [JsonProperty(PropertyName = "Item Skin ID")]
            public ulong winnerRewardItemCustomSkin { get; set; } = 0;

They are devinitively two items treated differently.
Did you find something?

Edited by devnull
Rainey

Posted

You're correct, language localization is a pain. 😛 I see what it's doing I just have to figure out a workaround for different locales when giving the item to players. I'm working on getting my test server stable again so I can do some testing but in the meantime if you go back to version 1.12.0 it should deposit the correct Scrap regardless of language as it's not dependent on the Display Name in that version. Sorry again, I'll get it figured out soon! 🙂 

devnull

Posted (edited)

Ähm, i am using v 1.12.2, not 1.50 in the thread description.

Where can i get v 1.12.0 ?

Edited by devnull
Rainey

Posted (edited)

If you go to the Updates on the ExtraEvents page and select 1.12.0 in the dropdown you should see a "Download" link below the version description/update. 🙂  I'm doing some testing today to try and sort out the locale/language issue for items. 

Edited by Rainey
Rainey

Posted

So I did quite a bit of testing and research and found that manipulated item names (which is the case here) don't have a translation, which makes sense as they wouldn't know what the German translation would be if the item name was changed to "Flubber" for example. So although the name is still "Scrap" it is technically a manipulated item name that the game doesn't know how to translate. 

The reason ExtraEvents changes the item names in player inventories to what is set as the Display Name in the configuration file is so server admins can give players custom named/skinned items such as "paper" using "Cash" as the item name. Although the item name is manipulated, it is still in fact the base/original item regardless of the name; so in your case "Scrap" is the same as "Metallschrott" and although they have different translated names in your inventory once you combine the stacks it will then only use the "Metallschrott" name. 

So basically this is a bug but not necessarily a huge one, and as you pointed out it likely only affects a small percentage of players who utilize translated versions of the game. 

With all that said I can try and add a configuration option in an upcoming release to the Item lists that would basically let you determine if it changes the Item name in Inventories to the Display Name or if it should use the default/translatable name. 

Please let me know if this makes sense. I apologize that I don't have a better solution at this time, it is a bug but also shouldn't really be a game-breaking concern ultimately. 

Rainey

Posted (edited)

Changed Pending to 1.12.2

Edited by Rainey
devnull

Posted

Since we don't use a custom currency at the moment, let's stay with 1.12.0 for now. It works flawlessly 🤩

Since Rust supports more than 25 languages for good reason, a long-term solution is desirable.

Good luck ✌️

  • Love 1
Rainey

Posted

52 minutes ago, devnull said:

Since we don't use a custom currency at the moment, let's stay with 1.12.0 for now. It works flawlessly 🤩

Since Rust supports more than 25 languages for good reason, a long-term solution is desirable.

Good luck ✌️

Thank you for being flexible. 🙂  I've already started adding an additional configuration to let server owners determine if the item should be renamed when deposited into an inventory, I'm working on a couple additional features and then can release it hopefully within a week or so. 

Thank you again! 

  • Love 1
1.9m

Downloads

Total number of downloads.

8.9k

Customers

Total customers served.

131.2k

Files Sold

Total number of files sold.

2.7m

Payments Processed

Total payments processed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.