Loot Protection not working for player-called airdrops

Hey there,

there is a problem with player-called supply drops. Even though the loot rules have been configured to only allow the owner to loot such an airdrop, it happens all the time that other players are stealing player-called supply drops. That causes a lot of frustration.

Here is the relevant snippet of my `carbon/data/SimplePVE/RulesData.json`

  "Loot Rules": {
    "Use Loot Protection": true,
    "Admin Can Loot All": true,
    "Teams Can Access Loot": true,
    "Player can loot other player in PVP Zones": true,
    "Anyone can open Player called SupplyDrops": false
  },

do you have any other supply drop plugin which is taking over simplepve loot rules?
Like fancy airdrop or other plugins in your server?

38 minutes ago, Iftebinjan said:

do you have any other supply drop plugin which is taking over simplepve loot rules?
Like fancy airdrop or other plugins in your server?

Hey there! Thanks for getting back to me.

Currently I have 2 plugins installed which take care of looting:

1. Horse Lock (not in scope of Simple PVE and should not interfere)
2. Supply Lock (installed to handle player-called airdrops, because Simple PVE fails to handle them)

Here is my entire list of plugins (see attached). To be clear, I never used any loot protection plugins until I detected that Simple PVE does not do what the player-called supply drop option says.

As you can see in the text file I'm using Carbon (on a Linux server w/ Pterodactyl Panel) with a not-too-many plugins configuration. For the PvE implementation I rely on Simple PVE - in my eyes the best and easiest way to run such a server. If you could somehow get the option do what it says that would be the cherry on top of the pie.

plugins.txt

I think the problem lies within how you treat Supply Drops. SimplePVE seems to assume that a Supply Drop entity holds the OwnerID of the rightful owner, which is not the case in reality.

The check in SimplePVE line 2392 does not work, and for that reason loot protection fails. Instead of checking for OwnerID you should check who threw the Supply Signal (or requested the drop from Excavator) and follow how those are linked => Cargo Plane => Supply Drop. If you chain it correctly, it will tell through the link chain which Supply Drop (NetId) belongs to which player, and you can decide whether or not it can be looted according to rules by a player or team mate.

Thanks in advance for looking into it.
If there is interest, I can share a proof-of-concept plugin which uses signal-chains as described to reliably tell which drop belongs to which player. That PoC is based on SupplyLock (free plugin here on codefling) which is using a queue approach (unreliable), and prompted me to dig deeper and investigate. I'm happy to share the (working) source if it helps and you want to use it.

See also

• https://umod.org/documentation/games/rust#onexplosivethrown
• https://umod.org/documentation/games/rust#onexcavatorsuppliesrequest
• https://umod.org/documentation/games/rust#oncargoplanesignaled
• https://umod.org/documentation/games/rust#onsupplydropdropped