Hook Conflict

Hello, I am getting a hook conflict on my carbon server. When i asked about this conflict in the HeliSignals support section i was given this response. Is there anything i can do to fix this conflict?

 

"I checked out that plugin, I don't actually have it as it turns out but on their page they say its compatible with Heli Signals.

The issue is the dev of that plugin is returning from "ShouldFancyDrop" as if it were a Boolean hook, so they are returning false, which some argue is more logical because we don't want Fancy Drop to act on those signals. However, the hook isn't Boolean and it is much more widely accepted that when returning a hook that requires a non null return value to stop normal behaviour, you should return true (which I do). This was discussed at length in the Oxide/Umod discord a long time ago and this was what was decided.

In this case it doesn't hurt anything or break any actions, it just causes the console info spam you are seeing and will continue to do so unless one of us changes the returned hook value. As I'm using the most widely accepted way of returning this type of hook, so I won't change, as this will then cause conflict with many more plugins. This is the same as the console spam that so many servers see with Stack Modifier plugin, as he refuses to return from "CanCombineDroppedItem" hook in the already accepted way as 99.9% of every other dev out there as I described above! 

Anyway, it's up to you, you could find that hook in his code and change the return value to true instead of false, or just ignore it (or ask him to change it for the reasons explained )

Z"

Hook conflict while calling 'ShouldFancyDrop[186179931]': HeliSignals 1.2.26 [True] and InstantAirdrop 1.0.13 [False]

Hey @TuxGeek Thank you for sending this and passing on that information, I totally agree with ZEOD and will update my plugins hook to return true which should resolve the console spam issues you're getting. Keep an eye out for the latest version being released shortly!

Rogder Dodger

Changed Status from Pending to Work in Progress

thank you very much for both the fast response and all your work on this amazing plugin

No worries at all @TuxGeek just drop a message here to confirm it worked and if you have any other issues or questions don't hesitate to get in touch!

Well ive thrown another heli signal and i didnt see the hook conflict in the log for that time and not in the server console anymore. Thank you again very much

Changed Status from Work in Progress to Fixed

Changed Fixed In to 1.0.14