Error Failed to run command

Failed to run command '/trade' on plugin 'WTrading'. (NullReferenceException: Object reference not set to an instance of an object)
  at Oxide.Plugins.WTrading+Trade.Accept () [0x000b4] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Plugins.WTrading+AcceptTradeCommand.Execute (Oxide.Plugins.WTrading+TradePlayer caller, System.String[] arguments) [0x00128] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Plugins.WTrading.CommandHandler (BasePlayer player, System.String name, System.String[] arguments) [0x00023] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Plugins.WTrading+TradeCommand.ProcessAliases (Oxide.Plugins.WTrading+TradePlayer player, System.String[] arguments) [0x0005e] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Plugins.WTrading+TradeCommand.Execute (Oxide.Plugins.WTrading+TradePlayer caller, System.String[] arguments) [0x00037] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Plugins.WTrading.CommandHandler (BasePlayer player, System.String name, System.String[] arguments) [0x00023] in <d52b4dbe82f34c27844d531074483854>:0 
  at Oxide.Game.Rust.Libraries.Command+ChatCommand.HandleCommand (BasePlayer sender, System.String name, System.String[] args) [0x0001b] in <dfdf477e6daf4317a0bcc18cf1c4c7f5>:0 
  at Oxide.Game.Rust.Libraries.Command.HandleChatCommand (BasePlayer sender, System.String name, System.String[] args) [0x00015] in <dfdf477e6daf4317a0bcc18cf1c4c7f5>:0 
  at Oxide.Game.Rust.RustCore.TryRunPlayerCommand (BasePlayer basePlayer, System.String message, System.String commandPrefix) [0x000c2] in <dfdf477e6daf4317a0bcc18cf1c4c7f5>:0 

also everytime i send a trade to someone to test things, I see this pop up "NullReferenceException: Object reference not set to an instance of an object"

Changed Status from Pending to Can't Reproduce

I need steps to reproduce this error, did the recipient of the trade request leave?

If you can work out what causes this it would be incredibly useful for fixing the problem.

didnt update the config was the issue.

everything is working so far. no issues other than cooldown?  

" "request_repeats": 1,
  "request_timeout": 20.0,
  "accept_delay": 0.01,
  "trade_cooldowns": {
    "default": 900
  }, "

I set the trade cooldown to 900 but it is going off of something else? 

@Tom.bat

Is it possible that player doesn't have the default role?

6 minutes ago, Tom.bat said:

Is it possible that player doesn't have the default role?

its everyone, including myself and others. and a player not having default group is impossible because it is assigned upon first join for every server.

Thought so, releasing an update right now which should hopefully resolve this.

Changed Status from Can't Reproduce to Work in Progress

Changed Fixed In to 1.1.11

Seems to be fixed now, however I cant help but to notice a typo lol

Also it appears the trade never cancels? I trade a player,  and have them decline it, i waited about 10 minutes and tried to trade the same guy again and it still says "you've already sent a trade request to this player." as well when i leave the trade accept/decline ui on screen, it never goes away.

13 hours ago, Kaooa said:

Seems to be fixed now, however I cant help but to notice a typo lol

 

Well spotted, not sure how I managed this lol

13 hours ago, Kaooa said:

Also it appears the trade never cancels? I trade a player,  and have them decline it, i waited about 10 minutes and tried to trade the same guy again and it still says "you've already sent a trade request to this player." as well when i leave the trade accept/decline ui on screen, it never goes away.

Interesting, do you recall this occuring in previous versions? Getting any errors?

I do not know if it has worked in past versions just now noticing it.  sometimes i see "FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list." but i do not know which plugin this is from, haven't noticed that error until yesterday when i noticed the issue 

also missing some item images in the generative images - console log : 

03/18 00:56:30 | [WTrading] Started trade between pulse_code_77 and Teflon.

03/18 00:56:43 | [WTrading] Completed trade between pulse_code_77 and Teflon:
pulse_code_77 gave 12 item(s): - Bandage x2
- Sheet Metal x1
- Pickaxe x1
- Tech Trash x3
- Rifle Body x1
- Medical Syringe x2
- Scrap x16
- High Quality Metal x33
- Salvaged Sword x1
- Reinforced Wooden Shield x1
- Road Signs x3
- Bucket Helmet x1
Teflon gave no items.

10 hours ago, Kaooa said:

I do not know if it has worked in past versions just now noticing it.  sometimes i see "FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list." but i do not know which plugin this is from, haven't noticed that error until yesterday when i noticed the issue 

This will likely be another plugin, I always log messages alongside exceptions and include the full thing so it'd be a bit more traceable.

10 hours ago, Kaooa said:

also missing some item images in the generative images - console log : 

03/18 00:56:30 | [WTrading] Started trade between pulse_code_77 and Teflon.

03/18 00:56:43 | [WTrading] Completed trade between pulse_code_77 and Teflon:
pulse_code_77 gave 12 item(s): - Bandage x2
- Sheet Metal x1
- Pickaxe x1
- Tech Trash x3
- Rifle Body x1
- Medical Syringe x2
- Scrap x16
- High Quality Metal x33
- Salvaged Sword x1
- Reinforced Wooden Shield x1
- Road Signs x3
- Bucket Helmet x1
Teflon gave no items.

 

The image generation relies on FP uploading item images to their CDN which they've not done for several items. I'm not sure there's a good workaround to this except you can manually add the images yourself if you upload them to: oxide/data/WTradingDiscord/ItemCache/{item_id}.png.

Changed Status from Work in Progress to Fixed

Changed Fixed In from 1.1.11 to Next Version

Changed Status from Fixed to Closed