Kicked Players - RPC Errors

Since the last update, I've had players tell me that they have been getting kicked when trying to repair an enchanted item. I've been able to reproduce this error as well. On the first repair, you get kicked with "Disconnected: RPC Error in RepairItem". After you reconnect, even just trying to move the now repaired enhanced item can give "Disconnected: RPC Error in MoveItem" when just trying to move it from one inventory slot to another. The only way to get rid of the item is to drag and drop it out of inventory, which kicks the player, and produces a loot bag on the ground that has no item name and you can't pick it up. I'm not really sure if it's the Item Perks or maybe another plugin conflicting with it. I saw an earlier support ticket that recommended setting "Prevent the maximum condition of the item from being reduced when repaired?" to false, which I've done, but the issue keeps happening. I've tried the same repair sequence with normal weapons and haven't had any issues, so it's definitely only an enhanced item issue, just not sure from where.

Thanks!

1 hour ago, LandOfTheBlind said:

Since the last update, I've had players tell me that they have been getting kicked when trying to repair an enchanted item. I've been able to reproduce this error as well. On the first repair, you get kicked with "Disconnected: RPC Error in RepairItem". After you reconnect, even just trying to move the now repaired enhanced item can give "Disconnected: RPC Error in MoveItem" when just trying to move it from one inventory slot to another. The only way to get rid of the item is to drag and drop it out of inventory, which kicks the player, and produces a loot bag on the ground that has no item name and you can't pick it up. I'm not really sure if it's the Item Perks or maybe another plugin conflicting with it. I saw an earlier support ticket that recommended setting "Prevent the maximum condition of the item from being reduced when repaired?" to false, which I've done, but the issue keeps happening. I've tried the same repair sequence with normal weapons and haven't had any issues, so it's definitely only an enhanced item issue, just not sure from where.

Thanks!

There is another plugin that exists on your server that is causing the issue. I have tried this with a number of customers who experienced the issue, and regardless of what patches I changed etc, they were kicked for the items bring repaired. The only thing you can do is unload all other plugins on your server to test, then systematically reload plugins and test until it happens again.

Thank you for the reply. Since the issue just started this wipe, I unload all other plugins that were updated this month and was still able to reproduce the RPC errors. I did notice something that might be helpful. After I triggered the RPC kick bug the first time, I was unable to use the ipgive command to give myself any enhanced items and would get this message in console anytime I tried:

(04:33:22) | Failed to call hook 'GiveItemConsoleCommand' on plugin 'ItemPerks v1.0.20' (NullReferenceException: Object reference not set to an instance of an object)
  at Oxide.Plugins.ItemPerks+Item_MaxStackable_Patch.Prefix (Item __instance, System.Int32& __result) [0x0006c] in <d9528cf6c37a422c9f93738904602a56>:0 
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Item.MaxStackable_Patch109(Item)
  at PlayerInventory.GetIdealPickupContainer (Item item, System.Boolean tryWearClothing) [0x00000] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at PlayerInventory.GiveItem (Item item, ItemMoveModifier modifiers, ItemContainer container) [0x0002d] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at PlayerInventory.GiveItem (Item item, ItemContainer container) [0x00000] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at BasePlayer.GiveItem (Item item, BaseEntity+GiveItemReason reason) [0x00059] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at Oxide.Plugins.ItemPerks.GiveItemWithPerks (BasePlayer target, System.String shortname, System.Collections.Generic.List`1[T] perks, System.UInt64 skin) [0x0003e] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.GiveItemCMD (BasePlayer player, System.String[] args, System.Boolean console) [0x001a7] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.GiveItemConsoleCommand (ConsoleSystem+Arg arg) [0x00007] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x01099] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <9c80d821d00a44c9a24497c73ad2d20d>:0 
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000de] in <d646191a355d43a6b3ab36b7ee14c740>:0 
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <d646191a355d43a6b3ab36b7ee14c740>:0

I could still use the ipgivekit to get an enhancement pack and apply it to an item, and could then trigger the RPC kick bug once that item was repaired for the first time. Even with the vast majority of plugins unloaded, once the RPC bug starts, nothing stops it other than a restart of the server. Based on the error above that points to the Harmony patch for stack handling, I found the 2 settings in the config and have set those to false to see if that makes a difference after the next server reboot. I am running Oxide/Umod and not Carbon, if that makes a difference. I did notice that in the Unload() method, you only unpatch Harmony when it's running Carbon, so I didn't know if maybe something is happening when I'm reloading Item Perks while testing, if it's causing Harmony issues which is why the problem persists after all other plugins are unloaded as well? I'll keep testing to see if I can narrow down the issue further but right now, once it starts, it's broken until a restart of the server.

Thanks!

1 hour ago, LandOfTheBlind said:

Thank you for the reply. Since the issue just started this wipe, I unload all other plugins that were updated this month and was still able to reproduce the RPC errors. I did notice something that might be helpful. After I triggered the RPC kick bug the first time, I was unable to use the ipgive command to give myself any enhanced items and would get this message in console anytime I tried:

(04:33:22) | Failed to call hook 'GiveItemConsoleCommand' on plugin 'ItemPerks v1.0.20' (NullReferenceException: Object reference not set to an instance of an object)
  at Oxide.Plugins.ItemPerks+Item_MaxStackable_Patch.Prefix (Item __instance, System.Int32& __result) [0x0006c] in <d9528cf6c37a422c9f93738904602a56>:0 
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.Item.MaxStackable_Patch109(Item)
  at PlayerInventory.GetIdealPickupContainer (Item item, System.Boolean tryWearClothing) [0x00000] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at PlayerInventory.GiveItem (Item item, ItemMoveModifier modifiers, ItemContainer container) [0x0002d] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at PlayerInventory.GiveItem (Item item, ItemContainer container) [0x00000] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at BasePlayer.GiveItem (Item item, BaseEntity+GiveItemReason reason) [0x00059] in <e1d50bfa616d485d876be5ea47e331f1>:0 
  at Oxide.Plugins.ItemPerks.GiveItemWithPerks (BasePlayer target, System.String shortname, System.Collections.Generic.List`1[T] perks, System.UInt64 skin) [0x0003e] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.GiveItemCMD (BasePlayer player, System.String[] args, System.Boolean console) [0x001a7] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.GiveItemConsoleCommand (ConsoleSystem+Arg arg) [0x00007] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.ItemPerks.DirectCallHook (System.String name, System.Object& ret, System.Object[] args) [0x01099] in <dc68f7fd24124c62bd9696f796e56174>:0 
  at Oxide.Plugins.CSharpPlugin.InvokeMethod (Oxide.Core.Plugins.HookMethod method, System.Object[] args) [0x00079] in <9c80d821d00a44c9a24497c73ad2d20d>:0 
  at Oxide.Core.Plugins.CSPlugin.OnCallHook (System.String name, System.Object[] args) [0x000de] in <d646191a355d43a6b3ab36b7ee14c740>:0 
  at Oxide.Core.Plugins.Plugin.CallHook (System.String hook, System.Object[] args) [0x00060] in <d646191a355d43a6b3ab36b7ee14c740>:0

I could still use the ipgivekit to get an enhancement pack and apply it to an item, and could then trigger the RPC kick bug once that item was repaired for the first time. Even with the vast majority of plugins unloaded, once the RPC bug starts, nothing stops it other than a restart of the server. Based on the error above that points to the Harmony patch for stack handling, I found the 2 settings in the config and have set those to false to see if that makes a difference after the next server reboot. I am running Oxide/Umod and not Carbon, if that makes a difference. I did notice that in the Unload() method, you only unpatch Harmony when it's running Carbon, so I didn't know if maybe something is happening when I'm reloading Item Perks while testing, if it's causing Harmony issues which is why the problem persists after all other plugins are unloaded as well? I'll keep testing to see if I can narrow down the issue further but right now, once it starts, it's broken until a restart of the server.

 

Thanks!

Even disabling the repair patch (where it doesn't load the harmony patch), the error still persists, so its something else at play.

This error started to do this on my server after I updated the server this wipe. 

I did unload all plugins and still doing the error. All players moving items with enchanted get disconnected with the same error here.

(PS: It started after I reload the plugin)

disable repairing to max.