Jump to content

has a security flaw, can use until fixed

Work in Progress 1.0.1 Next Version

PhatBlinkie
PhatBlinkie

Posted

here is the scenario, a player tries to sell an item, say gunpowder, and lets say 1 million for 1 scrap. when the buyer buys, if thier slots are all full, OR if the stack sizes for whatever item (does not need to be gunpowder, can be anything that can sell) are low, , the server will lag out while 1 million gunpowder (in drops the size of the servers stack size) eject out of the player.   as an example, if you hit f1 console and gave yourself 1k of an item, and the stack size was say 10, you would not expect your entire inventory to fill up , and then eject the rest all over the place.

There needs to be a modifiction to how this actually provides the item to the player or this can be easily exploited. setting stack sizes is not the answer, because a player can just find something that is not set super high (plus, admins dont want to set all items to 10m to prevent this)

SinKohh

Posted

On 12/15/2024 at 7:28 PM, PhatBlinkie said:

here is the scenario, a player tries to sell an item, say gunpowder, and lets say 1 million for 1 scrap. when the buyer buys, if thier slots are all full, OR if the stack sizes for whatever item (does not need to be gunpowder, can be anything that can sell) are low, , the server will lag out while 1 million gunpowder (in drops the size of the servers stack size) eject out of the player.   as an example, if you hit f1 console and gave yourself 1k of an item, and the stack size was say 10, you would not expect your entire inventory to fill up , and then eject the rest all over the place.

There needs to be a modifiction to how this actually provides the item to the player or this can be easily exploited. setting stack sizes is not the answer, because a player can just find something that is not set super high (plus, admins dont want to set all items to 10m to prevent this)

Thank you for bringing this to my attention. I am playing around with different scenarios right now to resolve this issue 

SinKohh

Posted

Changed Status from Pending to Work in Progress

Changed Fixed In to Next Version

SinKohh

Posted

Can you please send a video (without buying the item so you dont lag) and explain what you are saying? I want to make sure I am testing your scenario specifically

PhatBlinkie

Posted

actually, it may not make it to a problem of being severe. since they will have a hard time filling the machine with large amounts of an item due to a servers stack size limiting the ability. so you can close this.
a wish list item though is to add a permission to the plugin, so it can be used as a perk, instead of everyone on the server being able to run the command

1.7m

Downloads

Total number of downloads.

7.8k

Customers

Total customers served.

117.7k

Files Sold

Total number of files sold.

2.4m

Payments Processed

Total payments processed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.