Jump to content

CanCombineDroppedItem conflict

Pending 2.5.2

tacman1981
tacman1981

Posted

Calling hook CanCombineDroppedItem resulted in a conflict between the following plugins: Loottable - True (Boolean), FurnaceUpgrades (False (Boolean))

it often leaves smaller stacks of things like metal frags, or charcoal in a furnace, which will not stack on top of the same item.
1 player even reported that their picked up furnace, went onto a skinned door stack.

tacman1981

Posted

it is still doing this, quite regularly. it affects the furnace output by making a new stack of cooked ore, that wont stack with the others. when it happens more than once, the furnace stops because its no longer able to place a cooked item into the furnace output, dumping it on the ground and switching off the furnace. this is a serious issue and cant remain ignored.

tacman1981

Posted (edited)

        private object CanStackItem(Item source, Item target)
        {
            if (source == null || target == null)
                return null;
                
                if (!_furnacesData.ContainsKey(source.uid.Value) || !_furnacesData.ContainsKey(target.uid.Value))
                {
                    return null;
                }
                else
                {
                    return false;
                }
                    
            return null;
        }

 

I basically flipped your check to prevent the conflict, so far so good.

Edited by tacman1981
i think it works this time.
tacman1981

Posted

ok, its been almost 2 weeks and i have no more reports or visual observations where the stacks are splitting at random. this is definitely the fix for the stacking issue

tacman1981

Posted

ok, this patch requires adding as an update, so there is no more conflicts with loottable and random items being unstackable inside upgraded furnaces. it stopped happening once i added the above patch, should also be universal to fix all stacking issues across the board.

tacman1981

Posted

hey, i saw you put out an update and still never fixed the stacking issue. you should really consider this as i have tested it for almost 2 whole months and never had a single conflict. i fear installing this update will make it start happening again. i even fixed the problem for you and you just ignore it....

1.7m

Downloads

Total number of downloads.

7.8k

Customers

Total customers served.

117.7k

Files Sold

Total number of files sold.

2.4m

Payments Processed

Total payments processed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.