Problem with RustRewards compatibility.

Hi, 
I'm having an issue with Loottable&StacksizeGUI where I modified the pickup rate of collectibles to times two. 
But when using RustRewards (Steenamaroo) your plugin prevent RR to rewards when picking the collectibles, RR only rewards if I Disabled the modifications inside Loottable&StacksizeGUI (Go back to Vanilla). 
I contacted Steenamaroo first and he showed me this could be conflicts of the two plugins killing the collectables. 

Is there anyway you could do about this ? Or if this requires a fix from Steenamaroo side,
Please let me know. 

Thank you.

turns out that i needed to set the "Include extra items in total item count": false, to true

thank you @Steenamaroo

On 3/27/2025 at 10:07 AM, OfflineGotOfflined said:

turns out that i needed to set the "Include extra items in total item count": false, to true

thank you @Steenamaroo

 

This setting has nothing to do with how the gathering system works. It only changes how the min and max item amounts are calculated.

@Steenamaroo After gathering, the dispenser is destroyed immediately. To get the items that have been gathered you can use the hook OnCollectiblePickedUp. I can also send you the code of the hook if that helps.

12 minutes ago, Steenamaroo said:

I use OnCollectiblePickup for issuing gather rewards (RustRewards plugin) but, from what I'm told, it ceases to work when people use your plugin to modify gather amounts.
I guess that means you're destroying the dispenser before I get to it?
 

That's correct. Even if the dispenser was not destroyed immediately, the itemList would still contain incorrect items/amounts as Loottable uses a completely different system for collectibles. Therefore I recommend you to use the hook OnCollectiblePickedUp instead which is called for every item that has been collected.

8 minutes ago, Steenamaroo said:

I don't see how that's going to work.
The hook you suggest happens later. I'm going to have the same problem.

Would it not make more sense for you to just clear the itemList instead of prematurely destroying the entity?

That way you get what you want, other plugins can use OnCollectiblePickup hook, and the vanilla pickup effects and destruction would still happen.

This works because Loottable returns non-null in OnCollectiblePickup so the following vanilla logic is not called anymore. That makes it necessary for Loottable to destroy the entity as it would not be destroyed otherwise. Also the OnCollectiblePickedup hook is called by Loottable when the entity has not been destroyed yet

1 hour ago, The_Kiiiing said:

This setting has nothing to do with how the gathering system works. It only changes how the min and max item amounts are calculated.

@Steenamaroo After gathering, the dispenser is destroyed immediately. To get the items that have been gathered you can use the hook OnCollectiblePickedUp. I can also send you the code of the hook if that helps.

But RustRewards only give points to Collectibles if only this setting is set to true. I believe the issue is only happens after the latest release. Before that I don't encounter any trouble

On 3/28/2025 at 5:09 PM, Steenamaroo said:

Yeah, I understand what you're doing but it doesn't seem like a great approach because it makes a hook cease to function for other developers.

If you empty the vanilla itemList, do your own item distribution, and call OnCollectiblePickedup, if you want, you could achieve the same thing without impacting OnCollectiblePickup hook.

I already tried this before, the problem is that there is no way to prevent the random gathering of grubs, worms, etc. as they are not contained in the item list

I'm currently experimenting with a harmony prefix that runs instead of the original pickup method. That way I can call the hook OnCollectiblePickup before the entity is destroyed while also removing the RandomItemDispenser thing.

26 minutes ago, Steenamaroo said:

Wrapping your kill in a nexttick would do but whatever works for you.

I'm gonna do that, the harmony thing would probably break other plugins