Possible conflict with SkillTree plugin.

Hi
Im running the SkillTree plugin on my server.
Bought this plugin to get a better backpack system on my PvE server.
My idea was to add the different bag upgrades as skillpoints in the SkillTree plugin.
Ive been trying to set it up today before todays forcewipe, but i ran into a strange issue.

I made custom skills thats suppose to grant players the permissions they need so they can upgrade the backpacks.
But skilltree wont grant those permission as its suppose to do.
I have to manually grant the permissions to make upgrading work.
Its working flawless with other plugins with permissions i use together with SkillTree.
Nightvision, MyMini, Masterlock, BuildingGrades +++++++

Ive been in contact with Imthenewguy, the developer of SkillTree plugin......
He took a look at my config, and didnt find any issues......
He asked me to bring this to you to see if u know what the issue might be.
Your also welcome to contact him if there might be any conflicts between BagOfHolding and SkillTree.

Changed Status from Pending to Work in Progress

I don't know of any reason that they would conflict in this regard. The permissions in Bag of Holding are registered the same way as other plugins, and there is no logic in Bag of Holding which prevents granting specific permissions. Are you sure you have designated the correct permissions in the Skill Tree config? Can you attach your config?

I also just purchased Skill Tree to see if I can recreate this issue.

Here is the custom skills ive added for upgrading the generic bag and the armor/clothing bag


"Backpack": {
      "enabled": false,
      "nodes": {
        "Backpack": {
          "enabled": true,
          "max_level": 7,
          "tier": 1,
          "value_per_buff": 1.0,
          "buff_info": {
            "Key": 69,
            "Value": 5
          },
          "icon_url": "www.haukas.nu/rust/backpack2.png",
          "skin": 0,
          "permissions": {
            "description": "This skill let you upgrade your backpack from 6 to 48 slots. 6 Slots per level. (Upgrade from backpack menu when unlocked.)",
            "perms": {
              "1": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack"
                }
              },
              "2": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack"
                }
              },
              "3": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack",
                  "upgrade.generic.small ": "24 Slot Backpack"
                }
              },
              "4": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack",
                  "upgrade.generic.small": "24 Slot Backpack",
                  "upgrade.generic.medium": "30 Slot Backpack"
                }
              },
              "5": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack",
                  "upgrade.generic.small": "24 Slot Backpack",
                  "upgrade.generic.medium": "30 Slot Backpack",
                  "upgrade.generic.large": "36 Slot Backpack"
                }
              },
              "6": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack",
                  "upgrade.generic.small": "24 Slot Backpack",
                  "upgrade.generic.medium": "30 Slot Backpack",
                  "upgrade.generic.large": "36 Slot Backpack",
                  "upgrade.generic.xlarge": "42 Slot Backpack"
                }
              },
              "7": {
                "perms_list": {
                  "upgrade.generic.xxsmall": "12 Slot Backpack",
                  "upgrade.generic.xsmall": "18 Slot Backpack",
                  "upgrade.generic.small": "24 Slot Backpack",
                  "upgrade.generic.medium": "30 Slot Backpack",
                  "upgrade.generic.large": "36 Slot Backpack",
                  "upgrade.generic.xlarge": "42 Slot Backpack",
                  "upgrade.generic.xxlarge": "48 Slot Backpack"
                }
              }
            }
          }
        },
        "Armor & Clothing": {
          "enabled": true,
          "max_level": 1,
          "tier": 2,
          "value_per_buff": 1.0,
          "buff_info": {
            "Key": 69,
            "Value": 5
          },
          "icon_url": "https://haukas.nu/rust/backpack2.png",
          "skin": 0,
          "permissions": {
            "description": "This skill let you upgrade your Armor & Clothing backpack from 6 to 48 slots. 6 Slots per level. (Upgrade from backpack menu when unlocked.)",
            "perms": {
              "1": {
                "perms_list": {
                  "upgrade.armor_clothing.xxsmall": "12 Slot Backpack"
                }
              }
            }
          }
        }
      }
    },

The permissions are incorrect. Missing the bagofholding prefix.

For example:

"7": {
  "perms_list": {
    "bagofholding.upgrade.generic.xxsmall": "12 Slot Backpack",
    "bagofholding.upgrade.generic.xsmall": "18 Slot Backpack",
    "bagofholding.upgrade.generic.small": "24 Slot Backpack",
    "bagofholding.upgrade.generic.medium": "30 Slot Backpack",
    "bagofholding.upgrade.generic.large": "36 Slot Backpack",
    "bagofholding.upgrade.generic.xlarge": "42 Slot Backpack",
    "bagofholding.upgrade.generic.xxlarge": "48 Slot Backpack"
  }
}

There is also an issue in your "3" section where the small permission has an extra space before the end quote. I will suggest that Skill Tree be updated to trim such extra spaces automatically.

Edited February 2, 2023 by BlackLightning

Ah.... i see....  in permission manager the prefix didnt show.... but i really should have known that.......
Guess ive been awake for too long......
I couldnt understand why it wouldnt work...... every other plugin ive implemented into the skilltree have worked fine....

Well thanks alot for your help......
Gonna try it when i get the server up again......
Problems after the server update.....

It works like it should be....
It was just that i made a "bo bo" with the missing prefix in the beginning.
You can close this case....

Other thing while im in touch with you.......

Possible to add a permission  to use this plugin?
The way it is now when im integrating BagOfHolding with SkillTree, then first 6 slots of the backpack will be for free.
Its just for the upgrades that will cost skills...
Its not a big deal, but would have been nice.....
 

Thanks for your help!

You can basically make bags require permission by setting bag limits. For example, set the player limits to 0 by default, then raise it for players with permission. This may not be as flexible as you want, though, because you cannot upgrade bag limits in separate linear paths like you can with upgrade permissions.

When I was originally envisioning how Bag of Holding would be integrated with Skill Tree, I was only thinking of bag limits, particularly the total bag limit. For example, you could add a node that allows one bag, then upgrades to two, three, four, five, etc. You could have separate nodes for backpack limits and container limits since those are upgradeable independently.

Edited February 3, 2023 by BlackLightning

That makes sense.....
But i thought of maybe a workaround. with this.
Keep the orginal skilltree pouch and expand it with the bag of holding category bags....
Gonna mess around abit with it the next couple of days and see what i come up with....

But damn you have made a amazing work with this plugin 10/10!
Saw the video from Srtbull / RustAdminAcademy and immediately fell in love with it.

Keep up the good work and have a nice weekend

Thanks for the kind words. Once you've had some more time to work the plugin, please consider writing a review.

Regarding the ability to upgrade bag limits independently for different bag categories, while I don't see a clear path forward at this time, you've definitely given me something to think about for future updates.

Regarding your idea of placing bags inside the Skill Tree pouch (if I understood correctly), the pouch's implementation is pretty basic, especially compared to the Backpacks plugin, so you'll likely find some issues or limitations. For example, while Bag of Holding was being beta tested around 6 months ago, there was an issue where you could not open bags while they were inside the pouch, because as soon as you stopped looting the pouch itself, the Skill Tree plugin would save the pouch items and delete the pouch, therefore invalidating the bag item that you are attempting to open. That meant you could store bags inside the pouch, and even drop items onto the bags while in the pouch, but you could not open the bags without first removing them from the pouch. I don't know if that issue has been resolved, but there will definitely be other issues, though many of them may be minor or go unnoticed for a long time. I strongly suggest using the Backpacks plugin over the Skill Tree pouch for that use case because it is more sophisticated and has better compatibility with Bag of Holding. Furthermore, with the introduction of the permission perk feature, you should be able to provide an upgradable Backpack via the Skill Tree (as a replacement for the pouch). With Backpacks v3.10, you can even implement Gather and Retrieve mode as additional Skill Tree perks which I could definitely see players wanting to use.

If you want to expand on using the pouch, another limitation is that there isn't a way to configure bag limits for the pouch specifically, like there is for Backpacks. I actually implemented a feature for that, but it's disabled at the moment because bags in the pouch were not fully functioning during the beta. You can in fact enable that feature by uncommenting the FEATURE_EXTRA_POCKETS_CONFIG compile time flag near the top of the plugin file. Upon enabling that feature, a section called "Extra Pockets bag limits" will be added to the config. Without that feature, bag limits inside the pouch will be determined according to "Container bag limits". If you do end up using that feature, please let me know so I can consider enabling it for all (if the issue where you can't open bags in the pouch is fixed, then I probably will enable that feature).

Thought i could try to make it work placing the category bags in the pouch..... but if thats not working proper, im also fine with having those bags in the main inventory instead.....
Gonna test multiple sollutions to see what works best for me and my server. Im sure i will get a good  sollution.
But im open to go back to the backpacks plugin again..... used to use that before i installed skilltree.
There its fully functional with permissions also, and very easy to make skills in skilltree (if i make the right prefix on permissions hehe)
Time will show what i come up with.

Now im using the BagOfHolding bag and placed them inside, but i found one kinda annoying thing with the way i run it now. 
If im activating gather on the BagOfHolding and transfering loot from one of the bags into the belt slots, it dissapears automaticly back into the bag.
This can be for example syringes, equipment and such..... But transfering loot into main inventory works fine, but not the beltslots.
So ive deactivated the gather for now and just transfering the loot i pick up to the bag of holding when main inventory is full.... 
Then loot gets divided into the category bags until they are full. That way im preventing items beeing  moved unless i want to.
Havent been digging that much into the configurations yet and running mostly default config..
I have Just seen srtbulls video  and took some tips from him and read a part of the info you have written in the documentation.
But gonna dig deeper into the config now when im testing.
Gonna do alot of testing the next 2 weeks until thenext serverwipe.... , so i can release this for the serverpopulatiuon to use by then.

Last night it was a "wipe from hell". Update really messed up my server. Had to spend 4-5 hours fixing things to get it back together.
So im kinda tired of messing with plugins atm.

A review will come when i have more "meat on the bone"  and know more about what this plugin can do and get something that works for my server.

Thanks for the tips. Wish you a great weekend.

I'll be taking a look at gather mode soon to make several improvements. For example, don't gather anything while you are looting a bag, don't gather any item that is transferred between inventory containers (though can't really help the split-drag case at this time), and a "Gather: Existing" mode to only gather items that are already in the bag.

Edited February 3, 2023 by BlackLightning

Changed Status from Work in Progress to Closed

Hi again....
I experienced something now and im not sure why this happend.....
I have just added Backpacks plugin and removed the restriction on opening bag of holding bags inside backpack......
Then all my bags  started to act like halloween bags and giving me loot and consuming the bag instead of opening backpack.....
Skin ID havent been changed....

All i did was removing Ui Belt button, removing scrap upgrade  cost (will cost skillpoint), add Backpacks plugin and removing restriction on opening bags inside backpack.....
Tried to open bags both in backpack and main inventory.....
Any clue why this happends?   
Same happend when i changed the default skin to the tactical ones the day i bought this plugin.
But that i assume was cause i changed the skins in configfile.....

This cant be happening after i open up BagOfHolding plugin to the players on my server. Then they  are going to be mad.....

 

Just me that made a mistake in the config file, so the plugin reloaded the default config......
Then the orginal skins were loaded..... Then ofcourse tactical skin dont work ........
 

Ah, that is a problem I recently surmised could eventually happen. Loading the default config when the config syntax is invalid is standard behavior for many plugins, but in some cases it does not make sense, like for this plugin. When developing the plugin, I was mostly concerned about what happens if the plugin is temporarily unloaded, which is handled by persisting code in the game so that bags still have basic functionality like open and close.

I will consider changing the behavior in an upcoming version, to make the plugin just do nothing when the config fails to load. That will allow the existing code from the previous load of the plugin to work somewhat until you resolve the config issue.

When changing skins after you have existing bags, I recommend the commands because they will find and update the skins of all bags currently in the game world, though there are some limitations, like they can't find bags that are hidden away by other plugins such as kits, skill tree pouches, and backpacks of disconnected players.

Edited February 11, 2023 by BlackLightning

Thx for the advice....
Other thing.....
Im nearly finished setting up the backpack skills in the skilltree.

Installed the Backpacks plugin from uMod, so i can have the keep on death ability as a skill aswell....
So ive added one skill with 8 points to unlock backpack with 1-8 rows. And a another skill to unlock the feature keep backpack on death....
Then ive made a kit that unlocks when you unlock the 8th row on the backpack. 
That kit gives you the aditional category bags
Then ive added a skill on each of the category bags for upgrading them from 6 to 42 slots. That  gives 6 skillpoints per backpack.

Then i started thinking..... This might give the players a way to get around this..... by upgrading all the bags, then respec the skills and use skillpoints somewhere else.
Then they still got the category bags fully upgraded.....
Is there a way to set a rule on them so they for example require a permission to be opened? 
 

I don't think blocking opening is the way to go as it's too punishing if the bags already have content.

I suppose upgrade permissions and bag kits are probably not the best things to use for player-resettable progression.

If you stick to bag limits for progression, exploits will be mitigated when players die for instance, since they won't be able to pick back up the bags without emptying them. If their backpack has too many bags, excess should be ejected after some time.

One technique you could explore would be to define new categories of bags that can be upgraded to, then create limits around those. For more details, see another recent support thread where I showed how to make a "VIP Bag of Holding" bag. Limits would probably start to get a bit messy though.

Just want to prevent players from respec skills after they have upgraded the bags so they can spend their points on something else to save points.
Then the bags will be useless unless they place their skills back on the backpack to get the permissions needed again.
Its a PvE server so the backpacks is unaccessable to other players anyway. So players wont be picking up others backpacks.
Think its just a matter of time until players find out how to cheat.
Bag kits are just a way to give the players a way to get the smallest bags after they have fully upgraded their umod backpack so they can start upgrading them.,
Also gonna set a limit on how many category bags u can have.
And if players have their bags in the backpack, then they wont loose them when they die.

I would just stick to something simple that the plugins can do today.

One linear progression for player inventory bag limit: 1, 2, 3, 4, 5, 6 bags. Simple and easy to understand for players. You could expand on this, to only unlock being able to carry certain bags, such as the Generic bag or Bag of Holding bag, in later stages.

One linear progression for player container bag limits: 1, 2, 3, 4, 5, 6 bags. Only if you want to allow players to store non-empty bags in storage containers.

One progression for backpack size: 1, 2, 3, 4, 5, 6, 7, 8 rows. You could go further since Backpacks v3.9 now supports multiple pages.

One node for Backpacks keep on death.

One node for Backpacks gather mode, in v3.10 beta.

One node for Backpacks retrieve mode, from Backpacks v3.10 beta.

One linear progression for Backpacks bag limits: 1, 2, 3, 4, 5, 6 bags. By upgrading this, if the player has the keep on death node, this allows players to keep more bags on death, as long as they keep those bags in the backpack.

The standalone Backpacks nodes could optionally be added to the other linear progressions, or could become a separate linear progression.

Edited February 12, 2023 by BlackLightning

Now you gave me a bunch of new ideas.....
By the way....  I see you have  solved the issue that annoyed me with the latest update....
Items that moves back to the backpacks after you transfer them to your main inventory. Good job 
Was kinda annoying that i had to turn on and off gather mode to prevent it.